Skip to content

Fix implicitly defined globals in SC.MenuPane #864

Merged
merged 1 commit into from Nov 11, 2012

4 participants

@mitchless

I'm not sure if these were causing problems or what problems they would have been causing, but its not good to go around implicitly defining globals.

@mitchless mitchless Implicit globals, creating a possible memory leak. Not sure if these …
…were in fact cause a problem but as I was looking to extend this class those jumped out at me.
45187e8
@nicolasbadia
SproutCore member

+1

@dcporter
SproutCore member
dcporter commented Nov 5, 2012

Good find! This probably isn't too worrisome a leak, since max leakage is capped at two objects, but trampling over the global scope is definitely a bad thing.

A glance-over doesn't suggest any issues with this. If it runs and the unit tests pass then I recommend a merge.

@publickeating publickeating merged commit 693bbe8 into sproutcore:master Nov 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.