Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picking): implement picking lists component loading indicator #691

Merged

Conversation

aleespryker
Copy link
Contributor

@aleespryker aleespryker commented Aug 4, 2023

closes: HRZ-89545

@aleespryker aleespryker added the wip label Aug 4, 2023
@aleespryker aleespryker requested a review from a team as a code owner August 4, 2023 09:27
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 9f97a3b
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64d603ede1cc960008e5ac82
😎 Deploy Preview https://deploy-preview-691--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 9f97a3b
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64d603edaaef7e00083754af
😎 Deploy Preview https://deploy-preview-691--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 9f97a3b
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64d603ed92d4dc000806fd5e
😎 Deploy Preview https://deploy-preview-691--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ore/hrz-89545-picking-lists-loading-indicator
@cypress
Copy link

cypress bot commented Aug 4, 2023

Passing run #9443 ↗︎

0 33 0 0 Flakiness 0

Details:

chore: refactoring sync handler
Project: Composable Storefront Commit: 9f97a3b474
Status: Passed Duration: 03:33 💡
Started: Aug 11, 2023 10:26 AM Ended: Aug 11, 2023 10:30 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Aug 4, 2023

Passing run #2055 ↗︎

0 27 0 0 Flakiness 0

Details:

chore: refactoring sync handler
Project: Fulfillment App Commit: 9f97a3b474
Status: Passed Duration: 05:29 💡
Started: Aug 11, 2023 9:54 AM Ended: Aug 11, 2023 9:59 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@aleespryker aleespryker removed the wip label Aug 10, 2023
@aleespryker aleespryker changed the title chore: picking lists loading indicator chore(picking): implement picking lists component loading indicator Aug 10, 2023
Copy link
Contributor

@supproduction supproduction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the title to feat(picking)...

Copy link
Contributor

@nsilva-spryker nsilva-spryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small comments

@aleespryker aleespryker changed the title chore(picking): implement picking lists component loading indicator feat(picking): implement picking lists component loading indicator Aug 11, 2023
@aleespryker aleespryker merged commit aa9dd36 into development Aug 15, 2023
41 checks passed
@aleespryker aleespryker deleted the chore/hrz-89545-picking-lists-loading-indicator branch August 15, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants