From a428790cc47cc87b0f1f3a03cb7a87d104e047c5 Mon Sep 17 00:00:00 2001 From: aleespryker Date: Tue, 12 Sep 2023 16:25:45 +0200 Subject: [PATCH 01/16] chore: refactor picking component names --- .../src/integration/customer-note.cy.ts | 6 +- .../integration/fully-picking-a-list.cy.ts | 40 +++++ .../fully-picking-a-picklist.cy.ts | 40 ----- .../integration/header-no-customer-note.cy.ts | 19 +++ .../src/integration/lists-search.cy.ts | 51 +++++++ .../src/integration/lists.cy.ts | 22 +++ .../integration/partialy-picking-list.cy.ts | 137 ++++++++++++++++++ .../partialy-picking-picklist.cy.ts | 137 ------------------ .../picking-header-no-customer-note.cy.ts | 19 --- .../integration/picking-lists-search.cy.ts | 57 -------- .../src/integration/picking-lists.cy.ts | 22 --- ...s => start-picking-list-in-progress.cy.ts} | 16 +- ...art-picking-list-with-customer-note.cy.ts} | 18 +-- .../src/integration/user-profile.cy.ts | 32 ++-- .../src/integration/warehouse-selection.cy.ts | 10 +- .../customer-note-modal.fragment.ts | 2 +- .../page_fragments/customer-note.fragment.ts | 5 +- .../page_fragments/discard-modal.fragment.ts | 2 +- .../page_fragments/filters.fragment.ts | 6 +- .../support/page_fragments/header.fragment.ts | 2 +- ...r.fragment.ts => lists-header.fragment.ts} | 2 +- ...ng-lists.fragment.ts => lists.fragment.ts} | 2 +- ....fragment.ts => picker-header.fragment.ts} | 4 +- ...picking.fragment.ts => picker.fragment.ts} | 4 +- .../picking-in-progress-modal.fragment.ts | 2 +- ...roduct.fragment.ts => product.fragment.ts} | 2 +- .../src/support/page_objects/login.page.ts | 2 +- .../{picking.page.ts => picker.page.ts} | 27 ++-- .../customer-note-modal.component.spec.ts | 6 +- .../customer-note-modal.def.ts | 2 +- .../customer-note.component.spec.ts | 10 +- .../customer-note/customer-note.component.ts | 8 +- .../customer-note/customer-note.def.ts | 2 +- .../customer-note/customer-note.styles.ts | 2 +- .../customer-note/stories/demo.stories.ts | 4 +- .../discard-modal.component.spec.ts | 6 +- .../discard-modal/discard-modal.component.ts | 2 +- .../discard-modal/discard-modal.def.ts | 4 +- .../discard-modal/stories/demo.stories.ts | 2 +- .../picking/header/header.component.spec.ts | 2 +- libs/domain/picking/header/header.def.ts | 2 +- .../picking/header/stories/demo.stories.ts | 2 +- libs/domain/picking/list-item/index.ts | 3 + .../list-item.component.spec.ts} | 8 +- .../list-item.component.ts} | 16 +- .../domain/picking/list-item/list-item.def.ts | 8 + .../picking/list-item/list-item.model.ts | 3 + .../picking/list-item/list-item.schema.ts | 8 + .../list-item.styles.ts} | 0 .../stories/demo.stories.ts | 4 +- .../stories/static/variants.stories.ts | 8 +- libs/domain/picking/lists-header/index.ts | 2 + .../lists-header.component.spec.ts} | 8 +- .../lists-header.component.ts} | 8 +- .../picking/lists-header/lists-header.def.ts | 7 + .../lists-header.styles.ts} | 4 +- .../stories/demo.stories.ts | 0 .../stories/static/variants.stories.ts | 0 libs/domain/picking/lists/index.ts | 3 + .../lists.component.spec.ts} | 16 +- .../lists.component.ts} | 12 +- libs/domain/picking/lists/lists.def.ts | 7 + libs/domain/picking/lists/lists.model.ts | 3 + libs/domain/picking/lists/lists.schema.ts | 7 + .../lists.styles.ts} | 0 .../stories/demo.stories.ts | 0 .../stories/static/data.stories.ts | 0 .../stories/static/empty.stories.ts | 0 .../picking/login/login.component.spec.ts | 2 +- libs/domain/picking/login/login.def.ts | 2 +- .../navigate-back.component.spec.ts | 8 +- .../navigate-back/navigate-back.def.ts | 2 +- .../navigate-back/stories/demo.stories.ts | 4 +- libs/domain/picking/picker-header/index.ts | 1 + .../picker-header.component.spec.ts} | 48 +++--- .../picker-header.component.ts} | 24 +-- .../picker-header/picker-header.def.ts | 7 + .../picker-header.styles.ts} | 4 +- .../stories/demo.stories.ts | 0 .../stories/static/variants.stories.ts | 0 libs/domain/picking/picker/index.ts | 2 + .../picker.component.spec.ts} | 16 +- .../picker.component.ts} | 14 +- libs/domain/picking/picker/picker.def.ts | 6 + .../picker.styles.ts} | 0 libs/domain/picking/picking-header/index.ts | 1 - .../picking-header/picking-header.def.ts | 7 - .../picking-in-progress.component.spec.ts | 2 +- .../picking-in-progress.def.ts | 2 +- .../stories/demo.stories.ts | 4 +- .../domain/picking/picking-list-item/index.ts | 3 - .../picking-list-item.def.ts | 13 -- .../picking-list-item.model.ts | 3 - .../picking-list-item.schema.ts | 8 - .../picking/picking-lists-header/index.ts | 2 - .../picking-lists-header.def.ts | 9 -- libs/domain/picking/picking-lists/index.ts | 3 - .../picking-lists/picking-lists.def.ts | 9 -- .../picking-lists/picking-lists.model.ts | 3 - .../picking-lists/picking-lists.schema.ts | 8 - .../picking/picking-product-card/index.ts | 2 - .../picking-product-card.def.ts | 13 -- .../picking-product-card.schema.ts | 8 - libs/domain/picking/picking/index.ts | 2 - libs/domain/picking/picking/picking.def.ts | 6 - libs/domain/picking/product-card/index.ts | 2 + .../product-card.component.spec.ts} | 8 +- .../product-card.component.ts} | 4 +- .../picking/product-card/product-card.def.ts | 9 ++ .../product-card/product-card.schema.ts | 8 + .../product-card.styles.ts} | 0 libs/domain/picking/src/components.ts | 12 +- libs/domain/picking/src/feature.ts | 24 +-- .../picking/src/mixins/picking-list.mixin.ts | 6 +- libs/domain/picking/src/routes.ts | 14 +- .../stories/demo.stories.ts | 4 +- .../warehouse-assignment.component.spec.ts | 8 +- .../warehouse-assignment.component.ts | 2 +- .../warehouse-assignment.def.ts | 2 +- .../warehouse-assignment.styles.ts | 2 +- libs/platform/auth/src/bapi/routes.ts | 2 +- 121 files changed, 618 insertions(+), 614 deletions(-) create mode 100644 apps/fulfillment-e2e/src/integration/fully-picking-a-list.cy.ts delete mode 100644 apps/fulfillment-e2e/src/integration/fully-picking-a-picklist.cy.ts create mode 100644 apps/fulfillment-e2e/src/integration/header-no-customer-note.cy.ts create mode 100644 apps/fulfillment-e2e/src/integration/lists-search.cy.ts create mode 100644 apps/fulfillment-e2e/src/integration/lists.cy.ts create mode 100644 apps/fulfillment-e2e/src/integration/partialy-picking-list.cy.ts delete mode 100644 apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts delete mode 100644 apps/fulfillment-e2e/src/integration/picking-header-no-customer-note.cy.ts delete mode 100644 apps/fulfillment-e2e/src/integration/picking-lists-search.cy.ts delete mode 100644 apps/fulfillment-e2e/src/integration/picking-lists.cy.ts rename apps/fulfillment-e2e/src/integration/{start-picking-picklist-in-progress.cy.ts => start-picking-list-in-progress.cy.ts} (68%) rename apps/fulfillment-e2e/src/integration/{start-picking-picklist-with-customer-note.cy.ts => start-picking-list-with-customer-note.cy.ts} (90%) rename apps/fulfillment-e2e/src/support/page_fragments/{picking-lists-header.fragment.ts => lists-header.fragment.ts} (93%) rename apps/fulfillment-e2e/src/support/page_fragments/{picking-lists.fragment.ts => lists.fragment.ts} (96%) rename apps/fulfillment-e2e/src/support/page_fragments/{picking-header.fragment.ts => picker-header.fragment.ts} (76%) rename apps/fulfillment-e2e/src/support/page_fragments/{picking.fragment.ts => picker.fragment.ts} (93%) rename apps/fulfillment-e2e/src/support/page_fragments/{picking-product.fragment.ts => product.fragment.ts} (95%) rename apps/fulfillment-e2e/src/support/page_objects/{picking.page.ts => picker.page.ts} (54%) create mode 100644 libs/domain/picking/list-item/index.ts rename libs/domain/picking/{picking-list-item/picking-list-item.component.spec.ts => list-item/list-item.component.spec.ts} (96%) rename libs/domain/picking/{picking-list-item/picking-list-item.component.ts => list-item/list-item.component.ts} (87%) create mode 100644 libs/domain/picking/list-item/list-item.def.ts create mode 100644 libs/domain/picking/list-item/list-item.model.ts create mode 100644 libs/domain/picking/list-item/list-item.schema.ts rename libs/domain/picking/{picking-list-item/picking-list-item.styles.ts => list-item/list-item.styles.ts} (100%) rename libs/domain/picking/{picking-list-item => list-item}/stories/demo.stories.ts (92%) rename libs/domain/picking/{picking-list-item => list-item}/stories/static/variants.stories.ts (81%) create mode 100644 libs/domain/picking/lists-header/index.ts rename libs/domain/picking/{picking-lists-header/picking-lists-header.component.spec.ts => lists-header/lists-header.component.spec.ts} (85%) rename libs/domain/picking/{picking-lists-header/picking-lists-header.component.ts => lists-header/lists-header.component.ts} (89%) create mode 100644 libs/domain/picking/lists-header/lists-header.def.ts rename libs/domain/picking/{picking-lists-header/picking-lists-header.styles.ts => lists-header/lists-header.styles.ts} (90%) rename libs/domain/picking/{picking-lists-header => lists-header}/stories/demo.stories.ts (100%) rename libs/domain/picking/{picking-lists-header => lists-header}/stories/static/variants.stories.ts (100%) create mode 100644 libs/domain/picking/lists/index.ts rename libs/domain/picking/{picking-lists/picking-lists.component.spec.ts => lists/lists.component.spec.ts} (95%) rename libs/domain/picking/{picking-lists/picking-lists.component.ts => lists/lists.component.ts} (95%) create mode 100644 libs/domain/picking/lists/lists.def.ts create mode 100644 libs/domain/picking/lists/lists.model.ts create mode 100644 libs/domain/picking/lists/lists.schema.ts rename libs/domain/picking/{picking-lists/picking-lists.styles.ts => lists/lists.styles.ts} (100%) rename libs/domain/picking/{picking-lists => lists}/stories/demo.stories.ts (100%) rename libs/domain/picking/{picking-lists => lists}/stories/static/data.stories.ts (100%) rename libs/domain/picking/{picking-lists => lists}/stories/static/empty.stories.ts (100%) create mode 100644 libs/domain/picking/picker-header/index.ts rename libs/domain/picking/{picking-header/picking-header.component.spec.ts => picker-header/picker-header.component.spec.ts} (79%) rename libs/domain/picking/{picking-header/picking-header.component.ts => picker-header/picker-header.component.ts} (82%) create mode 100644 libs/domain/picking/picker-header/picker-header.def.ts rename libs/domain/picking/{picking-header/picking-header.styles.ts => picker-header/picker-header.styles.ts} (75%) rename libs/domain/picking/{picking-header => picker-header}/stories/demo.stories.ts (100%) rename libs/domain/picking/{picking-header => picker-header}/stories/static/variants.stories.ts (100%) create mode 100644 libs/domain/picking/picker/index.ts rename libs/domain/picking/{picking/picking.component.spec.ts => picker/picker.component.spec.ts} (94%) rename libs/domain/picking/{picking/picking.component.ts => picker/picker.component.ts} (96%) create mode 100644 libs/domain/picking/picker/picker.def.ts rename libs/domain/picking/{picking/picking.styles.ts => picker/picker.styles.ts} (100%) delete mode 100644 libs/domain/picking/picking-header/index.ts delete mode 100644 libs/domain/picking/picking-header/picking-header.def.ts delete mode 100644 libs/domain/picking/picking-list-item/index.ts delete mode 100644 libs/domain/picking/picking-list-item/picking-list-item.def.ts delete mode 100644 libs/domain/picking/picking-list-item/picking-list-item.model.ts delete mode 100644 libs/domain/picking/picking-list-item/picking-list-item.schema.ts delete mode 100644 libs/domain/picking/picking-lists-header/index.ts delete mode 100644 libs/domain/picking/picking-lists-header/picking-lists-header.def.ts delete mode 100644 libs/domain/picking/picking-lists/index.ts delete mode 100644 libs/domain/picking/picking-lists/picking-lists.def.ts delete mode 100644 libs/domain/picking/picking-lists/picking-lists.model.ts delete mode 100644 libs/domain/picking/picking-lists/picking-lists.schema.ts delete mode 100644 libs/domain/picking/picking-product-card/index.ts delete mode 100644 libs/domain/picking/picking-product-card/picking-product-card.def.ts delete mode 100644 libs/domain/picking/picking-product-card/picking-product-card.schema.ts delete mode 100644 libs/domain/picking/picking/index.ts delete mode 100644 libs/domain/picking/picking/picking.def.ts create mode 100644 libs/domain/picking/product-card/index.ts rename libs/domain/picking/{picking-product-card/picking-product-card.component.spec.ts => product-card/product-card.component.spec.ts} (96%) rename libs/domain/picking/{picking-product-card/picking-product-card.component.ts => product-card/product-card.component.ts} (97%) create mode 100644 libs/domain/picking/product-card/product-card.def.ts create mode 100644 libs/domain/picking/product-card/product-card.schema.ts rename libs/domain/picking/{picking-product-card/picking-product-card.styles.ts => product-card/product-card.styles.ts} (100%) diff --git a/apps/fulfillment-e2e/src/integration/customer-note.cy.ts b/apps/fulfillment-e2e/src/integration/customer-note.cy.ts index ef0de24ef8..d33d7c6d34 100644 --- a/apps/fulfillment-e2e/src/integration/customer-note.cy.ts +++ b/apps/fulfillment-e2e/src/integration/customer-note.cy.ts @@ -1,7 +1,7 @@ import { CustomerNoteModalFragment } from '../support/page_fragments/customer-note-modal.fragment'; -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; -const pickingListsFragment = new PickingListsFragment(); +const listsFragment = new ListsFragment(); const customerNoteFragment = new CustomerNoteModalFragment(); describe('Customer note suite', () => { @@ -12,7 +12,7 @@ describe('Customer note suite', () => { it('should show and hide the customer note modal', () => { // open - pickingListsFragment.getCustomerNoteButtons().click(); + listsFragment.getCustomerNoteButtons().click(); customerNoteFragment.getModal().should('be.visible'); // close diff --git a/apps/fulfillment-e2e/src/integration/fully-picking-a-list.cy.ts b/apps/fulfillment-e2e/src/integration/fully-picking-a-list.cy.ts new file mode 100644 index 0000000000..2b1051ef58 --- /dev/null +++ b/apps/fulfillment-e2e/src/integration/fully-picking-a-list.cy.ts @@ -0,0 +1,40 @@ +import { PickerFragment } from '../support/page_fragments/picker.fragment'; +import { ProductFragment } from '../support/page_fragments/product.fragment'; +import { PickerPage } from '../support/page_objects/picker.page'; + +describe('Fully pick a picking list', () => { + const pickingListId = '37cb241e-f18a-5768-985c-a2d7aff4875e'; + + const pickerPage = new PickerPage(pickingListId); + + const pickerFragment = new PickerFragment(); + const productFragment = new ProductFragment(); + + beforeEach(() => { + cy.clearIndexedDB(); + cy.login(); + pickerPage.visit(); + pickerPage.productFragment.getProducts().should('be.visible'); + + pickerFragment.getProducts().each((product) => { + cy.wrap(product).within(() => { + productFragment.pickAllProductItems(); + productFragment.getSubmitButton().click(); + }); + }); + }); + + it('must have all products on picked tab after done all of them', () => { + pickerFragment.getProducts().then((products) => { + pickerFragment + .getTabCounter(pickerPage.getPickedTab()) + .should('contain.text', products.length); + }); + + pickerFragment.getPickingCompleteImage().should('be.visible'); + pickerFragment.getFinishPickingButton().should('be.visible'); + + pickerFragment.getFinishPickingButton().eq(0).click(); + cy.location('pathname').should('be.eq', `/`); + }); +}); diff --git a/apps/fulfillment-e2e/src/integration/fully-picking-a-picklist.cy.ts b/apps/fulfillment-e2e/src/integration/fully-picking-a-picklist.cy.ts deleted file mode 100644 index a63e1701e9..0000000000 --- a/apps/fulfillment-e2e/src/integration/fully-picking-a-picklist.cy.ts +++ /dev/null @@ -1,40 +0,0 @@ -import { PickingProductFragment } from '../support/page_fragments/picking-product.fragment'; -import { PickingFragment } from '../support/page_fragments/picking.fragment'; -import { PickingPage } from '../support/page_objects/picking.page'; - -describe('Fully pick a picking list', () => { - const pickingListId = '37cb241e-f18a-5768-985c-a2d7aff4875e'; - - const pickingPage = new PickingPage(pickingListId); - - const pickingFragment = new PickingFragment(); - const pickingProductFragment = new PickingProductFragment(); - - beforeEach(() => { - cy.clearIndexedDB(); - cy.login(); - pickingPage.visit(); - pickingPage.pickingProductFragment.getProducts().should('be.visible'); - - pickingFragment.getProducts().each((product) => { - cy.wrap(product).within(() => { - pickingProductFragment.pickAllProductItems(); - pickingProductFragment.getSubmitButton().click(); - }); - }); - }); - - it('must have all products on picked tab after done all of them', () => { - pickingFragment.getProducts().then((products) => { - pickingFragment - .getTabCounter(pickingPage.getPickedTab()) - .should('contain.text', products.length); - }); - - pickingFragment.getPickingCompleteImage().should('be.visible'); - pickingFragment.getFinishPickingButton().should('be.visible'); - - pickingFragment.getFinishPickingButton().eq(0).click(); - cy.location('pathname').should('be.eq', `/`); - }); -}); diff --git a/apps/fulfillment-e2e/src/integration/header-no-customer-note.cy.ts b/apps/fulfillment-e2e/src/integration/header-no-customer-note.cy.ts new file mode 100644 index 0000000000..45514ee563 --- /dev/null +++ b/apps/fulfillment-e2e/src/integration/header-no-customer-note.cy.ts @@ -0,0 +1,19 @@ +import { PickerHeaderFragment } from '../support/page_fragments/picker-header.fragment'; +import { PickerPage } from '../support/page_objects/picker.page'; + +const pickingListId = 'd5bf20f1-7f36-568d-85b5-e4502acbcc82'; + +const pickerPage = new PickerPage(pickingListId); +const pickerHeaderFragment = new PickerHeaderFragment(); + +describe('picking header with no customer note', () => { + beforeEach(() => { + cy.clearIndexedDB(); + cy.login(); + pickerPage.visit(); + }); + + it('should not display customer note icon', () => { + pickerHeaderFragment.getCustomerNoteIcon().should('not.exist'); + }); +}); diff --git a/apps/fulfillment-e2e/src/integration/lists-search.cy.ts b/apps/fulfillment-e2e/src/integration/lists-search.cy.ts new file mode 100644 index 0000000000..61299c144f --- /dev/null +++ b/apps/fulfillment-e2e/src/integration/lists-search.cy.ts @@ -0,0 +1,51 @@ +import { ListsHeaderFragment } from '../support/page_fragments/lists-header.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; +import { UserProfileFragment } from '../support/page_fragments/user-profile-modal.fragment'; + +const listsFragment = new ListsFragment(); +const headerFragment = new ListsHeaderFragment(); +const userProfileFragment = new UserProfileFragment(); + +describe('Picking Lists Search', () => { + beforeEach(() => { + cy.clearIndexedDB(); + cy.login(); + + headerFragment.getSearch().click(); + }); + + it('should show correct picking items after search', () => { + listsFragment.getWrapper().should('be.visible'); + headerFragment + .getSearchInput() + .should('be.visible') + .should('have.attr', 'placeholder'); + + listsFragment.getNoItemsFallbackHeading().should('be.visible'); + listsFragment.getStartSearchingFallbackImage().should('be.visible'); + + headerFragment.getSearchInput().type('D', { force: true }); + listsFragment.getNoItemsFallbackHeading().should('be.visible'); + listsFragment.getStartSearchingFallbackImage().should('be.visible'); + + headerFragment.getSearchInput().type('E', { force: true }); + listsFragment.getPickingListsItems().should('have.length.at.least', 1); + + headerFragment.getSearchClearButton().click(); + listsFragment.getNoItemsFallbackHeading().should('be.visible'); + listsFragment.getStartSearchingFallbackImage().should('be.visible'); + + headerFragment.getSearchInput().type('something', { force: true }); + listsFragment.getNoItemsFallbackHeading().should('be.visible'); + listsFragment.getNoPickingResultsFallbackImage().should('be.visible'); + + headerFragment.getSearchBackButton().click(); + listsFragment.getNoItemsFallback().should('not.exist'); + headerFragment.getTitle().should('be.visible'); + listsFragment.getPickingListsItems().should('have.length.at.least', 1); + + headerFragment.getUserIcon().should('be.visible').click(); + + userProfileFragment.getWrapper().should('be.visible'); + }); +}); diff --git a/apps/fulfillment-e2e/src/integration/lists.cy.ts b/apps/fulfillment-e2e/src/integration/lists.cy.ts new file mode 100644 index 0000000000..1225836235 --- /dev/null +++ b/apps/fulfillment-e2e/src/integration/lists.cy.ts @@ -0,0 +1,22 @@ +import { ListsFragment } from '../support/page_fragments/lists.fragment'; +import { ListsHeaderFragment } from '../support/page_fragments/lists-header.fragment'; + +const listsFragment = new ListsFragment(); +const headerFragment = new ListsHeaderFragment(); + +describe('Picking Lists', () => { + beforeEach(() => { + cy.clearIndexedDB(); + cy.login(); + }); + + it('should display picking lists', () => { + headerFragment.getSearchIcon().should('be.visible'); + headerFragment.getUserIcon().should('be.visible'); + headerFragment.getHeadline().should('contain.text', 'Pick lists'); + listsFragment.getSortButton().should('be.visible'); + + listsFragment.getWrapper().should('be.visible'); + listsFragment.getPickingListsItems().should('be.visible'); + }); +}); diff --git a/apps/fulfillment-e2e/src/integration/partialy-picking-list.cy.ts b/apps/fulfillment-e2e/src/integration/partialy-picking-list.cy.ts new file mode 100644 index 0000000000..dd956f5508 --- /dev/null +++ b/apps/fulfillment-e2e/src/integration/partialy-picking-list.cy.ts @@ -0,0 +1,137 @@ +import { CustomerNoteModalFragment } from '../support/page_fragments/customer-note-modal.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; +import { PickerHeaderFragment } from '../support/page_fragments/picker-header.fragment'; +import { PickerFragment } from '../support/page_fragments/picker.fragment'; +import { ProductFragment } from '../support/page_fragments/product.fragment'; +import { UserProfileFragment } from '../support/page_fragments/user-profile-modal.fragment'; +import { PickerPage } from '../support/page_objects/picker.page'; + +const pickingListId = '37cb241e-f18a-5768-985c-a2d7aff4875e'; + +const pickerPage = new PickerPage(pickingListId); + +const listsFragment = new ListsFragment(); +const productFragment = new ProductFragment(); +const pickerFragment = new PickerFragment(); +const pickerHeaderFragment = new PickerHeaderFragment(); +const customerNoteModalFragment = new CustomerNoteModalFragment(); +const userProfileFragment = new UserProfileFragment(); + +describe('Partial picking a picklist', () => { + beforeEach(() => { + cy.clearIndexedDB(); + cy.login(); + pickerPage.visit(); + pickerPage.productFragment.getProducts().should('be.visible'); + }); + + it('should check partial picking', () => { + // See picking lists id + pickerHeaderFragment + .getPickingListsTitle() + .should('be.visible') + .and('contain', 'DE--19'); + + // See customer note + pickerHeaderFragment.getCustomerNoteIcon().should('be.visible').click(); + customerNoteModalFragment.getModal().should('be.visible'); + customerNoteModalFragment.getCloseButton().click(); + + // See user profile modal + pickerHeaderFragment.getUserIcon().should('be.visible').click(); + userProfileFragment.getWrapper().should('be.visible'); + userProfileFragment.getCloseButton().should('be.visible').click(); + userProfileFragment.getWrapper().should('not.be.visible'); + + // Setting initial number of products in each tab + pickerPage + .getNotPickedProductsNumber() + .as('initialNotPickedProductsNumber'); + pickerPage.getPickedProductsNumber().as('initialPickedProductsNumber'); + pickerPage.getNotFoundProductsNumber().as('initialNotFoundProductsNumber'); + + // Check fallbacks on "Picked" and "Not Found" tabs + pickerPage.insideTabContent(pickerPage.getPickedTab(), () => { + pickerFragment.getNoItemsTitle().should('be.visible'); + pickerFragment.getNoItemsImage().should('be.visible'); + }); + + pickerPage.insideTabContent(pickerPage.getNotFoundTab(), () => { + pickerFragment.getNoItemsTitle().should('be.visible'); + pickerFragment.getNoItemsImage().should('be.visible'); + }); + + // For the first item, select only part of the quantity. + pickerPage.insideTabContent(pickerPage.getNotPickedTab(), () => { + pickerPage.pickProduct(productFragment.getProducts().eq(0), 1); + }); + + // Verify that the Partial Picking Modal is opened. + pickerFragment.getPartialPickingDialog().should('be.visible'); + + // Confirm partial picking + pickerFragment.getPartialPickingConfirmButton().click(); + + // Dialog should be closed + pickerFragment.getPartialPickingDialog().should('not.be.visible'); + + // Verify that the picking item is moved to the "Picked" tab with the entered quantity, and the "Not found" tab with the not entered quantity. + // Not Picked tab list should have x-1 products + cy.get('@initialNotPickedProductsNumber').then((initCount) => { + pickerPage + .getNotPickedProductsNumber() + .should('be.eq', Number(initCount) - 1); + }); + + // Picked tab list should have x+1 products + cy.get('@initialPickedProductsNumber').then((initCount) => { + pickerPage + .getPickedProductsNumber() + .should('be.eq', Number(initCount) + 1); + }); + + // Not Found tab list should have x+1 products + cy.get('@initialNotFoundProductsNumber').then((initCount) => { + pickerPage + .getNotFoundProductsNumber() + .should('be.eq', Number(initCount) + 1); + }); + + // Pick the rest of the products + pickerPage.insideTabContent(pickerPage.getNotPickedTab(), () => { + productFragment.getProducts().each((product) => { + cy.wrap(product).within(() => { + productFragment.pickAllProductItems(); + productFragment.getSubmitButton().click(); + }); + }); + + // Verify that the congratulation text and illustration are shown + pickerFragment.getPickingCompleteImage().should('be.visible'); + pickerFragment.getPickingCompleteTitle().should('be.visible'); + pickerFragment.getPickingCompleteText().should('be.visible'); + }); + + // Verify that the “Finish picking” button appears + const tabs = [ + pickerPage.getNotPickedTab(), + pickerPage.getPickedTab(), + pickerPage.getNotFoundTab(), + ]; + + tabs.forEach((tab) => { + pickerPage.insideTabContent(tab, () => { + pickerFragment.getFinishPickingButton().should('be.visible'); + }); + }); + + // Tap the “Finish picking” button + pickerPage.insideTabContent(pickerPage.getNotPickedTab(), () => { + pickerFragment.getFinishPickingButton().click(); + }); + + // Verify that the Picking lists page is shown + cy.location('pathname').should('be.eq', `/`); + listsFragment.getWrapper().should('be.visible'); + }); +}); diff --git a/apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts b/apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts deleted file mode 100644 index 2f54a3d76b..0000000000 --- a/apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts +++ /dev/null @@ -1,137 +0,0 @@ -import { CustomerNoteModalFragment } from '../support/page_fragments/customer-note-modal.fragment'; -import { PickingHeaderFragment } from '../support/page_fragments/picking-header.fragment'; -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; -import { PickingProductFragment } from '../support/page_fragments/picking-product.fragment'; -import { PickingFragment } from '../support/page_fragments/picking.fragment'; -import { PickingPage } from '../support/page_objects/picking.page'; -import { UserProfileFragment } from '../support/page_fragments/user-profile-modal.fragment'; - -const pickingListId = '37cb241e-f18a-5768-985c-a2d7aff4875e'; - -const pickingPage = new PickingPage(pickingListId); - -const pickingListsFragment = new PickingListsFragment(); -const pickingProductFragment = new PickingProductFragment(); -const pickingFragment = new PickingFragment(); -const pickingHeaderFragment = new PickingHeaderFragment(); -const customerNoteModalFragment = new CustomerNoteModalFragment(); -const userProfileFragment = new UserProfileFragment(); - -describe('Partial picking a picklist', () => { - beforeEach(() => { - cy.clearIndexedDB(); - cy.login(); - pickingPage.visit(); - pickingPage.pickingProductFragment.getProducts().should('be.visible'); - }); - - it('should check partial picking', () => { - // See picking lists id - pickingHeaderFragment - .getPickingListsTitle() - .should('be.visible') - .and('contain', 'DE--19'); - - // See customer note - pickingHeaderFragment.getCustomerNoteIcon().should('be.visible').click(); - customerNoteModalFragment.getModal().should('be.visible'); - customerNoteModalFragment.getCloseButton().click(); - - // See user profile modal - pickingHeaderFragment.getUserIcon().should('be.visible').click(); - userProfileFragment.getWrapper().should('be.visible'); - userProfileFragment.getCloseButton().should('be.visible').click(); - userProfileFragment.getWrapper().should('not.be.visible'); - - // Setting initial number of products in each tab - pickingPage - .getNotPickedProductsNumber() - .as('initialNotPickedProductsNumber'); - pickingPage.getPickedProductsNumber().as('initialPickedProductsNumber'); - pickingPage.getNotFoundProductsNumber().as('initialNotFoundProductsNumber'); - - // Check fallbacks on "Picked" and "Not Found" tabs - pickingPage.insideTabContent(pickingPage.getPickedTab(), () => { - pickingFragment.getNoItemsTitle().should('be.visible'); - pickingFragment.getNoItemsImage().should('be.visible'); - }); - - pickingPage.insideTabContent(pickingPage.getNotFoundTab(), () => { - pickingFragment.getNoItemsTitle().should('be.visible'); - pickingFragment.getNoItemsImage().should('be.visible'); - }); - - // For the first item, select only part of the quantity. - pickingPage.insideTabContent(pickingPage.getNotPickedTab(), () => { - pickingPage.pickProduct(pickingProductFragment.getProducts().eq(0), 1); - }); - - // Verify that the Partial Picking Modal is opened. - pickingFragment.getPartialPickingDialog().should('be.visible'); - - // Confirm partial picking - pickingFragment.getPartialPickingConfirmButton().click(); - - // Dialog should be closed - pickingFragment.getPartialPickingDialog().should('not.be.visible'); - - // Verify that the picking item is moved to the "Picked" tab with the entered quantity, and the "Not found" tab with the not entered quantity. - // Not Picked tab list should have x-1 products - cy.get('@initialNotPickedProductsNumber').then((initCount) => { - pickingPage - .getNotPickedProductsNumber() - .should('be.eq', Number(initCount) - 1); - }); - - // Picked tab list should have x+1 products - cy.get('@initialPickedProductsNumber').then((initCount) => { - pickingPage - .getPickedProductsNumber() - .should('be.eq', Number(initCount) + 1); - }); - - // Not Found tab list should have x+1 products - cy.get('@initialNotFoundProductsNumber').then((initCount) => { - pickingPage - .getNotFoundProductsNumber() - .should('be.eq', Number(initCount) + 1); - }); - - // Pick the rest of the products - pickingPage.insideTabContent(pickingPage.getNotPickedTab(), () => { - pickingProductFragment.getProducts().each((product) => { - cy.wrap(product).within(() => { - pickingProductFragment.pickAllProductItems(); - pickingProductFragment.getSubmitButton().click(); - }); - }); - - // Verify that the congratulation text and illustration are shown - pickingFragment.getPickingCompleteImage().should('be.visible'); - pickingFragment.getPickingCompleteTitle().should('be.visible'); - pickingFragment.getPickingCompleteText().should('be.visible'); - }); - - // Verify that the “Finish picking” button appears - const tabs = [ - pickingPage.getNotPickedTab(), - pickingPage.getPickedTab(), - pickingPage.getNotFoundTab(), - ]; - - tabs.forEach((tab) => { - pickingPage.insideTabContent(tab, () => { - pickingFragment.getFinishPickingButton().should('be.visible'); - }); - }); - - // Tap the “Finish picking” button - pickingPage.insideTabContent(pickingPage.getNotPickedTab(), () => { - pickingFragment.getFinishPickingButton().click(); - }); - - // Verify that the Picking lists page is shown - cy.location('pathname').should('be.eq', `/`); - pickingListsFragment.getWrapper().should('be.visible'); - }); -}); diff --git a/apps/fulfillment-e2e/src/integration/picking-header-no-customer-note.cy.ts b/apps/fulfillment-e2e/src/integration/picking-header-no-customer-note.cy.ts deleted file mode 100644 index f253af4c05..0000000000 --- a/apps/fulfillment-e2e/src/integration/picking-header-no-customer-note.cy.ts +++ /dev/null @@ -1,19 +0,0 @@ -import { PickingPage } from '../support/page_objects/picking.page'; -import { PickingHeaderFragment } from '../support/page_fragments/picking-header.fragment'; - -const pickingListId = 'd5bf20f1-7f36-568d-85b5-e4502acbcc82'; - -const pickingPage = new PickingPage(pickingListId); -const pickingHeaderFragment = new PickingHeaderFragment(); - -describe('picking header with no customer note', () => { - beforeEach(() => { - cy.clearIndexedDB(); - cy.login(); - pickingPage.visit(); - }); - - it('should not display customer note icon', () => { - pickingHeaderFragment.getCustomerNoteIcon().should('not.exist'); - }); -}); diff --git a/apps/fulfillment-e2e/src/integration/picking-lists-search.cy.ts b/apps/fulfillment-e2e/src/integration/picking-lists-search.cy.ts deleted file mode 100644 index aeccc09d1f..0000000000 --- a/apps/fulfillment-e2e/src/integration/picking-lists-search.cy.ts +++ /dev/null @@ -1,57 +0,0 @@ -import { PickingListsHeaderFragment } from '../support/page_fragments/picking-lists-header.fragment'; -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; -import { UserProfileFragment } from '../support/page_fragments/user-profile-modal.fragment'; - -const pickingListsFragment = new PickingListsFragment(); -const headerFragment = new PickingListsHeaderFragment(); -const userProfileFragment = new UserProfileFragment(); - -describe('Picking Lists Search', () => { - beforeEach(() => { - cy.clearIndexedDB(); - cy.login(); - - headerFragment.getSearch().click(); - }); - - it('should show correct picking items after search', () => { - pickingListsFragment.getWrapper().should('be.visible'); - headerFragment - .getSearchInput() - .should('be.visible') - .should('have.attr', 'placeholder'); - - pickingListsFragment.getNoItemsFallbackHeading().should('be.visible'); - pickingListsFragment.getStartSearchingFallbackImage().should('be.visible'); - - headerFragment.getSearchInput().type('D', { force: true }); - pickingListsFragment.getNoItemsFallbackHeading().should('be.visible'); - pickingListsFragment.getStartSearchingFallbackImage().should('be.visible'); - - headerFragment.getSearchInput().type('E', { force: true }); - pickingListsFragment - .getPickingListsItems() - .should('have.length.at.least', 1); - - headerFragment.getSearchClearButton().click(); - pickingListsFragment.getNoItemsFallbackHeading().should('be.visible'); - pickingListsFragment.getStartSearchingFallbackImage().should('be.visible'); - - headerFragment.getSearchInput().type('something', { force: true }); - pickingListsFragment.getNoItemsFallbackHeading().should('be.visible'); - pickingListsFragment - .getNoPickingResultsFallbackImage() - .should('be.visible'); - - headerFragment.getSearchBackButton().click(); - pickingListsFragment.getNoItemsFallback().should('not.exist'); - headerFragment.getTitle().should('be.visible'); - pickingListsFragment - .getPickingListsItems() - .should('have.length.at.least', 1); - - headerFragment.getUserIcon().should('be.visible').click(); - - userProfileFragment.getWrapper().should('be.visible'); - }); -}); diff --git a/apps/fulfillment-e2e/src/integration/picking-lists.cy.ts b/apps/fulfillment-e2e/src/integration/picking-lists.cy.ts deleted file mode 100644 index 4526b97d82..0000000000 --- a/apps/fulfillment-e2e/src/integration/picking-lists.cy.ts +++ /dev/null @@ -1,22 +0,0 @@ -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; -import { PickingListsHeaderFragment } from '../support/page_fragments/picking-lists-header.fragment'; - -const pickingListsFragment = new PickingListsFragment(); -const headerFragment = new PickingListsHeaderFragment(); - -describe('Picking Lists', () => { - beforeEach(() => { - cy.clearIndexedDB(); - cy.login(); - }); - - it('should display picking lists', () => { - headerFragment.getSearchIcon().should('be.visible'); - headerFragment.getUserIcon().should('be.visible'); - headerFragment.getHeadline().should('contain.text', 'Pick lists'); - pickingListsFragment.getSortButton().should('be.visible'); - - pickingListsFragment.getWrapper().should('be.visible'); - pickingListsFragment.getPickingListsItems().should('be.visible'); - }); -}); diff --git a/apps/fulfillment-e2e/src/integration/start-picking-picklist-in-progress.cy.ts b/apps/fulfillment-e2e/src/integration/start-picking-list-in-progress.cy.ts similarity index 68% rename from apps/fulfillment-e2e/src/integration/start-picking-picklist-in-progress.cy.ts rename to apps/fulfillment-e2e/src/integration/start-picking-list-in-progress.cy.ts index 8f79b91c01..da84df1951 100644 --- a/apps/fulfillment-e2e/src/integration/start-picking-picklist-in-progress.cy.ts +++ b/apps/fulfillment-e2e/src/integration/start-picking-list-in-progress.cy.ts @@ -1,7 +1,7 @@ import { CustomerNoteFragment } from '../support/page_fragments/customer-note.fragment'; -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; -const pickingListsFragment = new PickingListsFragment(); +const listsFragment = new ListsFragment(); const customerNoteFragment = new CustomerNoteFragment(); describe('pick a picking list in progress', () => { @@ -11,7 +11,7 @@ describe('pick a picking list in progress', () => { cy.mockPickingInProgress(); // open first picking which is mocked as In Progress - pickingListsFragment.getStartPickingButtons().eq(0).click(); + listsFragment.getStartPickingButtons().eq(0).click(); // safe the url cy.location('pathname').as('openedPickingUrl'); // wait for event handlers initialization @@ -28,21 +28,19 @@ describe('pick a picking list in progress', () => { cy.location('pathname').should('be.equal', url); }); - pickingListsFragment.pickingInProgressModal.getModal().should('be.visible'); + listsFragment.pickingInProgressModal.getModal().should('be.visible'); }); describe('and picking in progress modal is closed', () => { beforeEach(() => { - pickingListsFragment.pickingInProgressModal.getCloseButton().click(); + listsFragment.pickingInProgressModal.getCloseButton().click(); }); it('should hide modal and navigate back to the picking list', () => { - pickingListsFragment.pickingInProgressModal - .getModal() - .should('not.be.visible'); + listsFragment.pickingInProgressModal.getModal().should('not.be.visible'); cy.location('pathname').should('be.equal', '/'); - pickingListsFragment.getPickingListsItems().should('be.visible'); + listsFragment.getPickingListsItems().should('be.visible'); }); }); }); diff --git a/apps/fulfillment-e2e/src/integration/start-picking-picklist-with-customer-note.cy.ts b/apps/fulfillment-e2e/src/integration/start-picking-list-with-customer-note.cy.ts similarity index 90% rename from apps/fulfillment-e2e/src/integration/start-picking-picklist-with-customer-note.cy.ts rename to apps/fulfillment-e2e/src/integration/start-picking-list-with-customer-note.cy.ts index 68391b69b4..ea8b1022dd 100644 --- a/apps/fulfillment-e2e/src/integration/start-picking-picklist-with-customer-note.cy.ts +++ b/apps/fulfillment-e2e/src/integration/start-picking-list-with-customer-note.cy.ts @@ -1,12 +1,12 @@ import { CustomerNoteFragment } from '../support/page_fragments/customer-note.fragment'; import { DiscardModalFragment } from '../support/page_fragments/discard-modal.fragment'; -import { PickingHeaderFragment } from '../support/page_fragments/picking-header.fragment'; -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; -import { PickingFragment } from '../support/page_fragments/picking.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; +import { PickerHeaderFragment } from '../support/page_fragments/picker-header.fragment'; +import { PickerFragment } from '../support/page_fragments/picker.fragment'; -const pickingListsFragment = new PickingListsFragment(); +const listsFragment = new ListsFragment(); const customerNoteFragment = new CustomerNoteFragment(); -const pickingHeaderFragment = new PickingHeaderFragment(); +const pickerHeaderFragment = new PickerHeaderFragment(); const discardModalFragment = new DiscardModalFragment(); describe('Start picking a picklist with customer note', () => { @@ -14,7 +14,7 @@ describe('Start picking a picklist with customer note', () => { cy.clearIndexedDB(); cy.login(); - pickingListsFragment.getStartPickingButtons().eq(0).click(); + listsFragment.getStartPickingButtons().eq(0).click(); }); it('check Customer Note page', () => { @@ -45,7 +45,7 @@ describe('Start picking a picklist with customer note', () => { }); describe('and “Proceed to picking” button is clicked', () => { - const pickingFragment = new PickingFragment(); + const pickingFragment = new PickerFragment(); beforeEach(() => { customerNoteFragment.getProceedToPickingButton().should('be.visible'); // eslint-disable-next-line cypress/no-unnecessary-waiting @@ -67,7 +67,7 @@ describe('Start picking a picklist with customer note', () => { // Due to a cypress bug https://github.com/cypress-io/cypress/issues/26905, // the only meaningful way to check visibility is in the slots. discardModalFragment.getContent().should('not.be.visible'); - pickingHeaderFragment.getBackButton().click(); + pickerHeaderFragment.getBackButton().click(); discardModalFragment.getContent().should('be.visible'); // should hide discard modal @@ -76,7 +76,7 @@ describe('Start picking a picklist with customer note', () => { cy.location('pathname').should('to.match', /^\/picking-list/); // should navigate back - pickingHeaderFragment.getBackButton().click(); + pickerHeaderFragment.getBackButton().click(); discardModalFragment.getDiscardButton().click(); cy.location('pathname').should('to.match', /^\/customer-note-info/); diff --git a/apps/fulfillment-e2e/src/integration/user-profile.cy.ts b/apps/fulfillment-e2e/src/integration/user-profile.cy.ts index 98a1d31702..4a769d4ca1 100644 --- a/apps/fulfillment-e2e/src/integration/user-profile.cy.ts +++ b/apps/fulfillment-e2e/src/integration/user-profile.cy.ts @@ -1,21 +1,21 @@ -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; +import { ListsHeaderFragment } from '../support/page_fragments/lists-header.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; +import { PickerHeaderFragment } from '../support/page_fragments/picker-header.fragment'; import { UserProfileFragment } from '../support/page_fragments/user-profile-modal.fragment'; import { LoginPage } from '../support/page_objects/login.page'; -import { PickingHeaderFragment } from '../support/page_fragments/picking-header.fragment'; -import { PickingListsHeaderFragment } from '../support/page_fragments/picking-lists-header.fragment'; -const pickingListsFragment = new PickingListsFragment(); +const listsFragment = new ListsFragment(); const userProfileFragment = new UserProfileFragment(); const loginPage = new LoginPage(); -const pickingHeaderFragment = new PickingHeaderFragment(); -const pickingListsHeaderFragment = new PickingListsHeaderFragment(); +const pickerHeaderFragment = new PickerHeaderFragment(); +const listsHeaderFragment = new ListsHeaderFragment(); describe('When a user opens the user profile modal', () => { beforeEach(() => { cy.clearIndexedDB(); cy.login(); - pickingListsHeaderFragment.getUserIcon().click(); + listsHeaderFragment.getUserIcon().click(); }); it('should display modal', () => { @@ -40,7 +40,7 @@ describe('When a user opens the user profile modal', () => { cy.mockSyncPending(); cy.visit('/'); - pickingListsHeaderFragment.getUserIcon().click(); + listsHeaderFragment.getUserIcon().click(); }); it('should show message and disable log out button', () => { @@ -58,9 +58,9 @@ describe('When a user opens the user profile modal', () => { describe('and picking is in progress', () => { beforeEach(() => { userProfileFragment.getCloseButton().click(); - pickingListsFragment.getStartPickingButtons().eq(1).click(); + listsFragment.getStartPickingButtons().eq(1).click(); - pickingHeaderFragment.getUserIcon().click(); + pickerHeaderFragment.getUserIcon().click(); }); it('should show message and disable log out button', () => { @@ -80,9 +80,9 @@ describe('When a user opens the user profile modal', () => { beforeEach(() => { cy.mockSyncPending(); cy.visit('/'); - pickingListsFragment.getStartPickingButtons().eq(1).click(); + listsFragment.getStartPickingButtons().eq(1).click(); - pickingHeaderFragment.getUserIcon().click(); + pickerHeaderFragment.getUserIcon().click(); }); it('should show picking in progress message and disable log out button', () => { @@ -103,15 +103,15 @@ describe('When a user opens the user profile modal', () => { cy.intercept('PATCH', '**/picking-lists/**').as('startPicking'); userProfileFragment.getCloseButton().click(); - pickingListsFragment.getStartPickingButtons().eq(1).click(); + listsFragment.getStartPickingButtons().eq(1).click(); cy.wait('@startPicking', { timeout: 30000 }); cy.visit('/'); - pickingListsFragment.getPickingListsItems().should('have.length', 1); + listsFragment.getPickingListsItems().should('have.length', 1); - pickingListsHeaderFragment.getUserIcon().click(); + listsHeaderFragment.getUserIcon().click(); userProfileFragment.getWrapper().should('be.visible'); @@ -122,7 +122,7 @@ describe('When a user opens the user profile modal', () => { userProfileFragment.getWrapper().should('not.be.visible'); cy.location('pathname').should('not.to.match', /^\/login/); loginPage.getWrapper().should('not.exist'); - pickingListsFragment.getPickingListsItems().should('have.length', 2); + listsFragment.getPickingListsItems().should('have.length', 2); }); }); }); diff --git a/apps/fulfillment-e2e/src/integration/warehouse-selection.cy.ts b/apps/fulfillment-e2e/src/integration/warehouse-selection.cy.ts index 2b139b7af4..2e371db1c7 100644 --- a/apps/fulfillment-e2e/src/integration/warehouse-selection.cy.ts +++ b/apps/fulfillment-e2e/src/integration/warehouse-selection.cy.ts @@ -1,14 +1,14 @@ -import { WarehouseSelectionPage } from '../support/page_objects/warehouse-selection.page'; -import { WarehouseSelectionListFragment } from '../support/page_fragments/warehouse-selection-list.fragment'; import { HeaderFragment } from '../support/page_fragments/header.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; import { UserProfileFragment } from '../support/page_fragments/user-profile-modal.fragment'; -import { PickingListsFragment } from '../support/page_fragments/picking-lists.fragment'; +import { WarehouseSelectionListFragment } from '../support/page_fragments/warehouse-selection-list.fragment'; +import { WarehouseSelectionPage } from '../support/page_objects/warehouse-selection.page'; const warehouseSelectionPage = new WarehouseSelectionPage(); const warehouseSelectionListFragment = new WarehouseSelectionListFragment(); const headerFragment = new HeaderFragment(); const userProfileFragment = new UserProfileFragment(); -const pickingListsFragment = new PickingListsFragment(); +const listsFragment = new ListsFragment(); describe('Warehouse selection', () => { beforeEach(() => { @@ -40,6 +40,6 @@ describe('Warehouse selection', () => { warehouseSelectionListFragment.getWarehouseSelectionButtons().eq(0).click(); cy.location('pathname').should('be.equal', '/'); - pickingListsFragment.getWrapper().should('be.visible'); + listsFragment.getWrapper().should('be.visible'); }); }); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/customer-note-modal.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/customer-note-modal.fragment.ts index b17d1f5581..d9f69f9fbe 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/customer-note-modal.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/customer-note-modal.fragment.ts @@ -1,5 +1,5 @@ export class CustomerNoteModalFragment { - getWrapper = () => cy.get('oryx-customer-note-modal'); + getWrapper = () => cy.get('oryx-picking-customer-note-modal'); getModal = () => this.getWrapper().find('dialog'); getCloseButton = () => this.getWrapper().find('oryx-button').eq(0); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts index 4cccf81045..510b85dd19 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts @@ -1,10 +1,11 @@ import { PickingInProgressModalFragment } from './picking-in-progress-modal.fragment'; export class CustomerNoteFragment { - getWrapper = () => cy.get('oryx-customer-note'); + getWrapper = () => cy.get('oryx-picking-customer-note'); getHeadline = () => this.getWrapper().find('oryx-heading'); getIllustration = () => this.getWrapper().find('oryx-image'); - getNavigateBackButton = () => this.getWrapper().find('oryx-navigate-back'); + getNavigateBackButton = () => + this.getWrapper().find('oryx-picking-navigate-back'); getNote = () => this.getWrapper().find('p'); getProceedToPickingButton = () => this.getWrapper().find('oryx-button').eq(0); pickingInProgressModal = new PickingInProgressModalFragment(); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/discard-modal.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/discard-modal.fragment.ts index 719d51b921..f16ec5fc01 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/discard-modal.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/discard-modal.fragment.ts @@ -1,5 +1,5 @@ export class DiscardModalFragment { - getWrapper = () => cy.get('oryx-discard-picking'); + getWrapper = () => cy.get('oryx-picking-discard-modal'); getContent = () => this.getWrapper().shadow().find('slot[part="body"]'); getCancelButton = () => this.getWrapper().find('oryx-button').eq(0); getDiscardButton = () => this.getWrapper().find('oryx-button').eq(1); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/filters.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/filters.fragment.ts index f00d78aa7b..59fd431ac1 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/filters.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/filters.fragment.ts @@ -1,6 +1,6 @@ -import { PickingListsFragment } from './picking-lists.fragment'; +import { ListsFragment } from './lists.fragment'; -const pickingListsFragment = new PickingListsFragment(); +const listsFragment = new ListsFragment(); export class FiltersFragment { getFilterButton = () => cy.get('oryx-picking-filter-button'); @@ -21,7 +21,7 @@ export class FiltersFragment { getSortingOption = (eq: number) => this.getFiltersModal().find('input').eq(eq); shouldChangePickingListsOrder = (isChange: boolean) => - pickingListsFragment + listsFragment .getPickingListsItems() .eq(0) .find('.total oryx-button') diff --git a/apps/fulfillment-e2e/src/support/page_fragments/header.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/header.fragment.ts index 67c0eb54cd..32aa1a9f8b 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/header.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/header.fragment.ts @@ -1,5 +1,5 @@ export class HeaderFragment { - getWrapper = () => cy.get('oryx-header'); + getWrapper = () => cy.get('oryx-picking-header'); getUserIcon = () => this.getWrapper().find('oryx-site-navigation-item'); } diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking-lists-header.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/lists-header.fragment.ts similarity index 93% rename from apps/fulfillment-e2e/src/support/page_fragments/picking-lists-header.fragment.ts rename to apps/fulfillment-e2e/src/support/page_fragments/lists-header.fragment.ts index 97ec738309..88c818855d 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking-lists-header.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/lists-header.fragment.ts @@ -1,4 +1,4 @@ -export class PickingListsHeaderFragment { +export class ListsHeaderFragment { getWrapper = () => cy.get('oryx-picking-lists-header'); getSearch = () => this.getWrapper().find('oryx-search'); getHeadline = () => this.getWrapper().find('oryx-heading'); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking-lists.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/lists.fragment.ts similarity index 96% rename from apps/fulfillment-e2e/src/support/page_fragments/picking-lists.fragment.ts rename to apps/fulfillment-e2e/src/support/page_fragments/lists.fragment.ts index 6f36f77d8a..c5dfd87ac1 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking-lists.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/lists.fragment.ts @@ -1,6 +1,6 @@ import { PickingInProgressModalFragment } from './picking-in-progress-modal.fragment'; -export class PickingListsFragment { +export class ListsFragment { getWrapper = () => cy.get('oryx-picking-lists'); getSortButton = () => this.getWrapper().find('oryx-picking-filter-button'); getNoItemsFallback = () => cy.get('.no-items-fallback'); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking-header.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/picker-header.fragment.ts similarity index 76% rename from apps/fulfillment-e2e/src/support/page_fragments/picking-header.fragment.ts rename to apps/fulfillment-e2e/src/support/page_fragments/picker-header.fragment.ts index ae1b0bd172..95b2572083 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking-header.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/picker-header.fragment.ts @@ -1,5 +1,5 @@ -export class PickingHeaderFragment { - getWrapper = () => cy.get('oryx-picking-header'); +export class PickerHeaderFragment { + getWrapper = () => cy.get('oryx-picking-picker-header'); getCustomerNoteIcon = () => this.getWrapper().find('button[aria-label="Customer note"]'); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/picker.fragment.ts similarity index 93% rename from apps/fulfillment-e2e/src/support/page_fragments/picking.fragment.ts rename to apps/fulfillment-e2e/src/support/page_fragments/picker.fragment.ts index 484a24c478..336dc76d24 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/picker.fragment.ts @@ -1,5 +1,5 @@ -export class PickingFragment { - getWrapper = () => cy.get('oryx-picking'); +export class PickerFragment { + getWrapper = () => cy.get('oryx-picking-picker'); getTabs = () => this.getWrapper().find('oryx-tabs'); getTabsList = () => this.getWrapper().find('oryx-tab'); getTabById = (id) => this.getWrapper().find(`oryx-tab[for="${id}"]`); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts index 419d9c74cd..11ae35a44e 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts @@ -1,5 +1,5 @@ export class PickingInProgressModalFragment { - getWrapper = () => cy.get('oryx-picking-in-progress-modal'); + getWrapper = () => cy.get('oryx-picking-picking-in-progress-modal'); getModal = () => this.getWrapper().find('oryx-modal'); getCloseButton = () => this.getWrapper().find('oryx-button').eq(0); getOverlay = () => this.getModal().find('dialog'); diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking-product.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/product.fragment.ts similarity index 95% rename from apps/fulfillment-e2e/src/support/page_fragments/picking-product.fragment.ts rename to apps/fulfillment-e2e/src/support/page_fragments/product.fragment.ts index d438955717..f12d34c0b4 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking-product.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/product.fragment.ts @@ -1,4 +1,4 @@ -export class PickingProductFragment { +export class ProductFragment { getProducts = () => cy.get('oryx-picking-product-card', { timeout: 10000 }); getQuantityInput = () => this.getProducts().find('oryx-cart-quantity-input'); getQuantityInputField = () => diff --git a/apps/fulfillment-e2e/src/support/page_objects/login.page.ts b/apps/fulfillment-e2e/src/support/page_objects/login.page.ts index 583eb02bf3..84304c82ad 100644 --- a/apps/fulfillment-e2e/src/support/page_objects/login.page.ts +++ b/apps/fulfillment-e2e/src/support/page_objects/login.page.ts @@ -5,7 +5,7 @@ export class LoginPage extends AbstractFAPage { url = '/'; loginForm = new LoginFragment(); - getWrapper = () => cy.get('oryx-login-page'); + getWrapper = () => cy.get('oryx-picking-login'); getLogo = () => this.getWrapper().find('oryx-image[resource="logo"]'); getTitle = () => this.getWrapper().find('oryx-heading'); getErrorNotification = () => diff --git a/apps/fulfillment-e2e/src/support/page_objects/picking.page.ts b/apps/fulfillment-e2e/src/support/page_objects/picker.page.ts similarity index 54% rename from apps/fulfillment-e2e/src/support/page_objects/picking.page.ts rename to apps/fulfillment-e2e/src/support/page_objects/picker.page.ts index 66b2f065b8..d650c0be12 100644 --- a/apps/fulfillment-e2e/src/support/page_objects/picking.page.ts +++ b/apps/fulfillment-e2e/src/support/page_objects/picker.page.ts @@ -1,20 +1,20 @@ -import { PickingProductFragment } from '../page_fragments/picking-product.fragment'; -import { PickingFragment } from '../page_fragments/picking.fragment'; +import { PickerFragment } from '../page_fragments/picker.fragment'; +import { ProductFragment } from '../page_fragments/product.fragment'; import { AbstractFAPage } from './abstract.page'; -export class PickingPage extends AbstractFAPage { +export class PickerPage extends AbstractFAPage { constructor(protected id: string) { super(); } - pickingFragment = new PickingFragment(); - pickingProductFragment = new PickingProductFragment(); + pickerFragment = new PickerFragment(); + productFragment = new ProductFragment(); url = `/picking-list/picking/${this.id}`; - getNotPickedTab = () => this.pickingFragment.getTabsList().eq(0); - getPickedTab = () => this.pickingFragment.getTabsList().eq(1); - getNotFoundTab = () => this.pickingFragment.getTabsList().eq(2); + getNotPickedTab = () => this.pickerFragment.getTabsList().eq(0); + getPickedTab = () => this.pickerFragment.getTabsList().eq(1); + getNotFoundTab = () => this.pickerFragment.getTabsList().eq(2); getNotPickedProductsNumber = () => cy.wrap(this.getProductsNumber(this.getNotPickedTab())); @@ -34,21 +34,18 @@ export class PickingPage extends AbstractFAPage { pickProduct(product, itemsNumber) { product.within(() => { // type items number into field - this.pickingProductFragment - .getQuantityInputField() - .clear() - .type(itemsNumber); + this.productFragment.getQuantityInputField().clear().type(itemsNumber); // click submit button - this.pickingProductFragment.getSubmitButton().click(); + this.productFragment.getSubmitButton().click(); }); } insideTabContent(tab, callback) { tab.invoke('attr', 'for').then((tabId) => { - this.pickingFragment.getTabById(tabId).click(); + this.pickerFragment.getTabById(tabId).click(); - this.pickingFragment.getTabContentById(tabId).within((scopeEl) => { + this.pickerFragment.getTabContentById(tabId).within((scopeEl) => { callback(scopeEl); }); }); diff --git a/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts b/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts index 3b9e0f1be4..edc53a92b0 100644 --- a/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts +++ b/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts @@ -19,7 +19,7 @@ describe('CustomerNoteModal', () => { describe('when note property is not provided', () => { beforeEach(async () => { element = await fixture( - html`` + html`` ); }); @@ -32,9 +32,9 @@ describe('CustomerNoteModal', () => { const noteText = 'note text'; beforeEach(async () => { element = await fixture( - html` + html` ${noteText} - ` + ` ); }); diff --git a/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts b/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts index cbeb8ee32c..fd4fb2b65e 100644 --- a/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts +++ b/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const customerNoteModalComponent = componentDef({ - name: 'oryx-customer-note-modal', + name: 'oryx-picking-customer-note-modal', impl: () => import('./customer-note-modal.component').then( (m) => m.CustomerNoteModalComponent diff --git a/libs/domain/picking/customer-note/customer-note.component.spec.ts b/libs/domain/picking/customer-note/customer-note.component.spec.ts index dcf1f5e318..28fa0f6a6d 100644 --- a/libs/domain/picking/customer-note/customer-note.component.spec.ts +++ b/libs/domain/picking/customer-note/customer-note.component.spec.ts @@ -29,7 +29,7 @@ describe('CustomerNoteComponent', () => { const getPickingInProgressModal = () => { return element.renderRoot.querySelector( - 'oryx-picking-in-progress-modal' + 'oryx-picking-picking-in-progress-modal' ) as PickingInProgressModalComponent; }; @@ -61,7 +61,9 @@ describe('CustomerNoteComponent', () => { RouterService ) as unknown as MockRouterService; element = await fixture( - html`` + html`` ); }); @@ -108,7 +110,9 @@ describe('CustomerNoteComponent', () => { ); element = await fixture( - html`` + html`` ); element.renderRoot.querySelector('oryx-button')?.click(); diff --git a/libs/domain/picking/customer-note/customer-note.component.ts b/libs/domain/picking/customer-note/customer-note.component.ts index 2acb494f81..a640092715 100644 --- a/libs/domain/picking/customer-note/customer-note.component.ts +++ b/libs/domain/picking/customer-note/customer-note.component.ts @@ -15,7 +15,7 @@ export class CustomerNoteComponent extends I18nMixin( protected routerService = resolve(RouterService); - @query('oryx-picking-in-progress-modal') + @query('oryx-picking-picking-in-progress-modal') protected pickingInProgressModal!: PickingInProgressModalComponent; protected onProceed(): void { @@ -45,7 +45,7 @@ export class CustomerNoteComponent extends I18nMixin( protected override render(): TemplateResult { return html`
- +

${this.i18n('picking.customer-note')}

@@ -60,9 +60,9 @@ export class CustomerNoteComponent extends I18nMixin( @click=${this.onProceed} > - + > `; } diff --git a/libs/domain/picking/customer-note/customer-note.def.ts b/libs/domain/picking/customer-note/customer-note.def.ts index 04692715ee..b51a9437d5 100644 --- a/libs/domain/picking/customer-note/customer-note.def.ts +++ b/libs/domain/picking/customer-note/customer-note.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const customerNoteComponent = componentDef({ - name: 'oryx-customer-note', + name: 'oryx-picking-customer-note', impl: () => import('./customer-note.component').then((m) => m.CustomerNoteComponent), }); diff --git a/libs/domain/picking/customer-note/customer-note.styles.ts b/libs/domain/picking/customer-note/customer-note.styles.ts index e75c1a99ad..f36e7a9874 100644 --- a/libs/domain/picking/customer-note/customer-note.styles.ts +++ b/libs/domain/picking/customer-note/customer-note.styles.ts @@ -17,7 +17,7 @@ export const customerNoteComponentStyles = css` flex-direction: column; } - oryx-navigate-back { + oryx-picking-navigate-back { align-self: flex-start; margin-block-end: 40px; } diff --git a/libs/domain/picking/customer-note/stories/demo.stories.ts b/libs/domain/picking/customer-note/stories/demo.stories.ts index 50fb6e527d..81c67ec209 100644 --- a/libs/domain/picking/customer-note/stories/demo.stories.ts +++ b/libs/domain/picking/customer-note/stories/demo.stories.ts @@ -14,7 +14,9 @@ export default { const Template: Story = (): TemplateResult => { return html` - + `; }; diff --git a/libs/domain/picking/discard-modal/discard-modal.component.spec.ts b/libs/domain/picking/discard-modal/discard-modal.component.spec.ts index 46c638372d..7db0a71d19 100644 --- a/libs/domain/picking/discard-modal/discard-modal.component.spec.ts +++ b/libs/domain/picking/discard-modal/discard-modal.component.spec.ts @@ -1,11 +1,11 @@ import { fixture } from '@open-wc/testing-helpers'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { DiscardPickingComponent } from './discard-modal.component'; +import { DiscardModalComponent } from './discard-modal.component'; import { discardModalComponent } from './discard-modal.def'; describe('DiscardModalComponent', () => { - let element: DiscardPickingComponent; + let element: DiscardModalComponent; beforeAll(async () => { await useComponent(discardModalComponent); @@ -13,7 +13,7 @@ describe('DiscardModalComponent', () => { beforeEach(async () => { element = await fixture( - html`` + html`` ); }); diff --git a/libs/domain/picking/discard-modal/discard-modal.component.ts b/libs/domain/picking/discard-modal/discard-modal.component.ts index 65a53ffcbb..29b1e49ed3 100644 --- a/libs/domain/picking/discard-modal/discard-modal.component.ts +++ b/libs/domain/picking/discard-modal/discard-modal.component.ts @@ -5,7 +5,7 @@ import { LitElement, TemplateResult, html } from 'lit'; import { property } from 'lit/decorators.js'; import { discardModalStyles } from './discard-modal.styles'; -export class DiscardPickingComponent extends I18nMixin(LitElement) { +export class DiscardModalComponent extends I18nMixin(LitElement) { static styles = discardModalStyles; @property({ type: Boolean }) open?: boolean; diff --git a/libs/domain/picking/discard-modal/discard-modal.def.ts b/libs/domain/picking/discard-modal/discard-modal.def.ts index 5cf800db22..383afd2155 100644 --- a/libs/domain/picking/discard-modal/discard-modal.def.ts +++ b/libs/domain/picking/discard-modal/discard-modal.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const discardModalComponent = componentDef({ - name: 'oryx-discard-picking', + name: 'oryx-picking-discard-modal', impl: () => - import('./discard-modal.component').then((m) => m.DiscardPickingComponent), + import('./discard-modal.component').then((m) => m.DiscardModalComponent), }); diff --git a/libs/domain/picking/discard-modal/stories/demo.stories.ts b/libs/domain/picking/discard-modal/stories/demo.stories.ts index 65541db5c2..8f4dd873dd 100644 --- a/libs/domain/picking/discard-modal/stories/demo.stories.ts +++ b/libs/domain/picking/discard-modal/stories/demo.stories.ts @@ -17,7 +17,7 @@ export default { } as Meta; const Template: Story = (): TemplateResult => { - return html` `; + return html` `; }; export const Demo = Template.bind({}); diff --git a/libs/domain/picking/header/header.component.spec.ts b/libs/domain/picking/header/header.component.spec.ts index 2ca92ce6a6..519faebe77 100644 --- a/libs/domain/picking/header/header.component.spec.ts +++ b/libs/domain/picking/header/header.component.spec.ts @@ -13,7 +13,7 @@ describe('Header Component', () => { }); beforeEach(async () => { - element = await fixture(``); + element = await fixture(``); }); it('is defined', () => { diff --git a/libs/domain/picking/header/header.def.ts b/libs/domain/picking/header/header.def.ts index 8f7148faa8..3e2fdee667 100644 --- a/libs/domain/picking/header/header.def.ts +++ b/libs/domain/picking/header/header.def.ts @@ -1,6 +1,6 @@ import { componentDef } from '@spryker-oryx/utilities'; export const headerComponent = componentDef({ - name: 'oryx-header', + name: 'oryx-picking-header', impl: () => import('./header.component').then((m) => m.HeaderComponent), }); diff --git a/libs/domain/picking/header/stories/demo.stories.ts b/libs/domain/picking/header/stories/demo.stories.ts index df6e1ff8d3..2ed3f5c11e 100644 --- a/libs/domain/picking/header/stories/demo.stories.ts +++ b/libs/domain/picking/header/stories/demo.stories.ts @@ -14,7 +14,7 @@ export default { }; const Template: Story = (): TemplateResult => { - return html``; + return html``; }; export const Demo = Template.bind({}); diff --git a/libs/domain/picking/list-item/index.ts b/libs/domain/picking/list-item/index.ts new file mode 100644 index 0000000000..2e0735a9c7 --- /dev/null +++ b/libs/domain/picking/list-item/index.ts @@ -0,0 +1,3 @@ +export * from './list-item.component'; +export * from './list-item.model'; +export * from './list-item.styles'; diff --git a/libs/domain/picking/picking-list-item/picking-list-item.component.spec.ts b/libs/domain/picking/list-item/list-item.component.spec.ts similarity index 96% rename from libs/domain/picking/picking-list-item/picking-list-item.component.spec.ts rename to libs/domain/picking/list-item/list-item.component.spec.ts index fb32aa1d4b..38d12d0c16 100644 --- a/libs/domain/picking/picking-list-item/picking-list-item.component.spec.ts +++ b/libs/domain/picking/list-item/list-item.component.spec.ts @@ -8,8 +8,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of, throwError } from 'rxjs'; import { afterEach } from 'vitest'; -import { PickingListItemComponent } from './picking-list-item.component'; -import { pickingListItemComponent } from './picking-list-item.def'; +import { ListItemComponent } from './list-item.component'; +import { listItemComponent } from './list-item.def'; class MockRouterService implements Partial { navigate = vi.fn(); } @@ -25,13 +25,13 @@ class MockLocaleService implements Partial { } describe('PickingListItemComponent', () => { - let element: PickingListItemComponent; + let element: ListItemComponent; let service: MockPickingListService; let routerService: MockRouterService; let localeService: MockLocaleService; beforeAll(async () => { - await useComponent(pickingListItemComponent); + await useComponent(listItemComponent); }); beforeEach(() => { diff --git a/libs/domain/picking/picking-list-item/picking-list-item.component.ts b/libs/domain/picking/list-item/list-item.component.ts similarity index 87% rename from libs/domain/picking/picking-list-item/picking-list-item.component.ts rename to libs/domain/picking/list-item/list-item.component.ts index 9a67e3d566..11a37f9e93 100644 --- a/libs/domain/picking/picking-list-item/picking-list-item.component.ts +++ b/libs/domain/picking/list-item/list-item.component.ts @@ -8,12 +8,12 @@ import { I18nMixin, computed } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { when } from 'lit/directives/when.js'; import { catchError, of, tap } from 'rxjs'; -import { PickingListItemAttributes } from './picking-list-item.model'; -import { pickingListItemComponentStyles } from './picking-list-item.styles'; +import { ListItemAttributes } from './list-item.model'; +import { pickingListItemComponentStyles } from './list-item.styles'; -export class PickingListItemComponent +export class ListItemComponent extends I18nMixin(PickingListMixin(LitElement)) - implements PickingListItemAttributes + implements ListItemAttributes { static styles = pickingListItemComponentStyles; @@ -82,7 +82,7 @@ export class PickingListItemComponent
- ${this.i18n('picking.picking-list-item.-items', { + ${this.i18n('picking.list-item.-items', { count: this.$pickingList()?.itemsCount, })} ${when( @@ -94,9 +94,7 @@ export class PickingListItemComponent .color=${ButtonColor.Primary} .size=${ButtonSize.Md} .icon=${IconTypes.Info} - .label=${this.i18n( - 'picking.picking-list-item.show-customer-note' - )} + .label=${this.i18n('picking.list-item.show-customer-note')} @click=${this.showCustomerNote} > ` @@ -108,7 +106,7 @@ export class PickingListItemComponent class="start-picking" .color=${ButtonColor.Primary} .size=${ButtonSize.Lg} - .text=${this.i18n('picking.picking-list-item.start-picking')} + .text=${this.i18n('picking.list-item.start-picking')} ?loading=${this.$upcomingPickingListId() === this.$pickingList().id} ?disabled=${this.$upcomingPickingListId() && this.$upcomingPickingListId() !== this.$pickingList().id} diff --git a/libs/domain/picking/list-item/list-item.def.ts b/libs/domain/picking/list-item/list-item.def.ts new file mode 100644 index 0000000000..e098f38edc --- /dev/null +++ b/libs/domain/picking/list-item/list-item.def.ts @@ -0,0 +1,8 @@ +import { componentDef } from '@spryker-oryx/utilities'; + +export const listItemComponent = componentDef({ + name: 'oryx-picking-list-item', + impl: () => import('./list-item.component').then((m) => m.ListItemComponent), + schema: () => + import('./list-item.schema').then((m) => m.listItemComponentSchema), +}); diff --git a/libs/domain/picking/list-item/list-item.model.ts b/libs/domain/picking/list-item/list-item.model.ts new file mode 100644 index 0000000000..f31c98a84d --- /dev/null +++ b/libs/domain/picking/list-item/list-item.model.ts @@ -0,0 +1,3 @@ +export interface ListItemAttributes { + pickingListId?: string; +} diff --git a/libs/domain/picking/list-item/list-item.schema.ts b/libs/domain/picking/list-item/list-item.schema.ts new file mode 100644 index 0000000000..b06cbf1a9c --- /dev/null +++ b/libs/domain/picking/list-item/list-item.schema.ts @@ -0,0 +1,8 @@ +import { ContentComponentSchema } from '@spryker-oryx/experience'; +import { ListItemComponent } from './list-item.component'; + +export const listItemComponentSchema: ContentComponentSchema = + { + name: 'List Item', + group: 'Picking', + }; diff --git a/libs/domain/picking/picking-list-item/picking-list-item.styles.ts b/libs/domain/picking/list-item/list-item.styles.ts similarity index 100% rename from libs/domain/picking/picking-list-item/picking-list-item.styles.ts rename to libs/domain/picking/list-item/list-item.styles.ts diff --git a/libs/domain/picking/picking-list-item/stories/demo.stories.ts b/libs/domain/picking/list-item/stories/demo.stories.ts similarity index 92% rename from libs/domain/picking/picking-list-item/stories/demo.stories.ts rename to libs/domain/picking/list-item/stories/demo.stories.ts index 6641ef6efa..ded0be1c72 100644 --- a/libs/domain/picking/picking-list-item/stories/demo.stories.ts +++ b/libs/domain/picking/list-item/stories/demo.stories.ts @@ -29,9 +29,9 @@ const Template: Story = ({ pickingListId, }): TemplateResult => { return html` - + > `; }; diff --git a/libs/domain/picking/picking-list-item/stories/static/variants.stories.ts b/libs/domain/picking/list-item/stories/static/variants.stories.ts similarity index 81% rename from libs/domain/picking/picking-list-item/stories/static/variants.stories.ts rename to libs/domain/picking/list-item/stories/static/variants.stories.ts index 82dee1c574..9cf0e73997 100644 --- a/libs/domain/picking/picking-list-item/stories/static/variants.stories.ts +++ b/libs/domain/picking/list-item/stories/static/variants.stories.ts @@ -15,14 +15,14 @@ export default { const Template: Story = (): TemplateResult => { return html`

With cart note

- + >

Without cart note

- + > `; }; diff --git a/libs/domain/picking/lists-header/index.ts b/libs/domain/picking/lists-header/index.ts new file mode 100644 index 0000000000..28f05701ec --- /dev/null +++ b/libs/domain/picking/lists-header/index.ts @@ -0,0 +1,2 @@ +export * from './lists-header.component'; +export * from './lists-header.styles'; diff --git a/libs/domain/picking/picking-lists-header/picking-lists-header.component.spec.ts b/libs/domain/picking/lists-header/lists-header.component.spec.ts similarity index 85% rename from libs/domain/picking/picking-lists-header/picking-lists-header.component.spec.ts rename to libs/domain/picking/lists-header/lists-header.component.spec.ts index 8c2340b638..078ae327d2 100644 --- a/libs/domain/picking/picking-lists-header/picking-lists-header.component.spec.ts +++ b/libs/domain/picking/lists-header/lists-header.component.spec.ts @@ -5,8 +5,8 @@ import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import MockDate from 'mockdate'; import { of } from 'rxjs'; -import { PickingListsHeaderComponent } from './picking-lists-header.component'; -import { pickingListsHeaderComponent } from './picking-lists-header.def'; +import { ListsHeaderComponent } from './lists-header.component'; +import { listsHeaderComponent } from './lists-header.def'; const mockedDate = new Date(1970, 1, 1); const formattedDate = 'formattedDate'; @@ -16,11 +16,11 @@ class MockLocaleService implements Partial { } describe('PickingListsHeaderComponent', () => { - let element: PickingListsHeaderComponent; + let element: ListsHeaderComponent; let locateService: MockLocaleService; beforeAll(async () => { - await useComponent(pickingListsHeaderComponent); + await useComponent(listsHeaderComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/picking-lists-header/picking-lists-header.component.ts b/libs/domain/picking/lists-header/lists-header.component.ts similarity index 89% rename from libs/domain/picking/picking-lists-header/picking-lists-header.component.ts rename to libs/domain/picking/lists-header/lists-header.component.ts index 8e1c015789..8e2affa96f 100644 --- a/libs/domain/picking/picking-lists-header/picking-lists-header.component.ts +++ b/libs/domain/picking/lists-header/lists-header.component.ts @@ -3,9 +3,9 @@ import { LocaleService } from '@spryker-oryx/i18n'; import { IconTypes } from '@spryker-oryx/ui/icon'; import { I18nMixin, signal } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; -import { pickingListsHeaderComponentStyles } from './picking-lists-header.styles'; +import { pickingListsHeaderComponentStyles } from './lists-header.styles'; -export class PickingListsHeaderComponent extends I18nMixin(LitElement) { +export class ListsHeaderComponent extends I18nMixin(LitElement) { static styles = pickingListsHeaderComponentStyles; protected localeService = resolve(LocaleService); @@ -37,7 +37,7 @@ export class PickingListsHeaderComponent extends I18nMixin(LitElement) { protected override render(): TemplateResult { return html` - +

@@ -59,7 +59,7 @@ export class PickingListsHeaderComponent extends I18nMixin(LitElement) { />

- + `; } } diff --git a/libs/domain/picking/lists-header/lists-header.def.ts b/libs/domain/picking/lists-header/lists-header.def.ts new file mode 100644 index 0000000000..5cf12f2a9c --- /dev/null +++ b/libs/domain/picking/lists-header/lists-header.def.ts @@ -0,0 +1,7 @@ +import { componentDef } from '@spryker-oryx/utilities'; + +export const listsHeaderComponent = componentDef({ + name: 'oryx-picking-lists-header', + impl: () => + import('./lists-header.component').then((m) => m.ListsHeaderComponent), +}); diff --git a/libs/domain/picking/picking-lists-header/picking-lists-header.styles.ts b/libs/domain/picking/lists-header/lists-header.styles.ts similarity index 90% rename from libs/domain/picking/picking-lists-header/picking-lists-header.styles.ts rename to libs/domain/picking/lists-header/lists-header.styles.ts index 58d9c337a2..39e4dbf303 100644 --- a/libs/domain/picking/picking-lists-header/picking-lists-header.styles.ts +++ b/libs/domain/picking/lists-header/lists-header.styles.ts @@ -1,11 +1,11 @@ import { css } from 'lit'; export const pickingListsHeaderComponentStyles = css` - oryx-header { + oryx-picking-header { box-shadow: var(--oryx-elevation-2) var(--oryx-elevation-color-2); } - oryx-header div { + oryx-picking-header div { display: flex; width: 100%; justify-content: space-between; diff --git a/libs/domain/picking/picking-lists-header/stories/demo.stories.ts b/libs/domain/picking/lists-header/stories/demo.stories.ts similarity index 100% rename from libs/domain/picking/picking-lists-header/stories/demo.stories.ts rename to libs/domain/picking/lists-header/stories/demo.stories.ts diff --git a/libs/domain/picking/picking-lists-header/stories/static/variants.stories.ts b/libs/domain/picking/lists-header/stories/static/variants.stories.ts similarity index 100% rename from libs/domain/picking/picking-lists-header/stories/static/variants.stories.ts rename to libs/domain/picking/lists-header/stories/static/variants.stories.ts diff --git a/libs/domain/picking/lists/index.ts b/libs/domain/picking/lists/index.ts new file mode 100644 index 0000000000..e3bffd4bb2 --- /dev/null +++ b/libs/domain/picking/lists/index.ts @@ -0,0 +1,3 @@ +export * from './lists.component'; +export * from './lists.model'; +export * from './lists.styles'; diff --git a/libs/domain/picking/picking-lists/picking-lists.component.spec.ts b/libs/domain/picking/lists/lists.component.spec.ts similarity index 95% rename from libs/domain/picking/picking-lists/picking-lists.component.spec.ts rename to libs/domain/picking/lists/lists.component.spec.ts index 3c0d3cda8f..0d4b3f3c18 100644 --- a/libs/domain/picking/picking-lists/picking-lists.component.spec.ts +++ b/libs/domain/picking/lists/lists.component.spec.ts @@ -10,8 +10,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of } from 'rxjs'; import { afterEach, beforeAll, beforeEach } from 'vitest'; -import { PickingListsComponent } from './picking-lists.component'; -import { pickingListsComponent } from './picking-lists.def'; +import { ListsComponent } from './lists.component'; +import { listsComponent } from './lists.def'; const mockOfflineDataPlugin = { isRefreshing: vi.fn().mockReturnValue(of(false)), @@ -32,13 +32,13 @@ class MockPickingListService implements Partial { isRefreshing = vi.fn().mockReturnValue(of(false)); } -describe('PickingListsComponent', () => { - let element: PickingListsComponent; +describe('ListsComponent', () => { + let element: ListsComponent; let service: MockPickingListService; let syncService: MockPickingSyncActionHandlerService; beforeAll(async () => { - await useComponent([pickingListsComponent]); + await useComponent([listsComponent]); }); beforeEach(async () => { @@ -111,10 +111,12 @@ describe('PickingListsComponent', () => { describe('when picking lists is not empty', () => { const getCustomerNoteModal = (): CustomerNoteModalComponent | null => - element.renderRoot.querySelector('oryx-customer-note-modal'); + element.renderRoot.querySelector('oryx-picking-customer-note-modal'); const getPickingInProgressModal = (): ModalComponent | null => - element.renderRoot.querySelector('oryx-picking-in-progress-modal'); + element.renderRoot.querySelector( + 'oryx-picking-picking-in-progress-modal' + ); it('passes the a11y audit', async () => { await expect(element).shadowDom.to.be.accessible(); diff --git a/libs/domain/picking/picking-lists/picking-lists.component.ts b/libs/domain/picking/lists/lists.component.ts similarity index 95% rename from libs/domain/picking/picking-lists/picking-lists.component.ts rename to libs/domain/picking/lists/lists.component.ts index 4ae9d2d7dc..ee29fffb8c 100644 --- a/libs/domain/picking/picking-lists/picking-lists.component.ts +++ b/libs/domain/picking/lists/lists.component.ts @@ -17,10 +17,10 @@ import { repeat } from 'lit/directives/repeat.js'; import { when } from 'lit/directives/when.js'; import { Subject, distinctUntilChanged, map, startWith, switchMap } from 'rxjs'; import { PickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.component'; -import { pickingListsComponentStyles } from './picking-lists.styles'; +import { pickingListsComponentStyles } from './lists.styles'; @signalAware() -export class PickingListsComponent extends I18nMixin(LitElement) { +export class ListsComponent extends I18nMixin(LitElement) { static styles = pickingListsComponentStyles; protected pickingListService = resolve(PickingListService); protected pickingSyncHandler = resolve(PickingSyncActionHandlerService); @@ -63,16 +63,16 @@ export class PickingListsComponent extends I18nMixin(LitElement) { protected override render(): TemplateResult { return html` ${this.renderPickingLists()} - + > - ${this.customerNote} - `; + `; } protected renderPickingLists(): TemplateResult { diff --git a/libs/domain/picking/lists/lists.def.ts b/libs/domain/picking/lists/lists.def.ts new file mode 100644 index 0000000000..9aa1f290b4 --- /dev/null +++ b/libs/domain/picking/lists/lists.def.ts @@ -0,0 +1,7 @@ +import { componentDef } from '@spryker-oryx/utilities'; + +export const listsComponent = componentDef({ + name: 'oryx-picking-lists', + impl: () => import('./lists.component').then((m) => m.ListsComponent), + schema: () => import('./lists.schema').then((m) => m.listsComponentSchema), +}); diff --git a/libs/domain/picking/lists/lists.model.ts b/libs/domain/picking/lists/lists.model.ts new file mode 100644 index 0000000000..655438d1f0 --- /dev/null +++ b/libs/domain/picking/lists/lists.model.ts @@ -0,0 +1,3 @@ +export interface ListComponentProperties { + pickingListId?: string; +} diff --git a/libs/domain/picking/lists/lists.schema.ts b/libs/domain/picking/lists/lists.schema.ts new file mode 100644 index 0000000000..7fcbe89613 --- /dev/null +++ b/libs/domain/picking/lists/lists.schema.ts @@ -0,0 +1,7 @@ +import { ContentComponentSchema } from '@spryker-oryx/experience'; +import { ListsComponent } from './lists.component'; + +export const listsComponentSchema: ContentComponentSchema = { + name: 'Lists', + group: 'Picking', +}; diff --git a/libs/domain/picking/picking-lists/picking-lists.styles.ts b/libs/domain/picking/lists/lists.styles.ts similarity index 100% rename from libs/domain/picking/picking-lists/picking-lists.styles.ts rename to libs/domain/picking/lists/lists.styles.ts diff --git a/libs/domain/picking/picking-lists/stories/demo.stories.ts b/libs/domain/picking/lists/stories/demo.stories.ts similarity index 100% rename from libs/domain/picking/picking-lists/stories/demo.stories.ts rename to libs/domain/picking/lists/stories/demo.stories.ts diff --git a/libs/domain/picking/picking-lists/stories/static/data.stories.ts b/libs/domain/picking/lists/stories/static/data.stories.ts similarity index 100% rename from libs/domain/picking/picking-lists/stories/static/data.stories.ts rename to libs/domain/picking/lists/stories/static/data.stories.ts diff --git a/libs/domain/picking/picking-lists/stories/static/empty.stories.ts b/libs/domain/picking/lists/stories/static/empty.stories.ts similarity index 100% rename from libs/domain/picking/picking-lists/stories/static/empty.stories.ts rename to libs/domain/picking/lists/stories/static/empty.stories.ts diff --git a/libs/domain/picking/login/login.component.spec.ts b/libs/domain/picking/login/login.component.spec.ts index fc033599a7..4da3dc0248 100644 --- a/libs/domain/picking/login/login.component.spec.ts +++ b/libs/domain/picking/login/login.component.spec.ts @@ -12,7 +12,7 @@ describe('LoginPageComponent', () => { }); beforeEach(async () => { - element = await fixture(html` { diff --git a/libs/domain/picking/login/login.def.ts b/libs/domain/picking/login/login.def.ts index acee7d2b40..d856102669 100644 --- a/libs/domain/picking/login/login.def.ts +++ b/libs/domain/picking/login/login.def.ts @@ -1,6 +1,6 @@ import { componentDef } from '@spryker-oryx/utilities'; export const loginPageComponent = componentDef({ - name: 'oryx-login-page', + name: 'oryx-picking-login', impl: () => import('./login.component').then((m) => m.default), }); diff --git a/libs/domain/picking/navigate-back/navigate-back.component.spec.ts b/libs/domain/picking/navigate-back/navigate-back.component.spec.ts index 19d926e1ca..8db4fa3fc8 100644 --- a/libs/domain/picking/navigate-back/navigate-back.component.spec.ts +++ b/libs/domain/picking/navigate-back/navigate-back.component.spec.ts @@ -13,7 +13,9 @@ describe('NavigateBackComponent', () => { }); beforeEach(async () => { - element = await fixture(html``); + element = await fixture( + html`` + ); }); afterEach(() => { @@ -34,9 +36,9 @@ describe('NavigateBackComponent', () => { const url = '/url'; beforeEach(async () => { - element = await fixture(html``); + >`); }); it('should build the url based on provided url', () => { diff --git a/libs/domain/picking/navigate-back/navigate-back.def.ts b/libs/domain/picking/navigate-back/navigate-back.def.ts index 7b23e99209..cfb6a6a947 100644 --- a/libs/domain/picking/navigate-back/navigate-back.def.ts +++ b/libs/domain/picking/navigate-back/navigate-back.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const navigateBackComponent = componentDef({ - name: 'oryx-navigate-back', + name: 'oryx-picking-navigate-back', impl: () => import('./navigate-back.component').then((m) => m.NavigateBackComponent), schema: () => diff --git a/libs/domain/picking/navigate-back/stories/demo.stories.ts b/libs/domain/picking/navigate-back/stories/demo.stories.ts index 9751136296..fb4704daf2 100644 --- a/libs/domain/picking/navigate-back/stories/demo.stories.ts +++ b/libs/domain/picking/navigate-back/stories/demo.stories.ts @@ -15,11 +15,11 @@ export default { const Template: Story = (props): TemplateResult => { return html` - + `; }; diff --git a/libs/domain/picking/picker-header/index.ts b/libs/domain/picking/picker-header/index.ts new file mode 100644 index 0000000000..34b51255c8 --- /dev/null +++ b/libs/domain/picking/picker-header/index.ts @@ -0,0 +1 @@ +export * from './picker-header.component'; diff --git a/libs/domain/picking/picking-header/picking-header.component.spec.ts b/libs/domain/picking/picker-header/picker-header.component.spec.ts similarity index 79% rename from libs/domain/picking/picking-header/picking-header.component.spec.ts rename to libs/domain/picking/picker-header/picker-header.component.spec.ts index e455e1d54e..8a70fb1396 100644 --- a/libs/domain/picking/picking-header/picking-header.component.spec.ts +++ b/libs/domain/picking/picker-header/picker-header.component.spec.ts @@ -11,8 +11,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { BehaviorSubject, of } from 'rxjs'; import { discardModalComponent } from '../discard-modal/discard-modal.def'; -import { PickingHeaderComponent } from './picking-header.component'; -import { pickingHeaderComponent } from './picking-header.def'; +import { PickerHeaderComponent } from './picker-header.component'; +import { pickerHeaderComponent } from './picker-header.def'; class MockPickingListService implements Partial { get = vi.fn().mockReturnValue(of([mockPickingListData[0]])); @@ -32,13 +32,13 @@ class MockRouterService implements Partial { } describe('PickingHeaderComponent', () => { - let element: PickingHeaderComponent; + let element: PickerHeaderComponent; let service: MockPickingListService; let routerService: MockRouterService; let pickingHeaderService: MockPickingHeaderService; beforeAll(async () => { - await useComponent([pickingHeaderComponent, discardModalComponent]); + await useComponent([pickerHeaderComponent, discardModalComponent]); }); beforeEach(async () => { @@ -60,7 +60,9 @@ describe('PickingHeaderComponent', () => { }); element = await fixture( - html`` + html`` ); service = testInjector.inject( @@ -82,12 +84,14 @@ describe('PickingHeaderComponent', () => { describe('when component is created', () => { beforeEach(async () => { element = await fixture( - html`` + html`` ); }); it('is defined', () => { - expect(element).toBeInstanceOf(PickingHeaderComponent); + expect(element).toBeInstanceOf(PickerHeaderComponent); }); it('passes the a11y audit', async () => { @@ -95,12 +99,12 @@ describe('PickingHeaderComponent', () => { }); it('should render header component', () => { - expect(element).toContainElement('oryx-header'); + expect(element).toContainElement('oryx-picking-header'); }); it('should render back button', () => { const backButton = element.renderRoot.querySelector( - 'oryx-header oryx-button:first-of-type' + 'oryx-picking-header oryx-button:first-of-type' ); expect(backButton).toHaveProperty( @@ -120,11 +124,13 @@ describe('PickingHeaderComponent', () => { }); it('should render discard modal', () => { - expect(element).toContainElement('oryx-discard-picking'); + expect(element).toContainElement('oryx-picking-discard-modal'); }); it('should not show discard modal', () => { - expect(element).toContainElement('oryx-discard-picking:not([open])'); + expect(element).toContainElement( + 'oryx-picking-discard-modal:not([open])' + ); }); }); @@ -137,7 +143,7 @@ describe('PickingHeaderComponent', () => { it('should provide the note text to customer-note-modal component', () => { const customerNodeModal = element.renderRoot.querySelector( - 'oryx-customer-note-modal' + 'oryx-picking-customer-note-modal' ); expect(customerNodeModal?.hasAttribute('open')).toBe(true); expect(customerNodeModal?.textContent?.trim()).toBe( @@ -151,7 +157,9 @@ describe('PickingHeaderComponent', () => { service.get = vi.fn().mockReturnValue(of([mockPickingListData[1]])); element = await fixture( - html`` + html`` ); }); @@ -165,7 +173,7 @@ describe('PickingHeaderComponent', () => { it('should not render customer note modal', () => { expect( - element.renderRoot.querySelector('oryx-customer-note-modal') + element.renderRoot.querySelector('oryx-picking-customer-note-modal') ).toBeNull(); }); }); @@ -173,7 +181,7 @@ describe('PickingHeaderComponent', () => { describe('when back button is clicked', () => { beforeEach(() => { element.renderRoot - .querySelector('oryx-header oryx-button') + .querySelector('oryx-picking-header oryx-button') ?.click(); }); @@ -188,20 +196,22 @@ describe('PickingHeaderComponent', () => { }); it('should open discard modal', () => { - expect(element).toContainElement('oryx-discard-picking[open]'); + expect(element).toContainElement('oryx-picking-discard-modal[open]'); }); describe('and close button is clicked', () => { beforeEach(() => { element.renderRoot - .querySelector('oryx-discard-picking') + .querySelector('oryx-picking-discard-modal') ?.dispatchEvent( new CustomEvent(CLOSE_EVENT, { bubbles: true, composed: true }) ); }); it('should close discard modal', () => { - expect(element).toContainElement('oryx-discard-picking:not([open])'); + expect(element).toContainElement( + 'oryx-picking-discard-modal:not([open])' + ); }); it('should call picking header service cancel', () => { @@ -212,7 +222,7 @@ describe('PickingHeaderComponent', () => { describe('and discard button is clicked', () => { beforeEach(() => { element.renderRoot - .querySelector('oryx-discard-picking') + .querySelector('oryx-picking-discard-modal') ?.dispatchEvent( new CustomEvent(BACK_EVENT, { bubbles: true, composed: true }) ); diff --git a/libs/domain/picking/picking-header/picking-header.component.ts b/libs/domain/picking/picker-header/picker-header.component.ts similarity index 82% rename from libs/domain/picking/picking-header/picking-header.component.ts rename to libs/domain/picking/picker-header/picker-header.component.ts index 32a0344dee..21292aafa6 100644 --- a/libs/domain/picking/picking-header/picking-header.component.ts +++ b/libs/domain/picking/picker-header/picker-header.component.ts @@ -1,6 +1,6 @@ import { resolve } from '@spryker-oryx/di'; import { PickingHeaderService, PickingListMixin } from '@spryker-oryx/picking'; -import { DiscardPickingComponent } from '@spryker-oryx/picking/discard-modal'; +import { DiscardModalComponent } from '@spryker-oryx/picking/discard-modal'; import { RouterService } from '@spryker-oryx/router'; import { ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; import { IconTypes } from '@spryker-oryx/ui/icon'; @@ -8,9 +8,9 @@ import { I18nMixin, subscribe } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { query, state } from 'lit/decorators.js'; import { tap } from 'rxjs'; -import { styles } from './picking-header.styles'; +import { styles } from './picker-header.styles'; -export class PickingHeaderComponent extends I18nMixin( +export class PickerHeaderComponent extends I18nMixin( PickingListMixin(LitElement) ) { static styles = styles; @@ -18,8 +18,8 @@ export class PickingHeaderComponent extends I18nMixin( protected routerService = resolve(RouterService); protected pickingHeaderService = resolve(PickingHeaderService); - @query('oryx-discard-picking') - protected discardModal?: DiscardPickingComponent; + @query('oryx-picking-discard-modal') + protected discardModal?: DiscardModalComponent; @state() isCartNoteVisible?: boolean; @@ -42,19 +42,19 @@ export class PickingHeaderComponent extends I18nMixin( .icon=${IconTypes.Info} @click=${() => (this.isCartNoteVisible = true)} > - (this.isCartNoteVisible = false)} > ${this.$pickingList()?.cartNote} - + ` : ''}`; } protected override render(): TemplateResult { return html` - +
${this.$pickingList()?.orderReferences[0]}
${this.renderCartNoteButton()} - { this.pickingHeaderService.cancel(); this.closeDiscardModal(); }} @oryx.back=${this.leave} - > - + > + `; } @@ -92,4 +92,4 @@ export class PickingHeaderComponent extends I18nMixin( } } -export default PickingHeaderComponent; +export default PickerHeaderComponent; diff --git a/libs/domain/picking/picker-header/picker-header.def.ts b/libs/domain/picking/picker-header/picker-header.def.ts new file mode 100644 index 0000000000..93d71f69b5 --- /dev/null +++ b/libs/domain/picking/picker-header/picker-header.def.ts @@ -0,0 +1,7 @@ +import { componentDef } from '@spryker-oryx/utilities'; + +export const pickerHeaderComponent = componentDef({ + name: 'oryx-picking-picker-header', + impl: () => + import('./picker-header.component').then((m) => m.PickerHeaderComponent), +}); diff --git a/libs/domain/picking/picking-header/picking-header.styles.ts b/libs/domain/picking/picker-header/picker-header.styles.ts similarity index 75% rename from libs/domain/picking/picking-header/picking-header.styles.ts rename to libs/domain/picking/picker-header/picker-header.styles.ts index 7000c4ef06..52c638b178 100644 --- a/libs/domain/picking/picking-header/picking-header.styles.ts +++ b/libs/domain/picking/picker-header/picker-header.styles.ts @@ -5,8 +5,8 @@ export const styles = css` --oryx-icon-color: var(--oryx-color-primary-9); } - oryx-discard-picking, - oryx-customer-note-modal { + oryx-picking-discard-modal, + oryx-picking-customer-note-modal { margin-inline-start: -12px; } diff --git a/libs/domain/picking/picking-header/stories/demo.stories.ts b/libs/domain/picking/picker-header/stories/demo.stories.ts similarity index 100% rename from libs/domain/picking/picking-header/stories/demo.stories.ts rename to libs/domain/picking/picker-header/stories/demo.stories.ts diff --git a/libs/domain/picking/picking-header/stories/static/variants.stories.ts b/libs/domain/picking/picker-header/stories/static/variants.stories.ts similarity index 100% rename from libs/domain/picking/picking-header/stories/static/variants.stories.ts rename to libs/domain/picking/picker-header/stories/static/variants.stories.ts diff --git a/libs/domain/picking/picker/index.ts b/libs/domain/picking/picker/index.ts new file mode 100644 index 0000000000..b245d0b192 --- /dev/null +++ b/libs/domain/picking/picker/index.ts @@ -0,0 +1,2 @@ +export * from './picker.component'; +export * from './picker.styles'; diff --git a/libs/domain/picking/picking/picking.component.spec.ts b/libs/domain/picking/picker/picker.component.spec.ts similarity index 94% rename from libs/domain/picking/picking/picking.component.spec.ts rename to libs/domain/picking/picker/picker.component.spec.ts index aa08ab5636..f15c205120 100644 --- a/libs/domain/picking/picking/picking.component.spec.ts +++ b/libs/domain/picking/picker/picker.component.spec.ts @@ -12,8 +12,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of } from 'rxjs'; import { beforeEach } from 'vitest'; -import { PickingComponent } from './picking.component'; -import { pickingComponent } from './picking.def'; +import { PickerComponent } from './picker.component'; +import { pickerComponent } from './picker.def'; class MockPickingListService implements Partial { get = vi.fn().mockReturnValue(of([mockPickingListData[0]])); @@ -32,7 +32,7 @@ class MockRouterService implements Partial { Element.prototype.scrollIntoView = vi.fn(); describe('PickingComponent', () => { - let element: PickingComponent; + let element: PickerComponent; let service: MockPickingListService; let routerService: MockRouterService; let pickingHeaderService: MockPickingHeaderService; @@ -53,7 +53,7 @@ describe('PickingComponent', () => { }; beforeAll(async () => { - await useComponent([pickingComponent, tabsComponent]); + await useComponent([pickerComponent, tabsComponent]); }); beforeEach(async () => { @@ -87,7 +87,7 @@ describe('PickingComponent', () => { ) as unknown as MockPickingHeaderService; element = await fixture( - html`` + html`` ); }); @@ -130,7 +130,7 @@ describe('PickingComponent', () => { service.get = vi.fn().mockReturnValue(of([])); element = await fixture( - html`` + html`` ); }); @@ -163,7 +163,7 @@ describe('PickingComponent', () => { .mockReturnValue(of(mockPickingListData[1])); element = await fixture( - html`` + html`` ); }); @@ -230,7 +230,7 @@ describe('PickingComponent', () => { .mockReturnValue(of(partiallyPickedPickingList)); element = await fixture( - html`` + html`` ); }); diff --git a/libs/domain/picking/picking/picking.component.ts b/libs/domain/picking/picker/picker.component.ts similarity index 96% rename from libs/domain/picking/picking/picking.component.ts rename to libs/domain/picking/picker/picker.component.ts index 0f41f1f2b0..03e91b5643 100644 --- a/libs/domain/picking/picking/picking.component.ts +++ b/libs/domain/picking/picker/picker.component.ts @@ -22,10 +22,10 @@ import { Ref, createRef, ref } from 'lit/directives/ref.js'; import { repeat } from 'lit/directives/repeat.js'; import { when } from 'lit/directives/when.js'; import { catchError, of, tap } from 'rxjs'; -import { PickingProductCardComponent } from '../picking-product-card'; -import { pickingComponentStyles } from './picking.styles'; +import { ProductCardComponent } from '../product-card'; +import { pickingComponentStyles } from './picker.styles'; -export class PickingComponent extends I18nMixin(PickingListMixin(LitElement)) { +export class PickerComponent extends I18nMixin(PickingListMixin(LitElement)) { static styles = pickingComponentStyles; protected routerService = resolve(RouterService); @@ -39,7 +39,7 @@ export class PickingComponent extends I18nMixin(PickingListMixin(LitElement)) { protected $items = computed(() => this.$pickingList()?.items); - protected productCardRef: Ref = createRef(); + protected productCardRef: Ref = createRef(); protected notPickedTabRef: Ref = createRef(); protected tabRefs: Ref[] = [ this.notPickedTabRef, @@ -175,9 +175,9 @@ export class PickingComponent extends I18nMixin(PickingListMixin(LitElement)) { const tabs = this.buildTabs(); return html` - + > import('./picker.component').then((m) => m.default), +}); diff --git a/libs/domain/picking/picking/picking.styles.ts b/libs/domain/picking/picker/picker.styles.ts similarity index 100% rename from libs/domain/picking/picking/picking.styles.ts rename to libs/domain/picking/picker/picker.styles.ts diff --git a/libs/domain/picking/picking-header/index.ts b/libs/domain/picking/picking-header/index.ts deleted file mode 100644 index e1de0a0ab7..0000000000 --- a/libs/domain/picking/picking-header/index.ts +++ /dev/null @@ -1 +0,0 @@ -export * from './picking-header.component'; diff --git a/libs/domain/picking/picking-header/picking-header.def.ts b/libs/domain/picking/picking-header/picking-header.def.ts deleted file mode 100644 index 0bcaa8404e..0000000000 --- a/libs/domain/picking/picking-header/picking-header.def.ts +++ /dev/null @@ -1,7 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingHeaderComponent = componentDef({ - name: 'oryx-picking-header', - impl: () => - import('./picking-header.component').then((m) => m.PickingHeaderComponent), -}); diff --git a/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts b/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts index 116a569b37..8bbb9232f4 100644 --- a/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts +++ b/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts @@ -13,7 +13,7 @@ describe('PickingInProgressModalComponent', () => { beforeEach(async () => { element = await fixture( - html`` + html`` ); }); diff --git a/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts b/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts index f2945e7c71..d3ae6d129b 100644 --- a/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts +++ b/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const pickingInProgressModalComponent = componentDef({ - name: 'oryx-picking-in-progress-modal', + name: 'oryx-picking-picking-in-progress-modal', impl: () => import('./picking-in-progress.component').then( (m) => m.PickingInProgressModalComponent diff --git a/libs/domain/picking/picking-in-progress/stories/demo.stories.ts b/libs/domain/picking/picking-in-progress/stories/demo.stories.ts index 7a83199341..fe187985c9 100644 --- a/libs/domain/picking/picking-in-progress/stories/demo.stories.ts +++ b/libs/domain/picking/picking-in-progress/stories/demo.stories.ts @@ -12,9 +12,9 @@ export default { } as Meta; const Template: Story = (): TemplateResult => { - return html` `; + > `; }; export const Demo = Template.bind({}); diff --git a/libs/domain/picking/picking-list-item/index.ts b/libs/domain/picking/picking-list-item/index.ts deleted file mode 100644 index 07bdf2aa44..0000000000 --- a/libs/domain/picking/picking-list-item/index.ts +++ /dev/null @@ -1,3 +0,0 @@ -export * from './picking-list-item.component'; -export * from './picking-list-item.model'; -export * from './picking-list-item.styles'; diff --git a/libs/domain/picking/picking-list-item/picking-list-item.def.ts b/libs/domain/picking/picking-list-item/picking-list-item.def.ts deleted file mode 100644 index d6049cef32..0000000000 --- a/libs/domain/picking/picking-list-item/picking-list-item.def.ts +++ /dev/null @@ -1,13 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingListItemComponent = componentDef({ - name: 'oryx-picking-list-item', - impl: () => - import('./picking-list-item.component').then( - (m) => m.PickingListItemComponent - ), - schema: () => - import('./picking-list-item.schema').then( - (m) => m.pickingListItemComponentSchema - ), -}); diff --git a/libs/domain/picking/picking-list-item/picking-list-item.model.ts b/libs/domain/picking/picking-list-item/picking-list-item.model.ts deleted file mode 100644 index e146e8f629..0000000000 --- a/libs/domain/picking/picking-list-item/picking-list-item.model.ts +++ /dev/null @@ -1,3 +0,0 @@ -export interface PickingListItemAttributes { - pickingListId?: string; -} diff --git a/libs/domain/picking/picking-list-item/picking-list-item.schema.ts b/libs/domain/picking/picking-list-item/picking-list-item.schema.ts deleted file mode 100644 index 83c6772e79..0000000000 --- a/libs/domain/picking/picking-list-item/picking-list-item.schema.ts +++ /dev/null @@ -1,8 +0,0 @@ -import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { PickingListItemComponent } from './picking-list-item.component'; - -export const pickingListItemComponentSchema: ContentComponentSchema = - { - name: 'Picking list item', - group: 'Picking', - }; diff --git a/libs/domain/picking/picking-lists-header/index.ts b/libs/domain/picking/picking-lists-header/index.ts deleted file mode 100644 index 3516ea0a57..0000000000 --- a/libs/domain/picking/picking-lists-header/index.ts +++ /dev/null @@ -1,2 +0,0 @@ -export * from './picking-lists-header.component'; -export * from './picking-lists-header.styles'; diff --git a/libs/domain/picking/picking-lists-header/picking-lists-header.def.ts b/libs/domain/picking/picking-lists-header/picking-lists-header.def.ts deleted file mode 100644 index 63e7cbfa1d..0000000000 --- a/libs/domain/picking/picking-lists-header/picking-lists-header.def.ts +++ /dev/null @@ -1,9 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingListsHeaderComponent = componentDef({ - name: 'oryx-picking-lists-header', - impl: () => - import('./picking-lists-header.component').then( - (m) => m.PickingListsHeaderComponent - ), -}); diff --git a/libs/domain/picking/picking-lists/index.ts b/libs/domain/picking/picking-lists/index.ts deleted file mode 100644 index d1c5c17633..0000000000 --- a/libs/domain/picking/picking-lists/index.ts +++ /dev/null @@ -1,3 +0,0 @@ -export * from './picking-lists.component'; -export * from './picking-lists.model'; -export * from './picking-lists.styles'; diff --git a/libs/domain/picking/picking-lists/picking-lists.def.ts b/libs/domain/picking/picking-lists/picking-lists.def.ts deleted file mode 100644 index 09af3304b2..0000000000 --- a/libs/domain/picking/picking-lists/picking-lists.def.ts +++ /dev/null @@ -1,9 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingListsComponent = componentDef({ - name: 'oryx-picking-lists', - impl: () => - import('./picking-lists.component').then((m) => m.PickingListsComponent), - schema: () => - import('./picking-lists.schema').then((m) => m.pickingListsComponentSchema), -}); diff --git a/libs/domain/picking/picking-lists/picking-lists.model.ts b/libs/domain/picking/picking-lists/picking-lists.model.ts deleted file mode 100644 index c83bd698e4..0000000000 --- a/libs/domain/picking/picking-lists/picking-lists.model.ts +++ /dev/null @@ -1,3 +0,0 @@ -export interface PickingListComponentProperties { - pickingListId?: string; -} diff --git a/libs/domain/picking/picking-lists/picking-lists.schema.ts b/libs/domain/picking/picking-lists/picking-lists.schema.ts deleted file mode 100644 index 2590657557..0000000000 --- a/libs/domain/picking/picking-lists/picking-lists.schema.ts +++ /dev/null @@ -1,8 +0,0 @@ -import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { PickingListsComponent } from './picking-lists.component'; - -export const pickingListsComponentSchema: ContentComponentSchema = - { - name: 'Picking lists', - group: 'Picking', - }; diff --git a/libs/domain/picking/picking-product-card/index.ts b/libs/domain/picking/picking-product-card/index.ts deleted file mode 100644 index c496c6902b..0000000000 --- a/libs/domain/picking/picking-product-card/index.ts +++ /dev/null @@ -1,2 +0,0 @@ -export * from './picking-product-card.component'; -export * from './picking-product-card.styles'; diff --git a/libs/domain/picking/picking-product-card/picking-product-card.def.ts b/libs/domain/picking/picking-product-card/picking-product-card.def.ts deleted file mode 100644 index 11463a6dde..0000000000 --- a/libs/domain/picking/picking-product-card/picking-product-card.def.ts +++ /dev/null @@ -1,13 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingProductCardComponent = componentDef({ - name: 'oryx-picking-product-card', - impl: () => - import('./picking-product-card.component').then( - (m) => m.PickingProductCardComponent - ), - schema: () => - import('./picking-product-card.schema').then( - (m) => m.pickingProductCardComponentSchema - ), -}); diff --git a/libs/domain/picking/picking-product-card/picking-product-card.schema.ts b/libs/domain/picking/picking-product-card/picking-product-card.schema.ts deleted file mode 100644 index ee6818aece..0000000000 --- a/libs/domain/picking/picking-product-card/picking-product-card.schema.ts +++ /dev/null @@ -1,8 +0,0 @@ -import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { PickingProductCardComponent } from './picking-product-card.component'; - -export const pickingProductCardComponentSchema: ContentComponentSchema = - { - name: 'Picking product card', - group: 'Picking', - }; diff --git a/libs/domain/picking/picking/index.ts b/libs/domain/picking/picking/index.ts deleted file mode 100644 index e9fb7f7f8d..0000000000 --- a/libs/domain/picking/picking/index.ts +++ /dev/null @@ -1,2 +0,0 @@ -export * from './picking.component'; -export * from './picking.styles'; diff --git a/libs/domain/picking/picking/picking.def.ts b/libs/domain/picking/picking/picking.def.ts deleted file mode 100644 index 60d05331e3..0000000000 --- a/libs/domain/picking/picking/picking.def.ts +++ /dev/null @@ -1,6 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingComponent = componentDef({ - name: 'oryx-picking', - impl: () => import('./picking.component').then((m) => m.default), -}); diff --git a/libs/domain/picking/product-card/index.ts b/libs/domain/picking/product-card/index.ts new file mode 100644 index 0000000000..01d504085f --- /dev/null +++ b/libs/domain/picking/product-card/index.ts @@ -0,0 +1,2 @@ +export * from './product-card.component'; +export * from './product-card.styles'; diff --git a/libs/domain/picking/picking-product-card/picking-product-card.component.spec.ts b/libs/domain/picking/product-card/product-card.component.spec.ts similarity index 96% rename from libs/domain/picking/picking-product-card/picking-product-card.component.spec.ts rename to libs/domain/picking/product-card/product-card.component.spec.ts index 59f4d7ef5c..767c0bc1c8 100644 --- a/libs/domain/picking/picking-product-card/picking-product-card.component.spec.ts +++ b/libs/domain/picking/product-card/product-card.component.spec.ts @@ -5,15 +5,15 @@ import { mockPickingListData } from '@spryker-oryx/picking/mocks'; import { ImageComponent } from '@spryker-oryx/ui/image'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { PickingProductCardComponent } from './picking-product-card.component'; -import { pickingProductCardComponent } from './picking-product-card.def'; +import { ProductCardComponent } from './product-card.component'; +import { productCardComponent } from './product-card.def'; describe('PickingProductCardComponent', () => { - let element: PickingProductCardComponent; + let element: ProductCardComponent; const productItem: PickingListItem = mockPickingListData[0].items[0]; beforeAll(async () => { - await useComponent(pickingProductCardComponent); + await useComponent(productCardComponent); }); afterEach(() => { diff --git a/libs/domain/picking/picking-product-card/picking-product-card.component.ts b/libs/domain/picking/product-card/product-card.component.ts similarity index 97% rename from libs/domain/picking/picking-product-card/picking-product-card.component.ts rename to libs/domain/picking/product-card/product-card.component.ts index 78d2fb695e..aa208ecea3 100644 --- a/libs/domain/picking/picking-product-card/picking-product-card.component.ts +++ b/libs/domain/picking/product-card/product-card.component.ts @@ -15,9 +15,9 @@ import { classMap } from 'lit/directives/class-map.js'; import { ifDefined } from 'lit/directives/if-defined.js'; import { Ref, createRef, ref } from 'lit/directives/ref.js'; import { when } from 'lit/directives/when.js'; -import { pickingProductCardComponentStyles } from './picking-product-card.styles'; +import { pickingProductCardComponentStyles } from './product-card.styles'; -export class PickingProductCardComponent extends I18nMixin(LitElement) { +export class ProductCardComponent extends I18nMixin(LitElement) { static styles = pickingProductCardComponentStyles; @property() productItem?: PickingListItem; diff --git a/libs/domain/picking/product-card/product-card.def.ts b/libs/domain/picking/product-card/product-card.def.ts new file mode 100644 index 0000000000..49fa9a6e7d --- /dev/null +++ b/libs/domain/picking/product-card/product-card.def.ts @@ -0,0 +1,9 @@ +import { componentDef } from '@spryker-oryx/utilities'; + +export const productCardComponent = componentDef({ + name: 'oryx-picking-product-card', + impl: () => + import('./product-card.component').then((m) => m.ProductCardComponent), + schema: () => + import('./product-card.schema').then((m) => m.productCardComponentSchema), +}); diff --git a/libs/domain/picking/product-card/product-card.schema.ts b/libs/domain/picking/product-card/product-card.schema.ts new file mode 100644 index 0000000000..34afe541d1 --- /dev/null +++ b/libs/domain/picking/product-card/product-card.schema.ts @@ -0,0 +1,8 @@ +import { ContentComponentSchema } from '@spryker-oryx/experience'; +import { ProductCardComponent } from './product-card.component'; + +export const productCardComponentSchema: ContentComponentSchema = + { + name: 'Product Card', + group: 'Picking', + }; diff --git a/libs/domain/picking/picking-product-card/picking-product-card.styles.ts b/libs/domain/picking/product-card/product-card.styles.ts similarity index 100% rename from libs/domain/picking/picking-product-card/picking-product-card.styles.ts rename to libs/domain/picking/product-card/product-card.styles.ts diff --git a/libs/domain/picking/src/components.ts b/libs/domain/picking/src/components.ts index 20d704b5ff..6a69a3104b 100644 --- a/libs/domain/picking/src/components.ts +++ b/libs/domain/picking/src/components.ts @@ -4,14 +4,14 @@ export * from '../discard-modal/discard-modal.def'; export * from '../filter-button/filter-button.def'; export * from '../filters/filters.def'; export * from '../header/header.def'; +export * from '../list-item/list-item.def'; +export * from '../lists-header/lists-header.def'; +export * from '../lists/lists.def'; export * from '../login/login.def'; export * from '../navigate-back/navigate-back.def'; -export * from '../picking-header/picking-header.def'; +export * from '../picker-header/picker-header.def'; +export * from '../picker/picker.def'; export * from '../picking-in-progress/picking-in-progress.def'; -export * from '../picking-list-item/picking-list-item.def'; -export * from '../picking-lists-header/picking-lists-header.def'; -export * from '../picking-lists/picking-lists.def'; -export * from '../picking-product-card/picking-product-card.def'; -export * from '../picking/picking.def'; +export * from '../product-card/product-card.def'; export * from '../user-profile/user-profile.def'; export * from '../warehouse-assignment/warehouse-assignment.def'; diff --git a/libs/domain/picking/src/feature.ts b/libs/domain/picking/src/feature.ts index 587cb1538b..c8d4331d21 100644 --- a/libs/domain/picking/src/feature.ts +++ b/libs/domain/picking/src/feature.ts @@ -13,15 +13,15 @@ import { filterButtonComponent, filtersComponent, headerComponent, + listItemComponent, + listsComponent, + listsHeaderComponent, loginPageComponent, navigateBackComponent, - pickingComponent, - pickingHeaderComponent, + pickerComponent, + pickerHeaderComponent, pickingInProgressModalComponent, - pickingListItemComponent, - pickingListsComponent, - pickingListsHeaderComponent, - pickingProductCardComponent, + productCardComponent, userProfileComponent, warehouseAssignmentComponent, } from './components'; @@ -53,14 +53,14 @@ export const pickingComponents = [ loginPageComponent, headerComponent, navigateBackComponent, - pickingListsComponent, - pickingListsHeaderComponent, - pickingListItemComponent, - pickingProductCardComponent, + listsComponent, + listsHeaderComponent, + listItemComponent, + productCardComponent, pickingInProgressModalComponent, - pickingComponent, + pickerComponent, userProfileComponent, - pickingHeaderComponent, + pickerHeaderComponent, warehouseAssignmentComponent, ]; diff --git a/libs/domain/picking/src/mixins/picking-list.mixin.ts b/libs/domain/picking/src/mixins/picking-list.mixin.ts index d9deb704d8..5528245c77 100644 --- a/libs/domain/picking/src/mixins/picking-list.mixin.ts +++ b/libs/domain/picking/src/mixins/picking-list.mixin.ts @@ -1,5 +1,5 @@ import { resolve } from '@spryker-oryx/di'; -import { PickingListComponentProperties } from '@spryker-oryx/picking/picking-lists'; +import { ListComponentProperties } from '@spryker-oryx/picking/lists'; import { Signal, Type, @@ -22,7 +22,7 @@ import type { PickingList } from '../models'; import { PickingListService } from '../services'; export declare class PickingListMixinInterface - implements PickingListComponentProperties + implements ListComponentProperties { protected pickingListService: PickingListService; pickingListId?: string; @@ -32,7 +32,7 @@ export declare class PickingListMixinInterface } export const PickingListMixin = < - T extends Type + T extends Type >( superClass: T ): Type & T => { diff --git a/libs/domain/picking/src/routes.ts b/libs/domain/picking/src/routes.ts index 8008eb272b..bcea153c0c 100644 --- a/libs/domain/picking/src/routes.ts +++ b/libs/domain/picking/src/routes.ts @@ -12,19 +12,27 @@ export const defaultPickingRoutes: RouteConfig[] = [ { path: '/warehouse-selection', render: () => - html``, + html``, }, { path: '/picking-list/picking/:id', render: ({ id }) => - html``, + html``, leave: (): Observable => resolve(PickingHeaderService).guardWithDialog(), }, { path: '/customer-note-info/:id', render: ({ id }) => html` - + `, }, ]; diff --git a/libs/domain/picking/warehouse-assignment/stories/demo.stories.ts b/libs/domain/picking/warehouse-assignment/stories/demo.stories.ts index 3f562e7497..b7db6c9a12 100644 --- a/libs/domain/picking/warehouse-assignment/stories/demo.stories.ts +++ b/libs/domain/picking/warehouse-assignment/stories/demo.stories.ts @@ -15,7 +15,9 @@ export default { } as Meta; const Template: Story = (): TemplateResult => { - return html` `; + return html` + + `; }; export const Demo = Template.bind({}); diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts index ff2963cd63..cbb5b37cf2 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts @@ -85,7 +85,7 @@ describe('WarehouseAssignmentComponent', () => { beforeEach(async () => { service.getList.mockReturnValue(of(mockWarehouseUserAssignments)); el = await fixture( - html`` + html`` ); }); @@ -100,7 +100,7 @@ describe('WarehouseAssignmentComponent', () => { }); it('should render header', () => { - expect(el).toContainElement('oryx-header'); + expect(el).toContainElement('oryx-picking-header'); }); mockWarehouseUserAssignments.forEach((item, index) => { @@ -140,7 +140,7 @@ describe('WarehouseAssignmentComponent', () => { of(mockWarehouseUserAssignments.slice(0, 1)) ); el = await fixture( - html`` + html`` ); }); @@ -164,7 +164,7 @@ describe('WarehouseAssignmentComponent', () => { of(mockWarehouseUserAssignments.slice(0, 0)) ); el = await fixture( - html`` + html`` ); }); diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts index 2425a232e1..d19b4463e0 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts @@ -32,7 +32,7 @@ export class WarehouseAssignmentComponent extends LitElement { protected override render(): TemplateResult { return html` - + ${when( this.$locations() === null || this.$locations()?.length === 1, () => this.renderLoading(), diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts index 97c8767954..6c5ee706ee 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const warehouseAssignmentComponent = componentDef({ - name: 'oryx-warehouse-assignment', + name: 'oryx-picking-warehouse-assignment', impl: () => import('./warehouse-assignment.component').then( (m) => m.WarehouseAssignmentComponent diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.styles.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.styles.ts index a91dcf2fa1..d16a1bf2a2 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.styles.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.styles.ts @@ -7,7 +7,7 @@ export const styles = css` background: var(--oryx-color-neutral-3); } - oryx-header { + oryx-picking-header { box-shadow: var(--oryx-elevation-2) var(--oryx-elevation-color-2); } diff --git a/libs/platform/auth/src/bapi/routes.ts b/libs/platform/auth/src/bapi/routes.ts index 2b18a5f0b2..8afab6c09e 100644 --- a/libs/platform/auth/src/bapi/routes.ts +++ b/libs/platform/auth/src/bapi/routes.ts @@ -8,7 +8,7 @@ export const defaultBapiRoutes = ( ): RouteConfig[] => [ { path: loginPath, - render: () => html``, + render: () => html``, }, { path: callbackPath, From a6f40586a0f7dc85e9aba18d2c945d9513b8815b Mon Sep 17 00:00:00 2001 From: aleespryker Date: Tue, 12 Sep 2023 16:30:00 +0200 Subject: [PATCH 02/16] chore: fix formatting --- apps/fulfillment-e2e/src/integration/lists.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/fulfillment-e2e/src/integration/lists.cy.ts b/apps/fulfillment-e2e/src/integration/lists.cy.ts index 1225836235..e597ac46eb 100644 --- a/apps/fulfillment-e2e/src/integration/lists.cy.ts +++ b/apps/fulfillment-e2e/src/integration/lists.cy.ts @@ -1,5 +1,5 @@ -import { ListsFragment } from '../support/page_fragments/lists.fragment'; import { ListsHeaderFragment } from '../support/page_fragments/lists-header.fragment'; +import { ListsFragment } from '../support/page_fragments/lists.fragment'; const listsFragment = new ListsFragment(); const headerFragment = new ListsHeaderFragment(); From 98c766bb6892b578a1ba06ca5e5b80210a4a6e94 Mon Sep 17 00:00:00 2001 From: aleespryker Date: Tue, 12 Sep 2023 16:32:28 +0200 Subject: [PATCH 03/16] chore: update tsconfig paths --- tsconfig.base.json | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/tsconfig.base.json b/tsconfig.base.json index e217ac6a5a..7d1f13b07d 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -124,30 +124,28 @@ ], "@spryker-oryx/picking/filters": ["libs/domain/picking/filters/index.ts"], "@spryker-oryx/picking/header": ["libs/domain/picking/header/index.ts"], + "@spryker-oryx/picking/list-item": [ + "libs/domain/picking/list-item/index.ts" + ], + "@spryker-oryx/picking/lists": ["libs/domain/picking/lists/index.ts"], + "@spryker-oryx/picking/lists-header": [ + "libs/domain/picking/lists-header/index.ts" + ], "@spryker-oryx/picking/login": ["libs/domain/picking/login/index.ts"], "@spryker-oryx/picking/mocks": ["libs/domain/picking/mocks/index.ts"], "@spryker-oryx/picking/navigate-back": [ "libs/domain/picking/navigate-back/index.ts" ], "@spryker-oryx/picking/offline": ["libs/domain/picking/offline/index.ts"], - "@spryker-oryx/picking/picking": ["libs/domain/picking/picking/index.ts"], - "@spryker-oryx/picking/picking-header": [ - "libs/domain/picking/picking-header/index.ts" + "@spryker-oryx/picking/picker": ["libs/domain/picking/picker/index.ts"], + "@spryker-oryx/picking/picker-header": [ + "libs/domain/picking/picker-header/index.ts" ], "@spryker-oryx/picking/picking-in-progress": [ "libs/domain/picking/picking-in-progress/index.ts" ], - "@spryker-oryx/picking/picking-list-item": [ - "libs/domain/picking/picking-list-item/index.ts" - ], - "@spryker-oryx/picking/picking-lists": [ - "libs/domain/picking/picking-lists/index.ts" - ], - "@spryker-oryx/picking/picking-lists-header": [ - "libs/domain/picking/picking-lists-header/index.ts" - ], - "@spryker-oryx/picking/picking-product-card": [ - "libs/domain/picking/picking-product-card/index.ts" + "@spryker-oryx/picking/product-card": [ + "libs/domain/picking/product-card/index.ts" ], "@spryker-oryx/picking/user-profile": [ "libs/domain/picking/user-profile/index.ts" From 8e0fb783d8688f5ca70c7b1fdc95154284d0e131 Mon Sep 17 00:00:00 2001 From: aleespryker Date: Tue, 12 Sep 2023 17:13:09 +0200 Subject: [PATCH 04/16] chore: fix storybook components --- libs/domain/picking/list-item/stories/demo.stories.ts | 10 +++++----- .../list-item/stories/static/variants.stories.ts | 10 +++++----- .../picking/lists-header/stories/demo.stories.ts | 2 +- .../lists-header/stories/static/variants.stories.ts | 2 +- libs/domain/picking/lists/stories/demo.stories.ts | 2 +- .../picking/lists/stories/static/data.stories.ts | 2 +- .../picking/lists/stories/static/empty.stories.ts | 2 +- .../picking/picker-header/stories/demo.stories.ts | 10 +++++----- .../picker-header/stories/static/variants.stories.ts | 10 ++++++---- 9 files changed, 26 insertions(+), 24 deletions(-) diff --git a/libs/domain/picking/list-item/stories/demo.stories.ts b/libs/domain/picking/list-item/stories/demo.stories.ts index ded0be1c72..4edafaa84b 100644 --- a/libs/domain/picking/list-item/stories/demo.stories.ts +++ b/libs/domain/picking/list-item/stories/demo.stories.ts @@ -3,12 +3,12 @@ import { Meta, Story } from '@storybook/web-components'; import { html } from 'lit'; import { TemplateResult } from 'lit/development'; import { storybookPrefix } from '../../.constants'; -import { PickingListItemAttributes } from '../picking-list-item.model'; +import { ListItemAttributes } from '../list-item.model'; const pickingListIds = mockPickingListData.map(({ id }) => id); export default { - title: `${storybookPrefix}/Picking list item`, + title: `${storybookPrefix}/List item`, args: { pickingListId: pickingListIds[0], }, @@ -25,13 +25,13 @@ export default { }, } as Meta; -const Template: Story = ({ +const Template: Story = ({ pickingListId, }): TemplateResult => { return html` - + > `; }; diff --git a/libs/domain/picking/list-item/stories/static/variants.stories.ts b/libs/domain/picking/list-item/stories/static/variants.stories.ts index 9cf0e73997..1e9354335a 100644 --- a/libs/domain/picking/list-item/stories/static/variants.stories.ts +++ b/libs/domain/picking/list-item/stories/static/variants.stories.ts @@ -4,7 +4,7 @@ import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../../.constants'; export default { - title: `${storybookPrefix}/Picking list item/Static`, + title: `${storybookPrefix}/List item/Static`, parameters: { chromatic: { viewports: [storybookDefaultViewports.mobile.min], @@ -15,14 +15,14 @@ export default { const Template: Story = (): TemplateResult => { return html`

With cart note

- + >

Without cart note

- + > `; }; diff --git a/libs/domain/picking/lists-header/stories/demo.stories.ts b/libs/domain/picking/lists-header/stories/demo.stories.ts index a7f7b6c14f..deda8d3e11 100644 --- a/libs/domain/picking/lists-header/stories/demo.stories.ts +++ b/libs/domain/picking/lists-header/stories/demo.stories.ts @@ -4,7 +4,7 @@ import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../.constants'; export default { - title: `${storybookPrefix}/Picking list header`, + title: `${storybookPrefix}/List header`, parameters: { layout: 'fullscreen', chromatic: { diff --git a/libs/domain/picking/lists-header/stories/static/variants.stories.ts b/libs/domain/picking/lists-header/stories/static/variants.stories.ts index f28275b7b7..9f9f1f3034 100644 --- a/libs/domain/picking/lists-header/stories/static/variants.stories.ts +++ b/libs/domain/picking/lists-header/stories/static/variants.stories.ts @@ -7,7 +7,7 @@ import { LitElement, TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../../.constants'; export default { - title: `${storybookPrefix}/Picking list header/Static`, + title: `${storybookPrefix}/List header/Static`, parameters: { layout: 'fullscreen', chromatic: { diff --git a/libs/domain/picking/lists/stories/demo.stories.ts b/libs/domain/picking/lists/stories/demo.stories.ts index 8f357fa019..a8164fbc77 100644 --- a/libs/domain/picking/lists/stories/demo.stories.ts +++ b/libs/domain/picking/lists/stories/demo.stories.ts @@ -8,7 +8,7 @@ import { TemplateResult } from 'lit/development'; import { storybookPrefix } from '../../.constants'; export default { - title: `${storybookPrefix}/Picking lists`, + title: `${storybookPrefix}/Lists`, parameters: { layout: 'fullscreen', chromatic: { diff --git a/libs/domain/picking/lists/stories/static/data.stories.ts b/libs/domain/picking/lists/stories/static/data.stories.ts index 441037a89f..165a36d45c 100644 --- a/libs/domain/picking/lists/stories/static/data.stories.ts +++ b/libs/domain/picking/lists/stories/static/data.stories.ts @@ -10,7 +10,7 @@ import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../../.constants'; export default { - title: `${storybookPrefix}/Picking lists/Static`, + title: `${storybookPrefix}/Lists/Static`, parameters: { layout: 'fullscreen', chromatic: { diff --git a/libs/domain/picking/lists/stories/static/empty.stories.ts b/libs/domain/picking/lists/stories/static/empty.stories.ts index b5350c9fd5..39288f5f17 100644 --- a/libs/domain/picking/lists/stories/static/empty.stories.ts +++ b/libs/domain/picking/lists/stories/static/empty.stories.ts @@ -10,7 +10,7 @@ import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../../.constants'; export default { - title: `${storybookPrefix}/Picking lists/Static`, + title: `${storybookPrefix}/Lists/Static`, parameters: { layout: 'fullscreen', chromatic: { diff --git a/libs/domain/picking/picker-header/stories/demo.stories.ts b/libs/domain/picking/picker-header/stories/demo.stories.ts index 98642fd78f..2081a7b80f 100644 --- a/libs/domain/picking/picker-header/stories/demo.stories.ts +++ b/libs/domain/picking/picker-header/stories/demo.stories.ts @@ -2,12 +2,12 @@ import { mockPickingListData } from '@spryker-oryx/picking/mocks'; import { Meta, Story } from '@storybook/web-components'; import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../.constants'; -import { PickingListItemAttributes } from '../../picking-list-item/picking-list-item.model'; +import { ListItemAttributes } from '../../list-item/list-item.model'; const pickingListIds = mockPickingListData.map(({ id }) => id); export default { - title: `${storybookPrefix}/Picking header`, + title: `${storybookPrefix}/Picker header`, parameters: { chromatic: { disableSnapshot: true, @@ -22,12 +22,12 @@ export default { }, } as Meta; -const Template: Story = ({ +const Template: Story = ({ pickingListId, }): TemplateResult => { - return html``; + >`; }; export const Demo = Template.bind({}); diff --git a/libs/domain/picking/picker-header/stories/static/variants.stories.ts b/libs/domain/picking/picker-header/stories/static/variants.stories.ts index ef40934074..c0a48535d3 100644 --- a/libs/domain/picking/picker-header/stories/static/variants.stories.ts +++ b/libs/domain/picking/picker-header/stories/static/variants.stories.ts @@ -7,7 +7,7 @@ import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../../.constants'; export default { - title: `${storybookPrefix}/Picking header/Static`, + title: `${storybookPrefix}/Picker header/Static`, decorators: [OverlaysDecorator(320, 568)], parameters: { chromatic: { @@ -18,12 +18,14 @@ export default { const Template: Story = (): TemplateResult => { return html`

With cart note

- +

Without cart note

- `; + >`; }; export const Variants = Template.bind({}); From 94e3fb51fc30bb035fdf44885719e6d4ccdfb48f Mon Sep 17 00:00:00 2001 From: aleespryker Date: Fri, 15 Sep 2023 16:43:55 +0200 Subject: [PATCH 05/16] chore: refactoring --- .../picking-in-progress-modal.fragment.ts | 2 +- .../customer-note-modal.component.spec.ts | 8 +-- .../customer-note-modal.component.ts | 2 +- .../customer-note-modal.def.ts | 4 +- .../customer-note.component.spec.ts | 10 +-- .../customer-note/customer-note.component.ts | 8 +-- .../customer-note/customer-note.def.ts | 6 +- .../discard-modal.component.spec.ts | 8 +-- .../discard-modal/discard-modal.component.ts | 2 +- .../discard-modal/discard-modal.def.ts | 6 +- .../filter-button.component.spec.ts | 8 +-- .../filter-button/filter-button.component.ts | 2 +- .../filter-button/filter-button.def.ts | 10 ++- .../filter-button/filter-button.schema.ts | 4 +- .../picking/filters/filters.component.spec.ts | 8 +-- .../picking/filters/filters.component.ts | 2 +- libs/domain/picking/filters/filters.def.ts | 5 +- libs/domain/picking/filters/filters.model.ts | 2 +- .../picking/header/header.component.spec.ts | 10 +-- .../domain/picking/header/header.component.ts | 4 +- libs/domain/picking/header/header.def.ts | 5 +- .../list-item/list-item.component.spec.ts | 8 +-- .../picking/list-item/list-item.component.ts | 6 +- .../domain/picking/list-item/list-item.def.ts | 7 +- .../picking/list-item/list-item.model.ts | 2 +- .../picking/list-item/list-item.schema.ts | 4 +- .../lists-header.component.spec.ts | 8 +-- .../lists-header/lists-header.component.ts | 2 +- .../picking/lists-header/lists-header.def.ts | 6 +- .../picking/lists/lists.component.spec.ts | 12 ++-- libs/domain/picking/lists/lists.component.ts | 6 +- libs/domain/picking/lists/lists.def.ts | 7 +- libs/domain/picking/lists/lists.model.ts | 2 +- libs/domain/picking/lists/lists.schema.ts | 11 ++-- .../picking/login/login.component.spec.ts | 8 +-- libs/domain/picking/login/login.component.ts | 4 +- libs/domain/picking/login/login.def.ts | 2 +- .../navigate-back.component.spec.ts | 8 +-- .../navigate-back/navigate-back.component.ts | 6 +- .../navigate-back/navigate-back.def.ts | 10 ++- .../navigate-back/navigate-back.model.ts | 2 +- .../navigate-back/navigate-back.schema.ts | 4 +- .../picker-header.component.spec.ts | 15 +++-- .../picker-header/picker-header.component.ts | 8 +-- .../picker-header/picker-header.def.ts | 6 +- .../picking/picker/picker.component.spec.ts | 8 +-- .../domain/picking/picker/picker.component.ts | 10 +-- libs/domain/picking/picker/picker.def.ts | 2 +- .../picking-in-progress.component.spec.ts | 2 +- .../picking-in-progress.def.ts | 2 +- .../stories/demo.stories.ts | 4 +- .../product-card.component.spec.ts | 8 +-- .../product-card/product-card.component.ts | 2 +- .../picking/product-card/product-card.def.ts | 6 +- .../product-card/product-card.schema.ts | 4 +- libs/domain/picking/src/feature.ts | 64 +++++++++---------- .../picking/src/mixins/picking-list.mixin.ts | 6 +- .../user-profile.component.spec.ts | 10 +-- .../user-profile/user-profile.component.ts | 2 +- .../picking/user-profile/user-profile.def.ts | 6 +- .../warehouse-assignment.component.spec.ts | 8 +-- .../warehouse-assignment.component.ts | 2 +- .../warehouse-assignment.def.ts | 4 +- 63 files changed, 224 insertions(+), 196 deletions(-) diff --git a/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts index 11ae35a44e..419d9c74cd 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/picking-in-progress-modal.fragment.ts @@ -1,5 +1,5 @@ export class PickingInProgressModalFragment { - getWrapper = () => cy.get('oryx-picking-picking-in-progress-modal'); + getWrapper = () => cy.get('oryx-picking-in-progress-modal'); getModal = () => this.getWrapper().find('oryx-modal'); getCloseButton = () => this.getWrapper().find('oryx-button').eq(0); getOverlay = () => this.getModal().find('dialog'); diff --git a/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts b/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts index edc53a92b0..a60ad404c9 100644 --- a/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts +++ b/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts @@ -3,17 +3,17 @@ import { CLOSE_EVENT, ModalComponent } from '@spryker-oryx/ui/modal'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { afterEach, beforeAll, beforeEach } from 'vitest'; -import { CustomerNoteModalComponent } from './customer-note-modal.component'; -import { customerNoteModalComponent } from './customer-note-modal.def'; +import { PickingCustomerNoteModalComponent } from './customer-note-modal.component'; +import { pickingCustomerNoteModalComponent } from './customer-note-modal.def'; describe('CustomerNoteModal', () => { - let element: CustomerNoteModalComponent; + let element: PickingCustomerNoteModalComponent; const getModal = (): ModalComponent | null => element.renderRoot.querySelector('oryx-modal'); beforeAll(async () => { - await useComponent([customerNoteModalComponent]); + await useComponent([pickingCustomerNoteModalComponent]); }); describe('when note property is not provided', () => { diff --git a/libs/domain/picking/customer-note-modal/customer-note-modal.component.ts b/libs/domain/picking/customer-note-modal/customer-note-modal.component.ts index efa8a5df4b..967ac1a6e7 100644 --- a/libs/domain/picking/customer-note-modal/customer-note-modal.component.ts +++ b/libs/domain/picking/customer-note-modal/customer-note-modal.component.ts @@ -5,7 +5,7 @@ import { I18nMixin } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { property } from 'lit/decorators.js'; -export class CustomerNoteModalComponent extends I18nMixin(LitElement) { +export class PickingCustomerNoteModalComponent extends I18nMixin(LitElement) { @property({ type: Boolean }) open?: boolean; protected close(): void { diff --git a/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts b/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts index fd4fb2b65e..b03f3de408 100644 --- a/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts +++ b/libs/domain/picking/customer-note-modal/customer-note-modal.def.ts @@ -1,9 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const customerNoteModalComponent = componentDef({ +export const pickingCustomerNoteModalComponent = componentDef({ name: 'oryx-picking-customer-note-modal', impl: () => import('./customer-note-modal.component').then( - (m) => m.CustomerNoteModalComponent + (m) => m.PickingCustomerNoteModalComponent ), }); diff --git a/libs/domain/picking/customer-note/customer-note.component.spec.ts b/libs/domain/picking/customer-note/customer-note.component.spec.ts index 28fa0f6a6d..cab59203fd 100644 --- a/libs/domain/picking/customer-note/customer-note.component.spec.ts +++ b/libs/domain/picking/customer-note/customer-note.component.spec.ts @@ -9,8 +9,8 @@ import { html } from 'lit'; import { of, throwError } from 'rxjs'; import { PickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.component'; import { pickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.def'; -import { CustomerNoteComponent } from './customer-note.component'; -import { customerNoteComponent } from './customer-note.def'; +import { PickingCustomerNoteComponent } from './customer-note.component'; +import { pickingCustomerNoteComponent } from './customer-note.def'; class MockRouterService implements Partial { navigate = vi.fn(); @@ -23,19 +23,19 @@ class MockPickingListService implements Partial { } describe('CustomerNoteComponent', () => { - let element: CustomerNoteComponent; + let element: PickingCustomerNoteComponent; let service: MockPickingListService; let routerService: MockRouterService; const getPickingInProgressModal = () => { return element.renderRoot.querySelector( - 'oryx-picking-picking-in-progress-modal' + 'oryx-picking-in-progress-modal' ) as PickingInProgressModalComponent; }; beforeAll(async () => { await useComponent([ - customerNoteComponent, + pickingCustomerNoteComponent, pickingInProgressModalComponent, modalComponent, ]); diff --git a/libs/domain/picking/customer-note/customer-note.component.ts b/libs/domain/picking/customer-note/customer-note.component.ts index a640092715..ea023979b6 100644 --- a/libs/domain/picking/customer-note/customer-note.component.ts +++ b/libs/domain/picking/customer-note/customer-note.component.ts @@ -8,14 +8,14 @@ import { catchError, of, tap } from 'rxjs'; import { PickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.component'; import { customerNoteComponentStyles } from './customer-note.styles'; -export class CustomerNoteComponent extends I18nMixin( +export class PickingCustomerNoteComponent extends I18nMixin( PickingListMixin(LitElement) ) { static styles = customerNoteComponentStyles; protected routerService = resolve(RouterService); - @query('oryx-picking-picking-in-progress-modal') + @query('oryx-picking-in-progress-modal') protected pickingInProgressModal!: PickingInProgressModalComponent; protected onProceed(): void { @@ -60,9 +60,9 @@ export class CustomerNoteComponent extends I18nMixin( @click=${this.onProceed} > - + > `; } diff --git a/libs/domain/picking/customer-note/customer-note.def.ts b/libs/domain/picking/customer-note/customer-note.def.ts index b51a9437d5..4a88217ae8 100644 --- a/libs/domain/picking/customer-note/customer-note.def.ts +++ b/libs/domain/picking/customer-note/customer-note.def.ts @@ -1,7 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const customerNoteComponent = componentDef({ +export const pickingCustomerNoteComponent = componentDef({ name: 'oryx-picking-customer-note', impl: () => - import('./customer-note.component').then((m) => m.CustomerNoteComponent), + import('./customer-note.component').then( + (m) => m.PickingCustomerNoteComponent + ), }); diff --git a/libs/domain/picking/discard-modal/discard-modal.component.spec.ts b/libs/domain/picking/discard-modal/discard-modal.component.spec.ts index 7db0a71d19..9de70d3dad 100644 --- a/libs/domain/picking/discard-modal/discard-modal.component.spec.ts +++ b/libs/domain/picking/discard-modal/discard-modal.component.spec.ts @@ -1,14 +1,14 @@ import { fixture } from '@open-wc/testing-helpers'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { DiscardModalComponent } from './discard-modal.component'; -import { discardModalComponent } from './discard-modal.def'; +import { PickingDiscardModalComponent } from './discard-modal.component'; +import { pickingDiscardModalComponent } from './discard-modal.def'; describe('DiscardModalComponent', () => { - let element: DiscardModalComponent; + let element: PickingDiscardModalComponent; beforeAll(async () => { - await useComponent(discardModalComponent); + await useComponent(pickingDiscardModalComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/discard-modal/discard-modal.component.ts b/libs/domain/picking/discard-modal/discard-modal.component.ts index 29b1e49ed3..ada05b52e2 100644 --- a/libs/domain/picking/discard-modal/discard-modal.component.ts +++ b/libs/domain/picking/discard-modal/discard-modal.component.ts @@ -5,7 +5,7 @@ import { LitElement, TemplateResult, html } from 'lit'; import { property } from 'lit/decorators.js'; import { discardModalStyles } from './discard-modal.styles'; -export class DiscardModalComponent extends I18nMixin(LitElement) { +export class PickingDiscardModalComponent extends I18nMixin(LitElement) { static styles = discardModalStyles; @property({ type: Boolean }) open?: boolean; diff --git a/libs/domain/picking/discard-modal/discard-modal.def.ts b/libs/domain/picking/discard-modal/discard-modal.def.ts index 383afd2155..e025c284f4 100644 --- a/libs/domain/picking/discard-modal/discard-modal.def.ts +++ b/libs/domain/picking/discard-modal/discard-modal.def.ts @@ -1,7 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const discardModalComponent = componentDef({ +export const pickingDiscardModalComponent = componentDef({ name: 'oryx-picking-discard-modal', impl: () => - import('./discard-modal.component').then((m) => m.DiscardModalComponent), + import('./discard-modal.component').then( + (m) => m.PickingDiscardModalComponent + ), }); diff --git a/libs/domain/picking/filter-button/filter-button.component.spec.ts b/libs/domain/picking/filter-button/filter-button.component.spec.ts index e86e59aca9..50785bee0b 100644 --- a/libs/domain/picking/filter-button/filter-button.component.spec.ts +++ b/libs/domain/picking/filter-button/filter-button.component.spec.ts @@ -8,19 +8,19 @@ import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of } from 'rxjs'; import { SpyInstance } from 'vitest'; -import { FilterButtonComponent } from './filter-button.component'; -import { filterButtonComponent } from './filter-button.def'; +import { PickingFilterButtonComponent } from './filter-button.component'; +import { pickingFilterButtonComponent } from './filter-button.def'; class MockPickingListService implements Partial { getSortingQualifier = vi.fn().mockReturnValue(of(defaultSortingQualifier)); } describe('FilterButtonComponent', () => { - let element: FilterButtonComponent; + let element: PickingFilterButtonComponent; let service: MockPickingListService; beforeAll(async () => { - await useComponent(filterButtonComponent); + await useComponent(pickingFilterButtonComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/filter-button/filter-button.component.ts b/libs/domain/picking/filter-button/filter-button.component.ts index 7bc11ae9fa..58e821722d 100644 --- a/libs/domain/picking/filter-button/filter-button.component.ts +++ b/libs/domain/picking/filter-button/filter-button.component.ts @@ -12,7 +12,7 @@ import { query } from 'lit/decorators.js'; import { map, tap } from 'rxjs'; @signalAware() -export class FilterButtonComponent extends I18nMixin(LitElement) { +export class PickingFilterButtonComponent extends I18nMixin(LitElement) { protected pickingListService = resolve(PickingListService); @query('oryx-picking-filters') protected filters?: HTMLElement; diff --git a/libs/domain/picking/filter-button/filter-button.def.ts b/libs/domain/picking/filter-button/filter-button.def.ts index f32451e105..5150721d65 100644 --- a/libs/domain/picking/filter-button/filter-button.def.ts +++ b/libs/domain/picking/filter-button/filter-button.def.ts @@ -1,9 +1,13 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const filterButtonComponent = componentDef({ +export const pickingFilterButtonComponent = componentDef({ name: 'oryx-picking-filter-button', impl: () => - import('./filter-button.component').then((m) => m.FilterButtonComponent), + import('./filter-button.component').then( + (m) => m.PickingFilterButtonComponent + ), schema: () => - import('./filter-button.schema').then((m) => m.filterButtonComponentSchema), + import('./filter-button.schema').then( + (m) => m.pickingFilterButtonComponentSchema + ), }); diff --git a/libs/domain/picking/filter-button/filter-button.schema.ts b/libs/domain/picking/filter-button/filter-button.schema.ts index cf68c98a76..3cc3d987d5 100644 --- a/libs/domain/picking/filter-button/filter-button.schema.ts +++ b/libs/domain/picking/filter-button/filter-button.schema.ts @@ -1,7 +1,7 @@ import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { FilterButtonComponent } from './filter-button.component'; +import { PickingFilterButtonComponent } from './filter-button.component'; -export const filterButtonComponentSchema: ContentComponentSchema = +export const pickingFilterButtonComponentSchema: ContentComponentSchema = { name: 'Filters', group: 'Picking', diff --git a/libs/domain/picking/filters/filters.component.spec.ts b/libs/domain/picking/filters/filters.component.spec.ts index 1dcb21ea04..55d5d2a0f9 100644 --- a/libs/domain/picking/filters/filters.component.spec.ts +++ b/libs/domain/picking/filters/filters.component.spec.ts @@ -9,8 +9,8 @@ import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of } from 'rxjs'; import { SpyInstance } from 'vitest'; -import { FiltersComponent } from './filters.component'; -import { filtersComponent } from './filters.def'; +import { PickingFiltersComponent } from './filters.component'; +import { pickingFiltersComponent } from './filters.def'; import { getFilterFields } from './filters.model'; class MockPickingListService implements Partial { @@ -23,12 +23,12 @@ class MockFormRenderer implements Partial { } describe('FiltersComponent', () => { - let element: FiltersComponent; + let element: PickingFiltersComponent; let service: MockPickingListService; let renderer: MockFormRenderer; beforeAll(async () => { - await useComponent(filtersComponent); + await useComponent(pickingFiltersComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/filters/filters.component.ts b/libs/domain/picking/filters/filters.component.ts index 411e7272e1..dcb6f4c9fa 100644 --- a/libs/domain/picking/filters/filters.component.ts +++ b/libs/domain/picking/filters/filters.component.ts @@ -14,7 +14,7 @@ import { map } from 'rxjs'; import { getFilterFields } from './filters.model'; import { filtersComponentStyles } from './filters.styles'; -export class FiltersComponent extends I18nMixin(LitElement) { +export class PickingFiltersComponent extends I18nMixin(LitElement) { static styles = filtersComponentStyles; @property({ type: Boolean, reflect: true }) open = false; diff --git a/libs/domain/picking/filters/filters.def.ts b/libs/domain/picking/filters/filters.def.ts index dd1eec4cfc..9185acf0f6 100644 --- a/libs/domain/picking/filters/filters.def.ts +++ b/libs/domain/picking/filters/filters.def.ts @@ -1,6 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const filtersComponent = componentDef({ +export const pickingFiltersComponent = componentDef({ name: 'oryx-picking-filters', - impl: () => import('./filters.component').then((m) => m.FiltersComponent), + impl: () => + import('./filters.component').then((m) => m.PickingFiltersComponent), }); diff --git a/libs/domain/picking/filters/filters.model.ts b/libs/domain/picking/filters/filters.model.ts index 5cbca034c9..b887e81ef4 100644 --- a/libs/domain/picking/filters/filters.model.ts +++ b/libs/domain/picking/filters/filters.model.ts @@ -1,7 +1,7 @@ import { FormFieldDefinition, FormFieldType } from '@spryker-oryx/form'; import { i18n } from '@spryker-oryx/utilities'; -export interface FiltersAttributes { +export interface PickingFiltersAttributes { open?: boolean; } diff --git a/libs/domain/picking/header/header.component.spec.ts b/libs/domain/picking/header/header.component.spec.ts index 519faebe77..95fa085adb 100644 --- a/libs/domain/picking/header/header.component.spec.ts +++ b/libs/domain/picking/header/header.component.spec.ts @@ -2,14 +2,14 @@ import { fixture } from '@open-wc/testing-helpers'; import { SiteNavigationItemComponent } from '@spryker-oryx/site/navigation-item'; import { IconTypes } from '@spryker-oryx/ui/icon'; import { i18n, useComponent } from '@spryker-oryx/utilities'; -import HeaderComponent from './header.component'; -import { headerComponent } from './header.def'; +import PickingHeaderComponent from './header.component'; +import { pickingHeaderComponent } from './header.def'; describe('Header Component', () => { - let element: HeaderComponent; + let element: PickingHeaderComponent; beforeAll(async () => { - await useComponent([headerComponent]); + await useComponent([pickingHeaderComponent]); }); beforeEach(async () => { @@ -17,7 +17,7 @@ describe('Header Component', () => { }); it('is defined', () => { - expect(element).toBeInstanceOf(HeaderComponent); + expect(element).toBeInstanceOf(PickingHeaderComponent); }); it('passes the a11y audit', async () => { diff --git a/libs/domain/picking/header/header.component.ts b/libs/domain/picking/header/header.component.ts index 058714ccf5..284ae04758 100644 --- a/libs/domain/picking/header/header.component.ts +++ b/libs/domain/picking/header/header.component.ts @@ -7,7 +7,7 @@ import { query } from 'lit/decorators.js'; import { styles } from './header.styles'; @signalAware() -export class HeaderComponent extends LitElement { +export class PickingHeaderComponent extends LitElement { static styles = styles; @query('oryx-site-navigation-item') @@ -36,4 +36,4 @@ export class HeaderComponent extends LitElement { } } -export default HeaderComponent; +export default PickingHeaderComponent; diff --git a/libs/domain/picking/header/header.def.ts b/libs/domain/picking/header/header.def.ts index 3e2fdee667..2ce0ae17e3 100644 --- a/libs/domain/picking/header/header.def.ts +++ b/libs/domain/picking/header/header.def.ts @@ -1,6 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const headerComponent = componentDef({ +export const pickingHeaderComponent = componentDef({ name: 'oryx-picking-header', - impl: () => import('./header.component').then((m) => m.HeaderComponent), + impl: () => + import('./header.component').then((m) => m.PickingHeaderComponent), }); diff --git a/libs/domain/picking/list-item/list-item.component.spec.ts b/libs/domain/picking/list-item/list-item.component.spec.ts index 38d12d0c16..7d343d4a23 100644 --- a/libs/domain/picking/list-item/list-item.component.spec.ts +++ b/libs/domain/picking/list-item/list-item.component.spec.ts @@ -8,8 +8,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of, throwError } from 'rxjs'; import { afterEach } from 'vitest'; -import { ListItemComponent } from './list-item.component'; -import { listItemComponent } from './list-item.def'; +import { PickingListItemComponent } from './list-item.component'; +import { pickingListItemComponent } from './list-item.def'; class MockRouterService implements Partial { navigate = vi.fn(); } @@ -25,13 +25,13 @@ class MockLocaleService implements Partial { } describe('PickingListItemComponent', () => { - let element: ListItemComponent; + let element: PickingListItemComponent; let service: MockPickingListService; let routerService: MockRouterService; let localeService: MockLocaleService; beforeAll(async () => { - await useComponent(listItemComponent); + await useComponent(pickingListItemComponent); }); beforeEach(() => { diff --git a/libs/domain/picking/list-item/list-item.component.ts b/libs/domain/picking/list-item/list-item.component.ts index 11a37f9e93..6a65b6a2b3 100644 --- a/libs/domain/picking/list-item/list-item.component.ts +++ b/libs/domain/picking/list-item/list-item.component.ts @@ -8,12 +8,12 @@ import { I18nMixin, computed } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { when } from 'lit/directives/when.js'; import { catchError, of, tap } from 'rxjs'; -import { ListItemAttributes } from './list-item.model'; +import { PickingListItemAttributes } from './list-item.model'; import { pickingListItemComponentStyles } from './list-item.styles'; -export class ListItemComponent +export class PickingListItemComponent extends I18nMixin(PickingListMixin(LitElement)) - implements ListItemAttributes + implements PickingListItemAttributes { static styles = pickingListItemComponentStyles; diff --git a/libs/domain/picking/list-item/list-item.def.ts b/libs/domain/picking/list-item/list-item.def.ts index e098f38edc..50dc8150ae 100644 --- a/libs/domain/picking/list-item/list-item.def.ts +++ b/libs/domain/picking/list-item/list-item.def.ts @@ -1,8 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const listItemComponent = componentDef({ +export const pickingListItemComponent = componentDef({ name: 'oryx-picking-list-item', - impl: () => import('./list-item.component').then((m) => m.ListItemComponent), + impl: () => + import('./list-item.component').then((m) => m.PickingListItemComponent), schema: () => - import('./list-item.schema').then((m) => m.listItemComponentSchema), + import('./list-item.schema').then((m) => m.pickingListItemComponentSchema), }); diff --git a/libs/domain/picking/list-item/list-item.model.ts b/libs/domain/picking/list-item/list-item.model.ts index f31c98a84d..e146e8f629 100644 --- a/libs/domain/picking/list-item/list-item.model.ts +++ b/libs/domain/picking/list-item/list-item.model.ts @@ -1,3 +1,3 @@ -export interface ListItemAttributes { +export interface PickingListItemAttributes { pickingListId?: string; } diff --git a/libs/domain/picking/list-item/list-item.schema.ts b/libs/domain/picking/list-item/list-item.schema.ts index b06cbf1a9c..831793b256 100644 --- a/libs/domain/picking/list-item/list-item.schema.ts +++ b/libs/domain/picking/list-item/list-item.schema.ts @@ -1,7 +1,7 @@ import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { ListItemComponent } from './list-item.component'; +import { PickingListItemComponent } from './list-item.component'; -export const listItemComponentSchema: ContentComponentSchema = +export const pickingListItemComponentSchema: ContentComponentSchema = { name: 'List Item', group: 'Picking', diff --git a/libs/domain/picking/lists-header/lists-header.component.spec.ts b/libs/domain/picking/lists-header/lists-header.component.spec.ts index 078ae327d2..66ed6e971a 100644 --- a/libs/domain/picking/lists-header/lists-header.component.spec.ts +++ b/libs/domain/picking/lists-header/lists-header.component.spec.ts @@ -5,8 +5,8 @@ import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import MockDate from 'mockdate'; import { of } from 'rxjs'; -import { ListsHeaderComponent } from './lists-header.component'; -import { listsHeaderComponent } from './lists-header.def'; +import { PickingListsHeaderComponent } from './lists-header.component'; +import { pickingListsHeaderComponent } from './lists-header.def'; const mockedDate = new Date(1970, 1, 1); const formattedDate = 'formattedDate'; @@ -16,11 +16,11 @@ class MockLocaleService implements Partial { } describe('PickingListsHeaderComponent', () => { - let element: ListsHeaderComponent; + let element: PickingListsHeaderComponent; let locateService: MockLocaleService; beforeAll(async () => { - await useComponent(listsHeaderComponent); + await useComponent(pickingListsHeaderComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/lists-header/lists-header.component.ts b/libs/domain/picking/lists-header/lists-header.component.ts index f786f859ac..2b40701b0d 100644 --- a/libs/domain/picking/lists-header/lists-header.component.ts +++ b/libs/domain/picking/lists-header/lists-header.component.ts @@ -5,7 +5,7 @@ import { I18nMixin, signal } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { pickingListsHeaderComponentStyles } from './lists-header.styles'; -export class ListsHeaderComponent extends I18nMixin(LitElement) { +export class PickingListsHeaderComponent extends I18nMixin(LitElement) { static styles = pickingListsHeaderComponentStyles; protected localeService = resolve(LocaleService); diff --git a/libs/domain/picking/lists-header/lists-header.def.ts b/libs/domain/picking/lists-header/lists-header.def.ts index 5cf12f2a9c..8cd0c3ba57 100644 --- a/libs/domain/picking/lists-header/lists-header.def.ts +++ b/libs/domain/picking/lists-header/lists-header.def.ts @@ -1,7 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const listsHeaderComponent = componentDef({ +export const pickingListsHeaderComponent = componentDef({ name: 'oryx-picking-lists-header', impl: () => - import('./lists-header.component').then((m) => m.ListsHeaderComponent), + import('./lists-header.component').then( + (m) => m.PickingListsHeaderComponent + ), }); diff --git a/libs/domain/picking/lists/lists.component.spec.ts b/libs/domain/picking/lists/lists.component.spec.ts index 0d4b3f3c18..34ff98a955 100644 --- a/libs/domain/picking/lists/lists.component.spec.ts +++ b/libs/domain/picking/lists/lists.component.spec.ts @@ -2,7 +2,7 @@ import { fixture } from '@open-wc/testing-helpers'; import { App, AppRef } from '@spryker-oryx/core'; import { createInjector, destroyInjector } from '@spryker-oryx/di'; import { PickingListService } from '@spryker-oryx/picking'; -import { CustomerNoteModalComponent } from '@spryker-oryx/picking/customer-note-modal'; +import { PickingCustomerNoteModalComponent } from '@spryker-oryx/picking/customer-note-modal'; import { mockPickingListData } from '@spryker-oryx/picking/mocks'; import { PickingSyncActionHandlerService } from '@spryker-oryx/picking/offline'; import { CLOSE_EVENT, ModalComponent } from '@spryker-oryx/ui/modal'; @@ -10,8 +10,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of } from 'rxjs'; import { afterEach, beforeAll, beforeEach } from 'vitest'; -import { ListsComponent } from './lists.component'; -import { listsComponent } from './lists.def'; +import { PickingListsComponent } from './lists.component'; +import { pickingListsComponent } from './lists.def'; const mockOfflineDataPlugin = { isRefreshing: vi.fn().mockReturnValue(of(false)), @@ -33,12 +33,12 @@ class MockPickingListService implements Partial { } describe('ListsComponent', () => { - let element: ListsComponent; + let element: PickingListsComponent; let service: MockPickingListService; let syncService: MockPickingSyncActionHandlerService; beforeAll(async () => { - await useComponent([listsComponent]); + await useComponent([pickingListsComponent]); }); beforeEach(async () => { @@ -110,7 +110,7 @@ describe('ListsComponent', () => { }); describe('when picking lists is not empty', () => { - const getCustomerNoteModal = (): CustomerNoteModalComponent | null => + const getCustomerNoteModal = (): PickingCustomerNoteModalComponent | null => element.renderRoot.querySelector('oryx-picking-customer-note-modal'); const getPickingInProgressModal = (): ModalComponent | null => diff --git a/libs/domain/picking/lists/lists.component.ts b/libs/domain/picking/lists/lists.component.ts index ee29fffb8c..f08fb03eaf 100644 --- a/libs/domain/picking/lists/lists.component.ts +++ b/libs/domain/picking/lists/lists.component.ts @@ -20,7 +20,7 @@ import { PickingInProgressModalComponent } from '../picking-in-progress/picking- import { pickingListsComponentStyles } from './lists.styles'; @signalAware() -export class ListsComponent extends I18nMixin(LitElement) { +export class PickingListsComponent extends I18nMixin(LitElement) { static styles = pickingListsComponentStyles; protected pickingListService = resolve(PickingListService); protected pickingSyncHandler = resolve(PickingSyncActionHandlerService); @@ -63,9 +63,9 @@ export class ListsComponent extends I18nMixin(LitElement) { protected override render(): TemplateResult { return html` ${this.renderPickingLists()} - + > import('./lists.component').then((m) => m.ListsComponent), - schema: () => import('./lists.schema').then((m) => m.listsComponentSchema), + impl: () => import('./lists.component').then((m) => m.PickingListsComponent), + schema: () => + import('./lists.schema').then((m) => m.pickingListsComponentSchema), }); diff --git a/libs/domain/picking/lists/lists.model.ts b/libs/domain/picking/lists/lists.model.ts index 655438d1f0..c83bd698e4 100644 --- a/libs/domain/picking/lists/lists.model.ts +++ b/libs/domain/picking/lists/lists.model.ts @@ -1,3 +1,3 @@ -export interface ListComponentProperties { +export interface PickingListComponentProperties { pickingListId?: string; } diff --git a/libs/domain/picking/lists/lists.schema.ts b/libs/domain/picking/lists/lists.schema.ts index 7fcbe89613..09ddb36c94 100644 --- a/libs/domain/picking/lists/lists.schema.ts +++ b/libs/domain/picking/lists/lists.schema.ts @@ -1,7 +1,8 @@ import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { ListsComponent } from './lists.component'; +import { PickingListsComponent } from './lists.component'; -export const listsComponentSchema: ContentComponentSchema = { - name: 'Lists', - group: 'Picking', -}; +export const pickingListsComponentSchema: ContentComponentSchema = + { + name: 'Lists', + group: 'Picking', + }; diff --git a/libs/domain/picking/login/login.component.spec.ts b/libs/domain/picking/login/login.component.spec.ts index 4da3dc0248..10ab29422f 100644 --- a/libs/domain/picking/login/login.component.spec.ts +++ b/libs/domain/picking/login/login.component.spec.ts @@ -1,14 +1,14 @@ import { fixture } from '@open-wc/testing-helpers'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { LoginPageComponent } from './login.component'; -import { loginPageComponent } from './login.def'; +import { PickingLoginPageComponent } from './login.component'; +import { pickingLoginPageComponent } from './login.def'; describe('LoginPageComponent', () => { - let element: LoginPageComponent; + let element: PickingLoginPageComponent; beforeAll(async () => { - await useComponent([loginPageComponent]); + await useComponent([pickingLoginPageComponent]); }); beforeEach(async () => { diff --git a/libs/domain/picking/login/login.component.ts b/libs/domain/picking/login/login.component.ts index a82d910941..459cf2e179 100644 --- a/libs/domain/picking/login/login.component.ts +++ b/libs/domain/picking/login/login.component.ts @@ -2,7 +2,7 @@ import { I18nMixin } from '@spryker-oryx/utilities'; import { html, LitElement, TemplateResult } from 'lit'; import { loginComponentStyles } from './login.styles'; -export class LoginPageComponent extends I18nMixin(LitElement) { +export class PickingLoginPageComponent extends I18nMixin(LitElement) { static styles = loginComponentStyles; protected override render(): TemplateResult { @@ -18,4 +18,4 @@ export class LoginPageComponent extends I18nMixin(LitElement) { } } -export default LoginPageComponent; +export default PickingLoginPageComponent; diff --git a/libs/domain/picking/login/login.def.ts b/libs/domain/picking/login/login.def.ts index d856102669..a95c15ff50 100644 --- a/libs/domain/picking/login/login.def.ts +++ b/libs/domain/picking/login/login.def.ts @@ -1,6 +1,6 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const loginPageComponent = componentDef({ +export const pickingLoginPageComponent = componentDef({ name: 'oryx-picking-login', impl: () => import('./login.component').then((m) => m.default), }); diff --git a/libs/domain/picking/navigate-back/navigate-back.component.spec.ts b/libs/domain/picking/navigate-back/navigate-back.component.spec.ts index 8db4fa3fc8..b0d6f7b8b9 100644 --- a/libs/domain/picking/navigate-back/navigate-back.component.spec.ts +++ b/libs/domain/picking/navigate-back/navigate-back.component.spec.ts @@ -2,14 +2,14 @@ import { fixture } from '@open-wc/testing-helpers'; import { destroyInjector } from '@spryker-oryx/di'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { NavigateBackComponent } from './navigate-back.component'; -import { navigateBackComponent } from './navigate-back.def'; +import { PickingNavigateBackComponent } from './navigate-back.component'; +import { pickingNavigateBackComponent } from './navigate-back.def'; describe('NavigateBackComponent', () => { - let element: NavigateBackComponent; + let element: PickingNavigateBackComponent; beforeAll(async () => { - await useComponent(navigateBackComponent); + await useComponent(pickingNavigateBackComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/navigate-back/navigate-back.component.ts b/libs/domain/picking/navigate-back/navigate-back.component.ts index 069c4a542a..7315c8c9c4 100644 --- a/libs/domain/picking/navigate-back/navigate-back.component.ts +++ b/libs/domain/picking/navigate-back/navigate-back.component.ts @@ -3,12 +3,12 @@ import { IconTypes } from '@spryker-oryx/ui/icon'; import { I18nMixin } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { property } from 'lit/decorators.js'; -import { NavigateBackAttributes } from './navigate-back.model'; +import { PickingNavigateBackAttributes } from './navigate-back.model'; import { navigateBackComponentStyles } from './navigate-back.styles'; -export class NavigateBackComponent +export class PickingNavigateBackComponent extends I18nMixin(LitElement) - implements NavigateBackAttributes + implements PickingNavigateBackAttributes { static styles = navigateBackComponentStyles; diff --git a/libs/domain/picking/navigate-back/navigate-back.def.ts b/libs/domain/picking/navigate-back/navigate-back.def.ts index cfb6a6a947..a5b0483df6 100644 --- a/libs/domain/picking/navigate-back/navigate-back.def.ts +++ b/libs/domain/picking/navigate-back/navigate-back.def.ts @@ -1,9 +1,13 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const navigateBackComponent = componentDef({ +export const pickingNavigateBackComponent = componentDef({ name: 'oryx-picking-navigate-back', impl: () => - import('./navigate-back.component').then((m) => m.NavigateBackComponent), + import('./navigate-back.component').then( + (m) => m.PickingNavigateBackComponent + ), schema: () => - import('./navigate-back.schema').then((m) => m.navigateBackComponentSchema), + import('./navigate-back.schema').then( + (m) => m.pickingNavigateBackComponentSchema + ), }); diff --git a/libs/domain/picking/navigate-back/navigate-back.model.ts b/libs/domain/picking/navigate-back/navigate-back.model.ts index 4e81bc5994..055069e728 100644 --- a/libs/domain/picking/navigate-back/navigate-back.model.ts +++ b/libs/domain/picking/navigate-back/navigate-back.model.ts @@ -1,3 +1,3 @@ -export interface NavigateBackAttributes { +export interface PickingNavigateBackAttributes { url?: string; } diff --git a/libs/domain/picking/navigate-back/navigate-back.schema.ts b/libs/domain/picking/navigate-back/navigate-back.schema.ts index b87374af97..0273190efd 100644 --- a/libs/domain/picking/navigate-back/navigate-back.schema.ts +++ b/libs/domain/picking/navigate-back/navigate-back.schema.ts @@ -1,7 +1,7 @@ import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { NavigateBackComponent } from './navigate-back.component'; +import { PickingNavigateBackComponent } from './navigate-back.component'; -export const navigateBackComponentSchema: ContentComponentSchema = +export const pickingNavigateBackComponentSchema: ContentComponentSchema = { name: 'Navigate back', group: 'Picking', diff --git a/libs/domain/picking/picker-header/picker-header.component.spec.ts b/libs/domain/picking/picker-header/picker-header.component.spec.ts index 8a70fb1396..f065c14157 100644 --- a/libs/domain/picking/picker-header/picker-header.component.spec.ts +++ b/libs/domain/picking/picker-header/picker-header.component.spec.ts @@ -10,9 +10,9 @@ import { BACK_EVENT, CLOSE_EVENT } from '@spryker-oryx/ui/modal'; import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { BehaviorSubject, of } from 'rxjs'; -import { discardModalComponent } from '../discard-modal/discard-modal.def'; -import { PickerHeaderComponent } from './picker-header.component'; -import { pickerHeaderComponent } from './picker-header.def'; +import { pickingDiscardModalComponent } from '../discard-modal/discard-modal.def'; +import { PickingPickerHeaderComponent } from './picker-header.component'; +import { pickingPickerHeaderComponent } from './picker-header.def'; class MockPickingListService implements Partial { get = vi.fn().mockReturnValue(of([mockPickingListData[0]])); @@ -32,13 +32,16 @@ class MockRouterService implements Partial { } describe('PickingHeaderComponent', () => { - let element: PickerHeaderComponent; + let element: PickingPickerHeaderComponent; let service: MockPickingListService; let routerService: MockRouterService; let pickingHeaderService: MockPickingHeaderService; beforeAll(async () => { - await useComponent([pickerHeaderComponent, discardModalComponent]); + await useComponent([ + pickingPickerHeaderComponent, + pickingDiscardModalComponent, + ]); }); beforeEach(async () => { @@ -91,7 +94,7 @@ describe('PickingHeaderComponent', () => { }); it('is defined', () => { - expect(element).toBeInstanceOf(PickerHeaderComponent); + expect(element).toBeInstanceOf(PickingPickerHeaderComponent); }); it('passes the a11y audit', async () => { diff --git a/libs/domain/picking/picker-header/picker-header.component.ts b/libs/domain/picking/picker-header/picker-header.component.ts index 21292aafa6..d478dcb631 100644 --- a/libs/domain/picking/picker-header/picker-header.component.ts +++ b/libs/domain/picking/picker-header/picker-header.component.ts @@ -1,6 +1,6 @@ import { resolve } from '@spryker-oryx/di'; import { PickingHeaderService, PickingListMixin } from '@spryker-oryx/picking'; -import { DiscardModalComponent } from '@spryker-oryx/picking/discard-modal'; +import { PickingDiscardModalComponent } from '@spryker-oryx/picking/discard-modal'; import { RouterService } from '@spryker-oryx/router'; import { ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; import { IconTypes } from '@spryker-oryx/ui/icon'; @@ -10,7 +10,7 @@ import { query, state } from 'lit/decorators.js'; import { tap } from 'rxjs'; import { styles } from './picker-header.styles'; -export class PickerHeaderComponent extends I18nMixin( +export class PickingPickerHeaderComponent extends I18nMixin( PickingListMixin(LitElement) ) { static styles = styles; @@ -19,7 +19,7 @@ export class PickerHeaderComponent extends I18nMixin( protected pickingHeaderService = resolve(PickingHeaderService); @query('oryx-picking-discard-modal') - protected discardModal?: DiscardModalComponent; + protected discardModal?: PickingDiscardModalComponent; @state() isCartNoteVisible?: boolean; @@ -92,4 +92,4 @@ export class PickerHeaderComponent extends I18nMixin( } } -export default PickerHeaderComponent; +export default PickingPickerHeaderComponent; diff --git a/libs/domain/picking/picker-header/picker-header.def.ts b/libs/domain/picking/picker-header/picker-header.def.ts index 93d71f69b5..10bbf497e6 100644 --- a/libs/domain/picking/picker-header/picker-header.def.ts +++ b/libs/domain/picking/picker-header/picker-header.def.ts @@ -1,7 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const pickerHeaderComponent = componentDef({ +export const pickingPickerHeaderComponent = componentDef({ name: 'oryx-picking-picker-header', impl: () => - import('./picker-header.component').then((m) => m.PickerHeaderComponent), + import('./picker-header.component').then( + (m) => m.PickingPickerHeaderComponent + ), }); diff --git a/libs/domain/picking/picker/picker.component.spec.ts b/libs/domain/picking/picker/picker.component.spec.ts index f15c205120..2ca725db83 100644 --- a/libs/domain/picking/picker/picker.component.spec.ts +++ b/libs/domain/picking/picker/picker.component.spec.ts @@ -12,8 +12,8 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of } from 'rxjs'; import { beforeEach } from 'vitest'; -import { PickerComponent } from './picker.component'; -import { pickerComponent } from './picker.def'; +import { PickingPickerComponent } from './picker.component'; +import { pickingPickerComponent } from './picker.def'; class MockPickingListService implements Partial { get = vi.fn().mockReturnValue(of([mockPickingListData[0]])); @@ -32,7 +32,7 @@ class MockRouterService implements Partial { Element.prototype.scrollIntoView = vi.fn(); describe('PickingComponent', () => { - let element: PickerComponent; + let element: PickingPickerComponent; let service: MockPickingListService; let routerService: MockRouterService; let pickingHeaderService: MockPickingHeaderService; @@ -53,7 +53,7 @@ describe('PickingComponent', () => { }; beforeAll(async () => { - await useComponent([pickerComponent, tabsComponent]); + await useComponent([pickingPickerComponent, tabsComponent]); }); beforeEach(async () => { diff --git a/libs/domain/picking/picker/picker.component.ts b/libs/domain/picking/picker/picker.component.ts index 03e91b5643..e8dbac6e03 100644 --- a/libs/domain/picking/picker/picker.component.ts +++ b/libs/domain/picking/picker/picker.component.ts @@ -22,10 +22,12 @@ import { Ref, createRef, ref } from 'lit/directives/ref.js'; import { repeat } from 'lit/directives/repeat.js'; import { when } from 'lit/directives/when.js'; import { catchError, of, tap } from 'rxjs'; -import { ProductCardComponent } from '../product-card'; +import { PickingProductCardComponent } from '../product-card'; import { pickingComponentStyles } from './picker.styles'; -export class PickerComponent extends I18nMixin(PickingListMixin(LitElement)) { +export class PickingPickerComponent extends I18nMixin( + PickingListMixin(LitElement) +) { static styles = pickingComponentStyles; protected routerService = resolve(RouterService); @@ -39,7 +41,7 @@ export class PickerComponent extends I18nMixin(PickingListMixin(LitElement)) { protected $items = computed(() => this.$pickingList()?.items); - protected productCardRef: Ref = createRef(); + protected productCardRef: Ref = createRef(); protected notPickedTabRef: Ref = createRef(); protected tabRefs: Ref[] = [ this.notPickedTabRef, @@ -385,4 +387,4 @@ export class PickerComponent extends I18nMixin(PickingListMixin(LitElement)) { } } -export default PickerComponent; +export default PickingPickerComponent; diff --git a/libs/domain/picking/picker/picker.def.ts b/libs/domain/picking/picker/picker.def.ts index 99e7e51935..b5d27416e7 100644 --- a/libs/domain/picking/picker/picker.def.ts +++ b/libs/domain/picking/picker/picker.def.ts @@ -1,6 +1,6 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const pickerComponent = componentDef({ +export const pickingPickerComponent = componentDef({ name: 'oryx-picking-picker', impl: () => import('./picker.component').then((m) => m.default), }); diff --git a/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts b/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts index 8bbb9232f4..116a569b37 100644 --- a/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts +++ b/libs/domain/picking/picking-in-progress/picking-in-progress.component.spec.ts @@ -13,7 +13,7 @@ describe('PickingInProgressModalComponent', () => { beforeEach(async () => { element = await fixture( - html`` + html`` ); }); diff --git a/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts b/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts index d3ae6d129b..f2945e7c71 100644 --- a/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts +++ b/libs/domain/picking/picking-in-progress/picking-in-progress.def.ts @@ -1,7 +1,7 @@ import { componentDef } from '@spryker-oryx/utilities'; export const pickingInProgressModalComponent = componentDef({ - name: 'oryx-picking-picking-in-progress-modal', + name: 'oryx-picking-in-progress-modal', impl: () => import('./picking-in-progress.component').then( (m) => m.PickingInProgressModalComponent diff --git a/libs/domain/picking/picking-in-progress/stories/demo.stories.ts b/libs/domain/picking/picking-in-progress/stories/demo.stories.ts index fe187985c9..7a83199341 100644 --- a/libs/domain/picking/picking-in-progress/stories/demo.stories.ts +++ b/libs/domain/picking/picking-in-progress/stories/demo.stories.ts @@ -12,9 +12,9 @@ export default { } as Meta; const Template: Story = (): TemplateResult => { - return html` `; + > `; }; export const Demo = Template.bind({}); diff --git a/libs/domain/picking/product-card/product-card.component.spec.ts b/libs/domain/picking/product-card/product-card.component.spec.ts index 767c0bc1c8..f612a91b6a 100644 --- a/libs/domain/picking/product-card/product-card.component.spec.ts +++ b/libs/domain/picking/product-card/product-card.component.spec.ts @@ -5,15 +5,15 @@ import { mockPickingListData } from '@spryker-oryx/picking/mocks'; import { ImageComponent } from '@spryker-oryx/ui/image'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { ProductCardComponent } from './product-card.component'; -import { productCardComponent } from './product-card.def'; +import { PickingProductCardComponent } from './product-card.component'; +import { pickingProductCardComponent } from './product-card.def'; describe('PickingProductCardComponent', () => { - let element: ProductCardComponent; + let element: PickingProductCardComponent; const productItem: PickingListItem = mockPickingListData[0].items[0]; beforeAll(async () => { - await useComponent(productCardComponent); + await useComponent(pickingProductCardComponent); }); afterEach(() => { diff --git a/libs/domain/picking/product-card/product-card.component.ts b/libs/domain/picking/product-card/product-card.component.ts index aa208ecea3..da6fa4ce2d 100644 --- a/libs/domain/picking/product-card/product-card.component.ts +++ b/libs/domain/picking/product-card/product-card.component.ts @@ -17,7 +17,7 @@ import { Ref, createRef, ref } from 'lit/directives/ref.js'; import { when } from 'lit/directives/when.js'; import { pickingProductCardComponentStyles } from './product-card.styles'; -export class ProductCardComponent extends I18nMixin(LitElement) { +export class PickingProductCardComponent extends I18nMixin(LitElement) { static styles = pickingProductCardComponentStyles; @property() productItem?: PickingListItem; diff --git a/libs/domain/picking/product-card/product-card.def.ts b/libs/domain/picking/product-card/product-card.def.ts index 49fa9a6e7d..6441da0e24 100644 --- a/libs/domain/picking/product-card/product-card.def.ts +++ b/libs/domain/picking/product-card/product-card.def.ts @@ -1,9 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const productCardComponent = componentDef({ +export const pickingProductCardComponent = componentDef({ name: 'oryx-picking-product-card', impl: () => - import('./product-card.component').then((m) => m.ProductCardComponent), + import('./product-card.component').then((m) => m.PickingProductCardComponent), schema: () => - import('./product-card.schema').then((m) => m.productCardComponentSchema), + import('./product-card.schema').then((m) => m.pickingProductCardComponentSchema), }); diff --git a/libs/domain/picking/product-card/product-card.schema.ts b/libs/domain/picking/product-card/product-card.schema.ts index 34afe541d1..b685cc200b 100644 --- a/libs/domain/picking/product-card/product-card.schema.ts +++ b/libs/domain/picking/product-card/product-card.schema.ts @@ -1,7 +1,7 @@ import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { ProductCardComponent } from './product-card.component'; +import { PickingProductCardComponent } from './product-card.component'; -export const productCardComponentSchema: ContentComponentSchema = +export const pickingProductCardComponentSchema: ContentComponentSchema = { name: 'Product Card', group: 'Picking', diff --git a/libs/domain/picking/src/feature.ts b/libs/domain/picking/src/feature.ts index c8d4331d21..23858c5cb0 100644 --- a/libs/domain/picking/src/feature.ts +++ b/libs/domain/picking/src/feature.ts @@ -7,23 +7,23 @@ import { Provider } from '@spryker-oryx/di'; import { provideLitRoutes } from '@spryker-oryx/router/lit'; import { ComponentsInfo } from '@spryker-oryx/utilities'; import { - customerNoteComponent, - customerNoteModalComponent, - discardModalComponent, - filterButtonComponent, - filtersComponent, - headerComponent, - listItemComponent, - listsComponent, - listsHeaderComponent, - loginPageComponent, - navigateBackComponent, - pickerComponent, - pickerHeaderComponent, + pickingCustomerNoteComponent, + pickingCustomerNoteModalComponent, + pickingDiscardModalComponent, + pickingFilterButtonComponent, + pickingFiltersComponent, + pickingHeaderComponent, pickingInProgressModalComponent, - productCardComponent, - userProfileComponent, - warehouseAssignmentComponent, + pickingListItemComponent, + pickingListsComponent, + pickingListsHeaderComponent, + pickingLoginPageComponent, + pickingNavigateBackComponent, + pickingPickerComponent, + pickingPickerHeaderComponent, + pickingProductCardComponent, + pickingUserProfileComponent, + pickingWarehouseAssignmentComponent, } from './components'; import { PickingConfig, providePickingConfig } from './config.provider'; import { defaultPickingRoutes } from './routes'; @@ -45,23 +45,23 @@ import { } from './services'; export const pickingComponents = [ - customerNoteComponent, - customerNoteModalComponent, - discardModalComponent, - filterButtonComponent, - filtersComponent, - loginPageComponent, - headerComponent, - navigateBackComponent, - listsComponent, - listsHeaderComponent, - listItemComponent, - productCardComponent, + pickingCustomerNoteComponent, + pickingCustomerNoteModalComponent, + pickingDiscardModalComponent, + pickingFilterButtonComponent, + pickingFiltersComponent, + pickingLoginPageComponent, + pickingHeaderComponent, + pickingNavigateBackComponent, + pickingListsComponent, + pickingListsHeaderComponent, + pickingListItemComponent, + pickingProductCardComponent, pickingInProgressModalComponent, - pickerComponent, - userProfileComponent, - pickerHeaderComponent, - warehouseAssignmentComponent, + pickingPickerComponent, + pickingUserProfileComponent, + pickingPickerHeaderComponent, + pickingWarehouseAssignmentComponent, ]; export interface PickingFeatureConfig extends PickingConfig { diff --git a/libs/domain/picking/src/mixins/picking-list.mixin.ts b/libs/domain/picking/src/mixins/picking-list.mixin.ts index 5528245c77..a827472f0e 100644 --- a/libs/domain/picking/src/mixins/picking-list.mixin.ts +++ b/libs/domain/picking/src/mixins/picking-list.mixin.ts @@ -1,5 +1,5 @@ import { resolve } from '@spryker-oryx/di'; -import { ListComponentProperties } from '@spryker-oryx/picking/lists'; +import { PickingListComponentProperties } from '@spryker-oryx/picking/lists'; import { Signal, Type, @@ -22,7 +22,7 @@ import type { PickingList } from '../models'; import { PickingListService } from '../services'; export declare class PickingListMixinInterface - implements ListComponentProperties + implements PickingListComponentProperties { protected pickingListService: PickingListService; pickingListId?: string; @@ -32,7 +32,7 @@ export declare class PickingListMixinInterface } export const PickingListMixin = < - T extends Type + T extends Type >( superClass: T ): Type & T => { diff --git a/libs/domain/picking/user-profile/user-profile.component.spec.ts b/libs/domain/picking/user-profile/user-profile.component.spec.ts index 5f31cefacb..88705b5a9d 100644 --- a/libs/domain/picking/user-profile/user-profile.component.spec.ts +++ b/libs/domain/picking/user-profile/user-profile.component.spec.ts @@ -7,8 +7,8 @@ import { RouterService } from '@spryker-oryx/router'; import { i18n, nextTick, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { catchError, of, switchMap, throwError } from 'rxjs'; -import { UserProfileComponent } from './user-profile.component'; -import { userProfileComponent } from './user-profile.def'; +import { PickingUserProfileComponent } from './user-profile.component'; +import { pickingUserProfileComponent } from './user-profile.def'; const mockOfflineDataPlugin = { refreshData: vi.fn().mockReturnValue( @@ -43,14 +43,14 @@ class MockStorageService implements Partial { } describe('UserProfileComponent', () => { - let element: UserProfileComponent; + let element: PickingUserProfileComponent; let routerService: MockRouterService; let syncSchedulerService: MockSyncSchedulerService; let authService: MockAuthService; let storageService: MockStorageService; beforeAll(async () => { - await useComponent(userProfileComponent); + await useComponent(pickingUserProfileComponent); }); beforeEach(async () => { @@ -107,7 +107,7 @@ describe('UserProfileComponent', () => { }); it('should be provided', () => { - expect(element).toBeInstanceOf(UserProfileComponent); + expect(element).toBeInstanceOf(PickingUserProfileComponent); }); it('should render its components', () => { diff --git a/libs/domain/picking/user-profile/user-profile.component.ts b/libs/domain/picking/user-profile/user-profile.component.ts index 0fdc035683..e3c2bcf354 100644 --- a/libs/domain/picking/user-profile/user-profile.component.ts +++ b/libs/domain/picking/user-profile/user-profile.component.ts @@ -24,7 +24,7 @@ import { import { userProfileComponentStyles } from './user-profile.styles'; @signalAware() -export class UserProfileComponent extends I18nMixin(LitElement) { +export class PickingUserProfileComponent extends I18nMixin(LitElement) { static styles = userProfileComponentStyles; protected routerService = resolve(RouterService); diff --git a/libs/domain/picking/user-profile/user-profile.def.ts b/libs/domain/picking/user-profile/user-profile.def.ts index 6703207d49..e2bdfe60fe 100644 --- a/libs/domain/picking/user-profile/user-profile.def.ts +++ b/libs/domain/picking/user-profile/user-profile.def.ts @@ -1,7 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const userProfileComponent = componentDef({ +export const pickingUserProfileComponent = componentDef({ name: 'oryx-picking-user-profile', impl: () => - import('./user-profile.component').then((m) => m.UserProfileComponent), + import('./user-profile.component').then( + (m) => m.PickingUserProfileComponent + ), }); diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts index cbb5b37cf2..4399b2eb2b 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts @@ -3,7 +3,7 @@ import { App, AppRef } from '@spryker-oryx/core'; import { createInjector, destroyInjector } from '@spryker-oryx/di'; import { WarehouseUserAssignmentsService, - warehouseAssignmentComponent, + pickingWarehouseAssignmentComponent, } from '@spryker-oryx/picking'; import { mockWarehouseUserAssignments } from '@spryker-oryx/picking/mocks'; import { RouterService } from '@spryker-oryx/router'; @@ -12,7 +12,7 @@ import { i18n, nextTick, useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of, switchMap } from 'rxjs'; import { beforeEach, vi } from 'vitest'; -import { WarehouseAssignmentComponent } from './warehouse-assignment.component'; +import { PickingWarehouseAssignmentComponent } from './warehouse-assignment.component'; const mockOfflineDataPlugin = { refreshData: vi.fn().mockReturnValue( @@ -43,13 +43,13 @@ class MockRouterService implements Partial { } describe('WarehouseAssignmentComponent', () => { - let el: WarehouseAssignmentComponent; + let el: PickingWarehouseAssignmentComponent; let service: MockWarehouseUserAssignmentsService; let routerService: RouterService; beforeAll(async () => { - await useComponent(warehouseAssignmentComponent); + await useComponent(pickingWarehouseAssignmentComponent); }); beforeEach(async () => { diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts index d19b4463e0..92566ca0ce 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.ts @@ -12,7 +12,7 @@ import { switchMap } from 'rxjs'; import { styles } from './warehouse-assignment.styles'; @signalAware() -export class WarehouseAssignmentComponent extends LitElement { +export class PickingWarehouseAssignmentComponent extends LitElement { static styles = styles; protected warehouseUserAssignmentsService = resolve( diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts index 6c5ee706ee..3970ac7a5a 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.def.ts @@ -1,9 +1,9 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const warehouseAssignmentComponent = componentDef({ +export const pickingWarehouseAssignmentComponent = componentDef({ name: 'oryx-picking-warehouse-assignment', impl: () => import('./warehouse-assignment.component').then( - (m) => m.WarehouseAssignmentComponent + (m) => m.PickingWarehouseAssignmentComponent ), }); From b38b8b9d2252242dc1d5e5d0f7f061671f9024df Mon Sep 17 00:00:00 2001 From: aleespryker Date: Fri, 15 Sep 2023 16:47:03 +0200 Subject: [PATCH 06/16] chore: fix formatting --- libs/domain/picking/product-card/product-card.def.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libs/domain/picking/product-card/product-card.def.ts b/libs/domain/picking/product-card/product-card.def.ts index 6441da0e24..86c88d2779 100644 --- a/libs/domain/picking/product-card/product-card.def.ts +++ b/libs/domain/picking/product-card/product-card.def.ts @@ -3,7 +3,11 @@ import { componentDef } from '@spryker-oryx/utilities'; export const pickingProductCardComponent = componentDef({ name: 'oryx-picking-product-card', impl: () => - import('./product-card.component').then((m) => m.PickingProductCardComponent), + import('./product-card.component').then( + (m) => m.PickingProductCardComponent + ), schema: () => - import('./product-card.schema').then((m) => m.pickingProductCardComponentSchema), + import('./product-card.schema').then( + (m) => m.pickingProductCardComponentSchema + ), }); From a19d6eb21967920433cae0bdd62cb0656837ae7b Mon Sep 17 00:00:00 2001 From: aleespryker <94365900+aleespryker@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:31:48 +0200 Subject: [PATCH 07/16] chore(picking): fix picking imports (#764) closes: [HRZ-89743](https://spryker.atlassian.net/browse/HRZ-89743) [HRZ-89743]: https://spryker.atlassian.net/browse/HRZ-89743?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- .../customer-note/customer-note.component.spec.ts | 9 ++++++--- .../picking/customer-note/customer-note.component.ts | 2 +- libs/domain/picking/lists/lists.component.ts | 2 +- .../domain/picking/picker-header/stories/demo.stories.ts | 2 +- libs/domain/picking/picker/picker.component.ts | 2 +- 5 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libs/domain/picking/customer-note/customer-note.component.spec.ts b/libs/domain/picking/customer-note/customer-note.component.spec.ts index cab59203fd..1827da6d87 100644 --- a/libs/domain/picking/customer-note/customer-note.component.spec.ts +++ b/libs/domain/picking/customer-note/customer-note.component.spec.ts @@ -1,14 +1,17 @@ import { fixture } from '@open-wc/testing-helpers'; import { createInjector, destroyInjector } from '@spryker-oryx/di'; -import { PickingListError, PickingListService } from '@spryker-oryx/picking'; +import { + PickingListError, + PickingListService, + pickingInProgressModalComponent, +} from '@spryker-oryx/picking'; import { mockPickingListData } from '@spryker-oryx/picking/mocks'; +import { PickingInProgressModalComponent } from '@spryker-oryx/picking/picking-in-progress'; import { RouterService } from '@spryker-oryx/router'; import { modalComponent } from '@spryker-oryx/ui/modal'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; import { of, throwError } from 'rxjs'; -import { PickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.component'; -import { pickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.def'; import { PickingCustomerNoteComponent } from './customer-note.component'; import { pickingCustomerNoteComponent } from './customer-note.def'; diff --git a/libs/domain/picking/customer-note/customer-note.component.ts b/libs/domain/picking/customer-note/customer-note.component.ts index ea023979b6..4d32aea792 100644 --- a/libs/domain/picking/customer-note/customer-note.component.ts +++ b/libs/domain/picking/customer-note/customer-note.component.ts @@ -1,11 +1,11 @@ import { resolve } from '@spryker-oryx/di'; import { PickingListMixin } from '@spryker-oryx/picking'; +import { PickingInProgressModalComponent } from '@spryker-oryx/picking/picking-in-progress'; import { RouterService } from '@spryker-oryx/router'; import { I18nMixin } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { query } from 'lit/decorators.js'; import { catchError, of, tap } from 'rxjs'; -import { PickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.component'; import { customerNoteComponentStyles } from './customer-note.styles'; export class PickingCustomerNoteComponent extends I18nMixin( diff --git a/libs/domain/picking/lists/lists.component.ts b/libs/domain/picking/lists/lists.component.ts index f08fb03eaf..18909eea6e 100644 --- a/libs/domain/picking/lists/lists.component.ts +++ b/libs/domain/picking/lists/lists.component.ts @@ -9,6 +9,7 @@ import { OfflineDataPlugin, PickingSyncActionHandlerService, } from '@spryker-oryx/picking/offline'; +import { PickingInProgressModalComponent } from '@spryker-oryx/picking/picking-in-progress'; import { I18nMixin, i18n, signal, signalAware } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { state } from 'lit/decorators.js'; @@ -16,7 +17,6 @@ import { createRef, ref } from 'lit/directives/ref.js'; import { repeat } from 'lit/directives/repeat.js'; import { when } from 'lit/directives/when.js'; import { Subject, distinctUntilChanged, map, startWith, switchMap } from 'rxjs'; -import { PickingInProgressModalComponent } from '../picking-in-progress/picking-in-progress.component'; import { pickingListsComponentStyles } from './lists.styles'; @signalAware() diff --git a/libs/domain/picking/picker-header/stories/demo.stories.ts b/libs/domain/picking/picker-header/stories/demo.stories.ts index 2081a7b80f..5925389f8c 100644 --- a/libs/domain/picking/picker-header/stories/demo.stories.ts +++ b/libs/domain/picking/picker-header/stories/demo.stories.ts @@ -1,8 +1,8 @@ +import { ListItemAttributes } from '@spryker-oryx/picking/list-item'; import { mockPickingListData } from '@spryker-oryx/picking/mocks'; import { Meta, Story } from '@storybook/web-components'; import { TemplateResult, html } from 'lit'; import { storybookPrefix } from '../../.constants'; -import { ListItemAttributes } from '../../list-item/list-item.model'; const pickingListIds = mockPickingListData.map(({ id }) => id); diff --git a/libs/domain/picking/picker/picker.component.ts b/libs/domain/picking/picker/picker.component.ts index e8dbac6e03..ff5d91e987 100644 --- a/libs/domain/picking/picker/picker.component.ts +++ b/libs/domain/picking/picker/picker.component.ts @@ -9,6 +9,7 @@ import { PickingTab, ProductItemPickedEvent, } from '@spryker-oryx/picking'; +import { PickingProductCardComponent } from '@spryker-oryx/picking/product-card'; import { RouterService } from '@spryker-oryx/router'; import { ButtonColor, ButtonType } from '@spryker-oryx/ui/button'; import { ChipComponent } from '@spryker-oryx/ui/chip'; @@ -22,7 +23,6 @@ import { Ref, createRef, ref } from 'lit/directives/ref.js'; import { repeat } from 'lit/directives/repeat.js'; import { when } from 'lit/directives/when.js'; import { catchError, of, tap } from 'rxjs'; -import { PickingProductCardComponent } from '../product-card'; import { pickingComponentStyles } from './picker.styles'; export class PickingPickerComponent extends I18nMixin( From d3566f45b34ab88d3c569441f38455153584d535 Mon Sep 17 00:00:00 2001 From: aleespryker <94365900+aleespryker@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:32:06 +0200 Subject: [PATCH 08/16] chore(picking): remove navigate back component (#769) closes: [HRZ-89744](https://spryker.atlassian.net/browse/HRZ-89744) [HRZ-89744]: https://spryker.atlassian.net/browse/HRZ-89744?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- .../page_fragments/customer-note.fragment.ts | 5 +- .../customer-note.component.spec.ts | 8 ++- .../customer-note/customer-note.component.ts | 11 +++- .../customer-note/customer-note.styles.ts | 2 +- libs/domain/picking/navigate-back/index.ts | 3 -- .../navigate-back.component.spec.ts | 51 ------------------- .../navigate-back/navigate-back.component.ts | 30 ----------- .../navigate-back/navigate-back.def.ts | 13 ----- .../navigate-back/navigate-back.model.ts | 3 -- .../navigate-back/navigate-back.schema.ts | 8 --- .../navigate-back/navigate-back.styles.ts | 8 --- .../navigate-back/stories/demo.stories.ts | 26 ---------- libs/domain/picking/src/components.ts | 1 - libs/domain/picking/src/feature.ts | 2 - tsconfig.base.json | 3 -- 15 files changed, 19 insertions(+), 155 deletions(-) delete mode 100644 libs/domain/picking/navigate-back/index.ts delete mode 100644 libs/domain/picking/navigate-back/navigate-back.component.spec.ts delete mode 100644 libs/domain/picking/navigate-back/navigate-back.component.ts delete mode 100644 libs/domain/picking/navigate-back/navigate-back.def.ts delete mode 100644 libs/domain/picking/navigate-back/navigate-back.model.ts delete mode 100644 libs/domain/picking/navigate-back/navigate-back.schema.ts delete mode 100644 libs/domain/picking/navigate-back/navigate-back.styles.ts delete mode 100644 libs/domain/picking/navigate-back/stories/demo.stories.ts diff --git a/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts b/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts index 510b85dd19..75485f227e 100644 --- a/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts +++ b/apps/fulfillment-e2e/src/support/page_fragments/customer-note.fragment.ts @@ -4,9 +4,8 @@ export class CustomerNoteFragment { getWrapper = () => cy.get('oryx-picking-customer-note'); getHeadline = () => this.getWrapper().find('oryx-heading'); getIllustration = () => this.getWrapper().find('oryx-image'); - getNavigateBackButton = () => - this.getWrapper().find('oryx-picking-navigate-back'); + getNavigateBackButton = () => this.getWrapper().find('oryx-button').eq(0); getNote = () => this.getWrapper().find('p'); - getProceedToPickingButton = () => this.getWrapper().find('oryx-button').eq(0); + getProceedToPickingButton = () => this.getWrapper().find('oryx-button').eq(1); pickingInProgressModal = new PickingInProgressModalFragment(); } diff --git a/libs/domain/picking/customer-note/customer-note.component.spec.ts b/libs/domain/picking/customer-note/customer-note.component.spec.ts index 1827da6d87..11d9c8141e 100644 --- a/libs/domain/picking/customer-note/customer-note.component.spec.ts +++ b/libs/domain/picking/customer-note/customer-note.component.spec.ts @@ -88,7 +88,9 @@ describe('CustomerNoteComponent', () => { describe('when picking is proceed', () => { beforeEach(() => { - element.renderRoot.querySelector('oryx-button')?.click(); + element.renderRoot + .querySelectorAll('oryx-button')?.[1] + ?.click(); }); it('should start picking with current picking list', () => { @@ -118,7 +120,9 @@ describe('CustomerNoteComponent', () => { >` ); - element.renderRoot.querySelector('oryx-button')?.click(); + element.renderRoot + .querySelectorAll('oryx-button')[1] + ?.click(); }); it('should not navigate route', () => { diff --git a/libs/domain/picking/customer-note/customer-note.component.ts b/libs/domain/picking/customer-note/customer-note.component.ts index 4d32aea792..b3dbed9d12 100644 --- a/libs/domain/picking/customer-note/customer-note.component.ts +++ b/libs/domain/picking/customer-note/customer-note.component.ts @@ -2,6 +2,8 @@ import { resolve } from '@spryker-oryx/di'; import { PickingListMixin } from '@spryker-oryx/picking'; import { PickingInProgressModalComponent } from '@spryker-oryx/picking/picking-in-progress'; import { RouterService } from '@spryker-oryx/router'; +import { ButtonColor, ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; +import { IconTypes } from '@spryker-oryx/ui/icon'; import { I18nMixin } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { query } from 'lit/decorators.js'; @@ -45,7 +47,14 @@ export class PickingCustomerNoteComponent extends I18nMixin( protected override render(): TemplateResult { return html`
- +

${this.i18n('picking.customer-note')}

diff --git a/libs/domain/picking/customer-note/customer-note.styles.ts b/libs/domain/picking/customer-note/customer-note.styles.ts index f36e7a9874..84fff271ec 100644 --- a/libs/domain/picking/customer-note/customer-note.styles.ts +++ b/libs/domain/picking/customer-note/customer-note.styles.ts @@ -17,7 +17,7 @@ export const customerNoteComponentStyles = css` flex-direction: column; } - oryx-picking-navigate-back { + section oryx-button { align-self: flex-start; margin-block-end: 40px; } diff --git a/libs/domain/picking/navigate-back/index.ts b/libs/domain/picking/navigate-back/index.ts deleted file mode 100644 index 489056ba9c..0000000000 --- a/libs/domain/picking/navigate-back/index.ts +++ /dev/null @@ -1,3 +0,0 @@ -export * from './navigate-back.component'; -export * from './navigate-back.model'; -export * from './navigate-back.styles'; diff --git a/libs/domain/picking/navigate-back/navigate-back.component.spec.ts b/libs/domain/picking/navigate-back/navigate-back.component.spec.ts deleted file mode 100644 index b0d6f7b8b9..0000000000 --- a/libs/domain/picking/navigate-back/navigate-back.component.spec.ts +++ /dev/null @@ -1,51 +0,0 @@ -import { fixture } from '@open-wc/testing-helpers'; -import { destroyInjector } from '@spryker-oryx/di'; -import { useComponent } from '@spryker-oryx/utilities'; -import { html } from 'lit'; -import { PickingNavigateBackComponent } from './navigate-back.component'; -import { pickingNavigateBackComponent } from './navigate-back.def'; - -describe('NavigateBackComponent', () => { - let element: PickingNavigateBackComponent; - - beforeAll(async () => { - await useComponent(pickingNavigateBackComponent); - }); - - beforeEach(async () => { - element = await fixture( - html`` - ); - }); - - afterEach(() => { - destroyInjector(); - vi.clearAllMocks(); - }); - - describe('when there is no url provided', () => { - it('should use default url', () => { - expect(element.renderRoot.querySelector('oryx-button')).toHaveProperty( - 'href', - '/' - ); - }); - }); - - describe('when url prop is provided', () => { - const url = '/url'; - - beforeEach(async () => { - element = await fixture(html``); - }); - - it('should build the url based on provided url', () => { - expect(element.renderRoot.querySelector('oryx-button')).toHaveProperty( - 'href', - url - ); - }); - }); -}); diff --git a/libs/domain/picking/navigate-back/navigate-back.component.ts b/libs/domain/picking/navigate-back/navigate-back.component.ts deleted file mode 100644 index 7315c8c9c4..0000000000 --- a/libs/domain/picking/navigate-back/navigate-back.component.ts +++ /dev/null @@ -1,30 +0,0 @@ -import { ButtonColor, ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; -import { IconTypes } from '@spryker-oryx/ui/icon'; -import { I18nMixin } from '@spryker-oryx/utilities'; -import { LitElement, TemplateResult, html } from 'lit'; -import { property } from 'lit/decorators.js'; -import { PickingNavigateBackAttributes } from './navigate-back.model'; -import { navigateBackComponentStyles } from './navigate-back.styles'; - -export class PickingNavigateBackComponent - extends I18nMixin(LitElement) - implements PickingNavigateBackAttributes -{ - static styles = navigateBackComponentStyles; - - @property() - url = '/'; - - protected override render(): TemplateResult { - return html` - - `; - } -} diff --git a/libs/domain/picking/navigate-back/navigate-back.def.ts b/libs/domain/picking/navigate-back/navigate-back.def.ts deleted file mode 100644 index a5b0483df6..0000000000 --- a/libs/domain/picking/navigate-back/navigate-back.def.ts +++ /dev/null @@ -1,13 +0,0 @@ -import { componentDef } from '@spryker-oryx/utilities'; - -export const pickingNavigateBackComponent = componentDef({ - name: 'oryx-picking-navigate-back', - impl: () => - import('./navigate-back.component').then( - (m) => m.PickingNavigateBackComponent - ), - schema: () => - import('./navigate-back.schema').then( - (m) => m.pickingNavigateBackComponentSchema - ), -}); diff --git a/libs/domain/picking/navigate-back/navigate-back.model.ts b/libs/domain/picking/navigate-back/navigate-back.model.ts deleted file mode 100644 index 055069e728..0000000000 --- a/libs/domain/picking/navigate-back/navigate-back.model.ts +++ /dev/null @@ -1,3 +0,0 @@ -export interface PickingNavigateBackAttributes { - url?: string; -} diff --git a/libs/domain/picking/navigate-back/navigate-back.schema.ts b/libs/domain/picking/navigate-back/navigate-back.schema.ts deleted file mode 100644 index 0273190efd..0000000000 --- a/libs/domain/picking/navigate-back/navigate-back.schema.ts +++ /dev/null @@ -1,8 +0,0 @@ -import { ContentComponentSchema } from '@spryker-oryx/experience'; -import { PickingNavigateBackComponent } from './navigate-back.component'; - -export const pickingNavigateBackComponentSchema: ContentComponentSchema = - { - name: 'Navigate back', - group: 'Picking', - }; diff --git a/libs/domain/picking/navigate-back/navigate-back.styles.ts b/libs/domain/picking/navigate-back/navigate-back.styles.ts deleted file mode 100644 index ce13daf244..0000000000 --- a/libs/domain/picking/navigate-back/navigate-back.styles.ts +++ /dev/null @@ -1,8 +0,0 @@ -import { css } from 'lit'; - -export const navigateBackComponentStyles = css` - oryx-icon, - button { - color: var(--oryx-color-neutral-11); - } -`; diff --git a/libs/domain/picking/navigate-back/stories/demo.stories.ts b/libs/domain/picking/navigate-back/stories/demo.stories.ts deleted file mode 100644 index fb4704daf2..0000000000 --- a/libs/domain/picking/navigate-back/stories/demo.stories.ts +++ /dev/null @@ -1,26 +0,0 @@ -import { Meta, Story } from '@storybook/web-components'; -import { TemplateResult, html } from 'lit'; -import { storybookPrefix } from '../../.constants'; -import { NavigateBackAttributes } from '../navigate-back.model'; - -export default { - title: `${storybookPrefix}/Navigate back`, - args: { url: '/test/url' }, - parameters: { - layout: 'fullscreen', - chromatic: { disableSnapshot: true }, - }, -} as Meta; - -const Template: Story = (props): TemplateResult => { - return html` - - - `; -}; - -export const Demo = Template.bind({}); diff --git a/libs/domain/picking/src/components.ts b/libs/domain/picking/src/components.ts index 6a69a3104b..a88ab4bd42 100644 --- a/libs/domain/picking/src/components.ts +++ b/libs/domain/picking/src/components.ts @@ -8,7 +8,6 @@ export * from '../list-item/list-item.def'; export * from '../lists-header/lists-header.def'; export * from '../lists/lists.def'; export * from '../login/login.def'; -export * from '../navigate-back/navigate-back.def'; export * from '../picker-header/picker-header.def'; export * from '../picker/picker.def'; export * from '../picking-in-progress/picking-in-progress.def'; diff --git a/libs/domain/picking/src/feature.ts b/libs/domain/picking/src/feature.ts index 23858c5cb0..4c6b3eacb1 100644 --- a/libs/domain/picking/src/feature.ts +++ b/libs/domain/picking/src/feature.ts @@ -18,7 +18,6 @@ import { pickingListsComponent, pickingListsHeaderComponent, pickingLoginPageComponent, - pickingNavigateBackComponent, pickingPickerComponent, pickingPickerHeaderComponent, pickingProductCardComponent, @@ -52,7 +51,6 @@ export const pickingComponents = [ pickingFiltersComponent, pickingLoginPageComponent, pickingHeaderComponent, - pickingNavigateBackComponent, pickingListsComponent, pickingListsHeaderComponent, pickingListItemComponent, diff --git a/tsconfig.base.json b/tsconfig.base.json index 084c1e4268..717b1a7f5f 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -133,9 +133,6 @@ ], "@spryker-oryx/picking/login": ["libs/domain/picking/login/index.ts"], "@spryker-oryx/picking/mocks": ["libs/domain/picking/mocks/index.ts"], - "@spryker-oryx/picking/navigate-back": [ - "libs/domain/picking/navigate-back/index.ts" - ], "@spryker-oryx/picking/offline": ["libs/domain/picking/offline/index.ts"], "@spryker-oryx/picking/picker": ["libs/domain/picking/picker/index.ts"], "@spryker-oryx/picking/picker-header": [ From f640e273389b01b21e574844c2f408788c4905af Mon Sep 17 00:00:00 2001 From: aleespryker Date: Mon, 18 Sep 2023 11:23:27 +0200 Subject: [PATCH 09/16] chore: refactoring --- libs/domain/picking/lists/index.ts | 1 - libs/domain/picking/login/login.component.ts | 2 -- libs/domain/picking/login/login.def.ts | 3 ++- libs/domain/picking/picker/picker.component.ts | 2 -- libs/domain/picking/picker/picker.def.ts | 3 ++- libs/domain/picking/src/mixins/picking-list.mixin.ts | 2 +- libs/domain/picking/src/models/index.ts | 1 + .../{lists/lists.model.ts => src/models/lists-component.ts} | 0 8 files changed, 6 insertions(+), 8 deletions(-) rename libs/domain/picking/{lists/lists.model.ts => src/models/lists-component.ts} (100%) diff --git a/libs/domain/picking/lists/index.ts b/libs/domain/picking/lists/index.ts index e3bffd4bb2..93ff3e52ef 100644 --- a/libs/domain/picking/lists/index.ts +++ b/libs/domain/picking/lists/index.ts @@ -1,3 +1,2 @@ export * from './lists.component'; -export * from './lists.model'; export * from './lists.styles'; diff --git a/libs/domain/picking/login/login.component.ts b/libs/domain/picking/login/login.component.ts index 459cf2e179..1d39231c3d 100644 --- a/libs/domain/picking/login/login.component.ts +++ b/libs/domain/picking/login/login.component.ts @@ -17,5 +17,3 @@ export class PickingLoginPageComponent extends I18nMixin(LitElement) { >`; } } - -export default PickingLoginPageComponent; diff --git a/libs/domain/picking/login/login.def.ts b/libs/domain/picking/login/login.def.ts index a95c15ff50..68653a9e69 100644 --- a/libs/domain/picking/login/login.def.ts +++ b/libs/domain/picking/login/login.def.ts @@ -2,5 +2,6 @@ import { componentDef } from '@spryker-oryx/utilities'; export const pickingLoginPageComponent = componentDef({ name: 'oryx-picking-login', - impl: () => import('./login.component').then((m) => m.default), + impl: () => + import('./login.component').then((m) => m.PickingLoginPageComponent), }); diff --git a/libs/domain/picking/picker/picker.component.ts b/libs/domain/picking/picker/picker.component.ts index ff5d91e987..e94d2e813b 100644 --- a/libs/domain/picking/picker/picker.component.ts +++ b/libs/domain/picking/picker/picker.component.ts @@ -386,5 +386,3 @@ export class PickingPickerComponent extends I18nMixin( this.items = [...this.items]; } } - -export default PickingPickerComponent; diff --git a/libs/domain/picking/picker/picker.def.ts b/libs/domain/picking/picker/picker.def.ts index b5d27416e7..423e2dac15 100644 --- a/libs/domain/picking/picker/picker.def.ts +++ b/libs/domain/picking/picker/picker.def.ts @@ -2,5 +2,6 @@ import { componentDef } from '@spryker-oryx/utilities'; export const pickingPickerComponent = componentDef({ name: 'oryx-picking-picker', - impl: () => import('./picker.component').then((m) => m.default), + impl: () => + import('./picker.component').then((m) => m.PickingPickerComponent), }); diff --git a/libs/domain/picking/src/mixins/picking-list.mixin.ts b/libs/domain/picking/src/mixins/picking-list.mixin.ts index a827472f0e..663cb99cca 100644 --- a/libs/domain/picking/src/mixins/picking-list.mixin.ts +++ b/libs/domain/picking/src/mixins/picking-list.mixin.ts @@ -1,5 +1,5 @@ import { resolve } from '@spryker-oryx/di'; -import { PickingListComponentProperties } from '@spryker-oryx/picking/lists'; +import { PickingListComponentProperties } from '@spryker-oryx/picking'; import { Signal, Type, diff --git a/libs/domain/picking/src/models/index.ts b/libs/domain/picking/src/models/index.ts index b9ec5de23e..5a0e32e21b 100644 --- a/libs/domain/picking/src/models/index.ts +++ b/libs/domain/picking/src/models/index.ts @@ -1,3 +1,4 @@ +export * from './lists-component'; export * from './pageable-qualifier'; export * from './picking-list'; export * from './picking-list-qualifier'; diff --git a/libs/domain/picking/lists/lists.model.ts b/libs/domain/picking/src/models/lists-component.ts similarity index 100% rename from libs/domain/picking/lists/lists.model.ts rename to libs/domain/picking/src/models/lists-component.ts From a8d58f86da9603e0e3cbba2498a2a97c307e47a0 Mon Sep 17 00:00:00 2001 From: aleespryker Date: Mon, 18 Sep 2023 15:44:39 +0200 Subject: [PATCH 10/16] revert commit --- apps/fulfillment-e2e/cypress.config.js | 2 +- apps/fulfillment-e2e/project.json | 2 +- libs/base/utilities/src/misc/version.ts | 2 +- .../picker-header/picker-header.component.ts | 19 +++++++++++-------- libs/template/presets/storefront/app.ts | 2 +- 5 files changed, 15 insertions(+), 12 deletions(-) diff --git a/apps/fulfillment-e2e/cypress.config.js b/apps/fulfillment-e2e/cypress.config.js index fefd9ee10f..87f5d97184 100644 --- a/apps/fulfillment-e2e/cypress.config.js +++ b/apps/fulfillment-e2e/cypress.config.js @@ -17,7 +17,7 @@ module.exports = defineConfig({ e2e: { // We've imported your old cypress plugins here. // You may want to clean this up later by importing these. - baseUrl: 'http://localhost:4200', + baseUrl: 'http://localhost:4173', specPattern: './src/integration/*.cy.{js,jsx,ts,tsx}', supportFile: './src/support/index.ts', }, diff --git a/apps/fulfillment-e2e/project.json b/apps/fulfillment-e2e/project.json index 30604ddd40..6bee65146c 100644 --- a/apps/fulfillment-e2e/project.json +++ b/apps/fulfillment-e2e/project.json @@ -7,7 +7,7 @@ "e2e": { "executor": "@nrwl/cypress:cypress", "options": { - "browser": "chrome", + "browser": "chromium", "cypressConfig": "apps/fulfillment-e2e/cypress.config.js", "watch": true, "testingType": "e2e" diff --git a/libs/base/utilities/src/misc/version.ts b/libs/base/utilities/src/misc/version.ts index ac4590cccb..bd57d28849 100644 --- a/libs/base/utilities/src/misc/version.ts +++ b/libs/base/utilities/src/misc/version.ts @@ -1,7 +1,7 @@ declare const __ORYX_FEATURE_VERSION__: string; // this one should be adjusted per major version -const defaultVersion = '1.0'; +const defaultVersion = '1.2'; export const featureVersion = typeof __ORYX_FEATURE_VERSION__ !== 'undefined' diff --git a/libs/domain/picking/picker-header/picker-header.component.ts b/libs/domain/picking/picker-header/picker-header.component.ts index d478dcb631..6a7ab0c370 100644 --- a/libs/domain/picking/picker-header/picker-header.component.ts +++ b/libs/domain/picking/picker-header/picker-header.component.ts @@ -4,12 +4,13 @@ import { PickingDiscardModalComponent } from '@spryker-oryx/picking/discard-moda import { RouterService } from '@spryker-oryx/router'; import { ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; import { IconTypes } from '@spryker-oryx/ui/icon'; -import { I18nMixin, subscribe } from '@spryker-oryx/utilities'; +import { I18nMixin, signal, signalAware } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { query, state } from 'lit/decorators.js'; import { tap } from 'rxjs'; import { styles } from './picker-header.styles'; +@signalAware() export class PickingPickerHeaderComponent extends I18nMixin( PickingListMixin(LitElement) ) { @@ -23,14 +24,15 @@ export class PickingPickerHeaderComponent extends I18nMixin( @state() isCartNoteVisible?: boolean; - @subscribe() - protected showDialog$ = this.pickingHeaderService - .showDialog() - .pipe( - tap((showDialog) => - showDialog ? this.openDiscardModal() : this.closeDiscardModal() + protected $showDialog = signal( + this.pickingHeaderService + .showDialog() + .pipe( + tap((showDialog) => + showDialog ? this.openDiscardModal() : this.closeDiscardModal() + ) ) - ); + ); protected renderCartNoteButton(): TemplateResult { return html`${this.$pickingList()?.cartNote @@ -53,6 +55,7 @@ export class PickingPickerHeaderComponent extends I18nMixin( } protected override render(): TemplateResult { + this.$showDialog(); return html` Date: Mon, 18 Sep 2023 15:52:48 +0200 Subject: [PATCH 11/16] fix: revert unwanted changes --- apps/fulfillment-e2e/cypress.config.js | 2 +- apps/fulfillment-e2e/project.json | 2 +- libs/base/utilities/src/misc/version.ts | 2 +- libs/template/presets/storefront/app.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/fulfillment-e2e/cypress.config.js b/apps/fulfillment-e2e/cypress.config.js index 87f5d97184..fefd9ee10f 100644 --- a/apps/fulfillment-e2e/cypress.config.js +++ b/apps/fulfillment-e2e/cypress.config.js @@ -17,7 +17,7 @@ module.exports = defineConfig({ e2e: { // We've imported your old cypress plugins here. // You may want to clean this up later by importing these. - baseUrl: 'http://localhost:4173', + baseUrl: 'http://localhost:4200', specPattern: './src/integration/*.cy.{js,jsx,ts,tsx}', supportFile: './src/support/index.ts', }, diff --git a/apps/fulfillment-e2e/project.json b/apps/fulfillment-e2e/project.json index 6bee65146c..30604ddd40 100644 --- a/apps/fulfillment-e2e/project.json +++ b/apps/fulfillment-e2e/project.json @@ -7,7 +7,7 @@ "e2e": { "executor": "@nrwl/cypress:cypress", "options": { - "browser": "chromium", + "browser": "chrome", "cypressConfig": "apps/fulfillment-e2e/cypress.config.js", "watch": true, "testingType": "e2e" diff --git a/libs/base/utilities/src/misc/version.ts b/libs/base/utilities/src/misc/version.ts index bd57d28849..ac4590cccb 100644 --- a/libs/base/utilities/src/misc/version.ts +++ b/libs/base/utilities/src/misc/version.ts @@ -1,7 +1,7 @@ declare const __ORYX_FEATURE_VERSION__: string; // this one should be adjusted per major version -const defaultVersion = '1.2'; +const defaultVersion = '1.0'; export const featureVersion = typeof __ORYX_FEATURE_VERSION__ !== 'undefined' diff --git a/libs/template/presets/storefront/app.ts b/libs/template/presets/storefront/app.ts index 635f3acfb1..95d7317685 100644 --- a/libs/template/presets/storefront/app.ts +++ b/libs/template/presets/storefront/app.ts @@ -50,10 +50,10 @@ export const storefrontFeatures: AppFeature[] = [ orderFeature, contentFeature, formFeature, - productFeature, experienceFeature, experienceRoutesFeature, isPreview ? experiencePreviewFeature : {}, + productFeature, searchFeature, siteFeature, applicationFeature, From 36ac841586ced0f03b0f8dc2a70c86ea20f2358c Mon Sep 17 00:00:00 2001 From: aleespryker Date: Mon, 18 Sep 2023 15:59:23 +0200 Subject: [PATCH 12/16] fix: revert unwanted changes --- .../picker-header/picker-header.component.ts | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/libs/domain/picking/picker-header/picker-header.component.ts b/libs/domain/picking/picker-header/picker-header.component.ts index 6a7ab0c370..d478dcb631 100644 --- a/libs/domain/picking/picker-header/picker-header.component.ts +++ b/libs/domain/picking/picker-header/picker-header.component.ts @@ -4,13 +4,12 @@ import { PickingDiscardModalComponent } from '@spryker-oryx/picking/discard-moda import { RouterService } from '@spryker-oryx/router'; import { ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; import { IconTypes } from '@spryker-oryx/ui/icon'; -import { I18nMixin, signal, signalAware } from '@spryker-oryx/utilities'; +import { I18nMixin, subscribe } from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { query, state } from 'lit/decorators.js'; import { tap } from 'rxjs'; import { styles } from './picker-header.styles'; -@signalAware() export class PickingPickerHeaderComponent extends I18nMixin( PickingListMixin(LitElement) ) { @@ -24,15 +23,14 @@ export class PickingPickerHeaderComponent extends I18nMixin( @state() isCartNoteVisible?: boolean; - protected $showDialog = signal( - this.pickingHeaderService - .showDialog() - .pipe( - tap((showDialog) => - showDialog ? this.openDiscardModal() : this.closeDiscardModal() - ) + @subscribe() + protected showDialog$ = this.pickingHeaderService + .showDialog() + .pipe( + tap((showDialog) => + showDialog ? this.openDiscardModal() : this.closeDiscardModal() ) - ); + ); protected renderCartNoteButton(): TemplateResult { return html`${this.$pickingList()?.cartNote @@ -55,7 +53,6 @@ export class PickingPickerHeaderComponent extends I18nMixin( } protected override render(): TemplateResult { - this.$showDialog(); return html` Date: Tue, 19 Sep 2023 17:43:18 +0200 Subject: [PATCH 13/16] chore(picking): reduce rxjs in picking (#772) closes: [HRZ-89877](https://spryker.atlassian.net/browse/HRZ-89877) [HRZ-89877]: https://spryker.atlassian.net/browse/HRZ-89877?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- .../picker-header/picker-header.component.ts | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libs/domain/picking/picker-header/picker-header.component.ts b/libs/domain/picking/picker-header/picker-header.component.ts index d478dcb631..c72c9ef1a3 100644 --- a/libs/domain/picking/picker-header/picker-header.component.ts +++ b/libs/domain/picking/picker-header/picker-header.component.ts @@ -4,12 +4,17 @@ import { PickingDiscardModalComponent } from '@spryker-oryx/picking/discard-moda import { RouterService } from '@spryker-oryx/router'; import { ButtonSize, ButtonType } from '@spryker-oryx/ui/button'; import { IconTypes } from '@spryker-oryx/ui/icon'; -import { I18nMixin, subscribe } from '@spryker-oryx/utilities'; +import { + I18nMixin, + elementEffect, + signal, + signalAware, +} from '@spryker-oryx/utilities'; import { LitElement, TemplateResult, html } from 'lit'; import { query, state } from 'lit/decorators.js'; -import { tap } from 'rxjs'; import { styles } from './picker-header.styles'; +@signalAware() export class PickingPickerHeaderComponent extends I18nMixin( PickingListMixin(LitElement) ) { @@ -23,14 +28,12 @@ export class PickingPickerHeaderComponent extends I18nMixin( @state() isCartNoteVisible?: boolean; - @subscribe() - protected showDialog$ = this.pickingHeaderService - .showDialog() - .pipe( - tap((showDialog) => - showDialog ? this.openDiscardModal() : this.closeDiscardModal() - ) - ); + protected $showDialog = signal(this.pickingHeaderService.showDialog()); + + @elementEffect() + protected $modalAction = (): void => { + this.$showDialog() ? this.openDiscardModal() : this.closeDiscardModal(); + }; protected renderCartNoteButton(): TemplateResult { return html`${this.$pickingList()?.cartNote From d303978edcae6f594033e0dd8deb764aba1a6456 Mon Sep 17 00:00:00 2001 From: aleespryker <94365900+aleespryker@users.noreply.github.com> Date: Wed, 20 Sep 2023 13:33:50 +0200 Subject: [PATCH 14/16] chore(picking): optimize product card (#774) closes: [HRZ-89878](https://spryker.atlassian.net/browse/HRZ-89878) [HRZ-89878]: https://spryker.atlassian.net/browse/HRZ-89878?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- .../product-card/product-card.component.ts | 32 ++++++++++--------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/libs/domain/picking/product-card/product-card.component.ts b/libs/domain/picking/product-card/product-card.component.ts index da6fa4ce2d..b55c903c26 100644 --- a/libs/domain/picking/product-card/product-card.component.ts +++ b/libs/domain/picking/product-card/product-card.component.ts @@ -139,36 +139,38 @@ export class PickingProductCardComponent extends I18nMixin(LitElement) { } protected renderEditStatus(): TemplateResult { - let text = ''; - let label = ''; - let subtext = ''; - if (!this.productItem) { return html``; } + let count: number; + let label = ''; + let subtext = ''; + + const { quantity, numberOfPicked, numberOfNotPicked } = this.productItem; + if (this.status === ItemsFilters.Picked) { - text = `${this.productItem.numberOfPicked}/${this.productItem.quantity}`; + count = numberOfPicked; - if (this.productItem.numberOfPicked < this.productItem.quantity) { - label = this.i18n('picking.product-card.items-picked') as string; + if (numberOfPicked < quantity) { + label = 'picking.product-card.items-picked'; } else { - subtext = this.i18n('picking.product-card.all-items-picked') as string; + subtext = 'picking.product-card.all-items-picked'; } - } else if (this.status === ItemsFilters.NotFound) { - text = `${this.productItem.numberOfNotPicked}/${this.productItem.quantity}`; + } else { + count = numberOfNotPicked; - if (this.productItem.numberOfNotPicked < this.productItem.quantity) { - label = this.i18n('picking.product-card.items-not-found') as string; + if (numberOfNotPicked < quantity) { + label = 'picking.product-card.items-not-found'; } else { - subtext = this.i18n('picking.product-card.no-items-found') as string; + subtext = 'picking.product-card.no-items-found'; } } return html`
-

${text} ${label}

- ${when(subtext, () => html`

${subtext}

`)} +

${count}/${quantity} ${this.i18n(label)}

+ ${when(subtext, () => html`

${this.i18n(subtext)}

`)}
Date: Wed, 20 Sep 2023 16:31:16 +0200 Subject: [PATCH 15/16] chore: refactoring --- libs/domain/picking/login/login.component.spec.ts | 8 ++++---- libs/domain/picking/login/login.component.ts | 2 +- libs/domain/picking/login/login.def.ts | 5 ++--- libs/domain/picking/src/feature.ts | 4 ++-- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/libs/domain/picking/login/login.component.spec.ts b/libs/domain/picking/login/login.component.spec.ts index 10ab29422f..d8067e14a4 100644 --- a/libs/domain/picking/login/login.component.spec.ts +++ b/libs/domain/picking/login/login.component.spec.ts @@ -1,14 +1,14 @@ import { fixture } from '@open-wc/testing-helpers'; import { useComponent } from '@spryker-oryx/utilities'; import { html } from 'lit'; -import { PickingLoginPageComponent } from './login.component'; -import { pickingLoginPageComponent } from './login.def'; +import { PickingLoginComponent } from './login.component'; +import { pickingLoginComponent } from './login.def'; describe('LoginPageComponent', () => { - let element: PickingLoginPageComponent; + let element: PickingLoginComponent; beforeAll(async () => { - await useComponent([pickingLoginPageComponent]); + await useComponent([pickingLoginComponent]); }); beforeEach(async () => { diff --git a/libs/domain/picking/login/login.component.ts b/libs/domain/picking/login/login.component.ts index 1d39231c3d..66b3a7e082 100644 --- a/libs/domain/picking/login/login.component.ts +++ b/libs/domain/picking/login/login.component.ts @@ -2,7 +2,7 @@ import { I18nMixin } from '@spryker-oryx/utilities'; import { html, LitElement, TemplateResult } from 'lit'; import { loginComponentStyles } from './login.styles'; -export class PickingLoginPageComponent extends I18nMixin(LitElement) { +export class PickingLoginComponent extends I18nMixin(LitElement) { static styles = loginComponentStyles; protected override render(): TemplateResult { diff --git a/libs/domain/picking/login/login.def.ts b/libs/domain/picking/login/login.def.ts index 68653a9e69..b0e8dab644 100644 --- a/libs/domain/picking/login/login.def.ts +++ b/libs/domain/picking/login/login.def.ts @@ -1,7 +1,6 @@ import { componentDef } from '@spryker-oryx/utilities'; -export const pickingLoginPageComponent = componentDef({ +export const pickingLoginComponent = componentDef({ name: 'oryx-picking-login', - impl: () => - import('./login.component').then((m) => m.PickingLoginPageComponent), + impl: () => import('./login.component').then((m) => m.PickingLoginComponent), }); diff --git a/libs/domain/picking/src/feature.ts b/libs/domain/picking/src/feature.ts index 4c6b3eacb1..6cc1ebed34 100644 --- a/libs/domain/picking/src/feature.ts +++ b/libs/domain/picking/src/feature.ts @@ -17,7 +17,7 @@ import { pickingListItemComponent, pickingListsComponent, pickingListsHeaderComponent, - pickingLoginPageComponent, + pickingLoginComponent, pickingPickerComponent, pickingPickerHeaderComponent, pickingProductCardComponent, @@ -49,7 +49,7 @@ export const pickingComponents = [ pickingDiscardModalComponent, pickingFilterButtonComponent, pickingFiltersComponent, - pickingLoginPageComponent, + pickingLoginComponent, pickingHeaderComponent, pickingListsComponent, pickingListsHeaderComponent, From d97a5f04194c07490f278f9ceab61f1cc33019d6 Mon Sep 17 00:00:00 2001 From: aleespryker Date: Wed, 20 Sep 2023 16:52:07 +0200 Subject: [PATCH 16/16] chore: update unit test component naming --- .../customer-note-modal/customer-note-modal.component.spec.ts | 2 +- .../picking/customer-note/customer-note.component.spec.ts | 2 +- .../picking/discard-modal/discard-modal.component.spec.ts | 2 +- .../picking/filter-button/filter-button.component.spec.ts | 2 +- libs/domain/picking/filters/filters.component.spec.ts | 2 +- libs/domain/picking/header/header.component.spec.ts | 2 +- libs/domain/picking/lists/lists.component.spec.ts | 2 +- libs/domain/picking/login/login.component.spec.ts | 2 +- .../picking/picker-header/picker-header.component.spec.ts | 2 +- libs/domain/picking/picker/picker.component.spec.ts | 2 +- libs/domain/picking/user-profile/user-profile.component.spec.ts | 2 +- .../warehouse-assignment/warehouse-assignment.component.spec.ts | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts b/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts index a60ad404c9..52a31ad3ff 100644 --- a/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts +++ b/libs/domain/picking/customer-note-modal/customer-note-modal.component.spec.ts @@ -6,7 +6,7 @@ import { afterEach, beforeAll, beforeEach } from 'vitest'; import { PickingCustomerNoteModalComponent } from './customer-note-modal.component'; import { pickingCustomerNoteModalComponent } from './customer-note-modal.def'; -describe('CustomerNoteModal', () => { +describe('PickingCustomerNoteModal', () => { let element: PickingCustomerNoteModalComponent; const getModal = (): ModalComponent | null => diff --git a/libs/domain/picking/customer-note/customer-note.component.spec.ts b/libs/domain/picking/customer-note/customer-note.component.spec.ts index 11d9c8141e..3dc63636f1 100644 --- a/libs/domain/picking/customer-note/customer-note.component.spec.ts +++ b/libs/domain/picking/customer-note/customer-note.component.spec.ts @@ -25,7 +25,7 @@ class MockPickingListService implements Partial { getUpcomingPickingListId = vi.fn().mockReturnValue(of(null)); } -describe('CustomerNoteComponent', () => { +describe('PickingCustomerNoteComponent', () => { let element: PickingCustomerNoteComponent; let service: MockPickingListService; let routerService: MockRouterService; diff --git a/libs/domain/picking/discard-modal/discard-modal.component.spec.ts b/libs/domain/picking/discard-modal/discard-modal.component.spec.ts index 9de70d3dad..80e04aa711 100644 --- a/libs/domain/picking/discard-modal/discard-modal.component.spec.ts +++ b/libs/domain/picking/discard-modal/discard-modal.component.spec.ts @@ -4,7 +4,7 @@ import { html } from 'lit'; import { PickingDiscardModalComponent } from './discard-modal.component'; import { pickingDiscardModalComponent } from './discard-modal.def'; -describe('DiscardModalComponent', () => { +describe('PickingDiscardModalComponent', () => { let element: PickingDiscardModalComponent; beforeAll(async () => { diff --git a/libs/domain/picking/filter-button/filter-button.component.spec.ts b/libs/domain/picking/filter-button/filter-button.component.spec.ts index 50785bee0b..465a31ca13 100644 --- a/libs/domain/picking/filter-button/filter-button.component.spec.ts +++ b/libs/domain/picking/filter-button/filter-button.component.spec.ts @@ -15,7 +15,7 @@ class MockPickingListService implements Partial { getSortingQualifier = vi.fn().mockReturnValue(of(defaultSortingQualifier)); } -describe('FilterButtonComponent', () => { +describe('PickingFilterButtonComponent', () => { let element: PickingFilterButtonComponent; let service: MockPickingListService; diff --git a/libs/domain/picking/filters/filters.component.spec.ts b/libs/domain/picking/filters/filters.component.spec.ts index 55d5d2a0f9..56f21d42d9 100644 --- a/libs/domain/picking/filters/filters.component.spec.ts +++ b/libs/domain/picking/filters/filters.component.spec.ts @@ -22,7 +22,7 @@ class MockFormRenderer implements Partial { buildForm = vi.fn().mockReturnValue(html``); } -describe('FiltersComponent', () => { +describe('PickingFiltersComponent', () => { let element: PickingFiltersComponent; let service: MockPickingListService; let renderer: MockFormRenderer; diff --git a/libs/domain/picking/header/header.component.spec.ts b/libs/domain/picking/header/header.component.spec.ts index 95fa085adb..e769c0cf11 100644 --- a/libs/domain/picking/header/header.component.spec.ts +++ b/libs/domain/picking/header/header.component.spec.ts @@ -5,7 +5,7 @@ import { i18n, useComponent } from '@spryker-oryx/utilities'; import PickingHeaderComponent from './header.component'; import { pickingHeaderComponent } from './header.def'; -describe('Header Component', () => { +describe('Picking Header Component', () => { let element: PickingHeaderComponent; beforeAll(async () => { diff --git a/libs/domain/picking/lists/lists.component.spec.ts b/libs/domain/picking/lists/lists.component.spec.ts index 34ff98a955..9981b142e9 100644 --- a/libs/domain/picking/lists/lists.component.spec.ts +++ b/libs/domain/picking/lists/lists.component.spec.ts @@ -32,7 +32,7 @@ class MockPickingListService implements Partial { isRefreshing = vi.fn().mockReturnValue(of(false)); } -describe('ListsComponent', () => { +describe('PickingListsComponent', () => { let element: PickingListsComponent; let service: MockPickingListService; let syncService: MockPickingSyncActionHandlerService; diff --git a/libs/domain/picking/login/login.component.spec.ts b/libs/domain/picking/login/login.component.spec.ts index d8067e14a4..71dc72d263 100644 --- a/libs/domain/picking/login/login.component.spec.ts +++ b/libs/domain/picking/login/login.component.spec.ts @@ -4,7 +4,7 @@ import { html } from 'lit'; import { PickingLoginComponent } from './login.component'; import { pickingLoginComponent } from './login.def'; -describe('LoginPageComponent', () => { +describe('PickingLoginPageComponent', () => { let element: PickingLoginComponent; beforeAll(async () => { diff --git a/libs/domain/picking/picker-header/picker-header.component.spec.ts b/libs/domain/picking/picker-header/picker-header.component.spec.ts index f065c14157..cef9fc436d 100644 --- a/libs/domain/picking/picker-header/picker-header.component.spec.ts +++ b/libs/domain/picking/picker-header/picker-header.component.spec.ts @@ -31,7 +31,7 @@ class MockRouterService implements Partial { back = vi.fn(); } -describe('PickingHeaderComponent', () => { +describe('PickingPickerHeaderComponent', () => { let element: PickingPickerHeaderComponent; let service: MockPickingListService; let routerService: MockRouterService; diff --git a/libs/domain/picking/picker/picker.component.spec.ts b/libs/domain/picking/picker/picker.component.spec.ts index 2ca725db83..d226b1e0f2 100644 --- a/libs/domain/picking/picker/picker.component.spec.ts +++ b/libs/domain/picking/picker/picker.component.spec.ts @@ -31,7 +31,7 @@ class MockRouterService implements Partial { Element.prototype.scrollIntoView = vi.fn(); -describe('PickingComponent', () => { +describe('PickingPickerComponent', () => { let element: PickingPickerComponent; let service: MockPickingListService; let routerService: MockRouterService; diff --git a/libs/domain/picking/user-profile/user-profile.component.spec.ts b/libs/domain/picking/user-profile/user-profile.component.spec.ts index 88705b5a9d..fe1b351582 100644 --- a/libs/domain/picking/user-profile/user-profile.component.spec.ts +++ b/libs/domain/picking/user-profile/user-profile.component.spec.ts @@ -42,7 +42,7 @@ class MockStorageService implements Partial { get = vi.fn().mockReturnValue(of(undefined)); } -describe('UserProfileComponent', () => { +describe('PickingUserProfileComponent', () => { let element: PickingUserProfileComponent; let routerService: MockRouterService; let syncSchedulerService: MockSyncSchedulerService; diff --git a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts index 4399b2eb2b..44ea0a3f5d 100644 --- a/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts +++ b/libs/domain/picking/warehouse-assignment/warehouse-assignment.component.spec.ts @@ -42,7 +42,7 @@ class MockRouterService implements Partial { navigate = vi.fn(); } -describe('WarehouseAssignmentComponent', () => { +describe('PickingWarehouseAssignmentComponent', () => { let el: PickingWarehouseAssignmentComponent; let service: MockWarehouseUserAssignmentsService;