-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content): resolve product, category and content links #775
Conversation
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -21,6 +26,27 @@ export class ContentLinkComponent extends ContentMixin< | |||
return null; | |||
}); | |||
|
|||
protected $text = computed(() => { | |||
const { type, id } = this.$options(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could move this down a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, but still open afaik
1 flaky test on run #10053 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
Authentication suite > should allow to login and logout |
Test Replay
Output
Screenshots
Video
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Passing run #2375 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Improve the content link component to resolve links to product, category or content pages.
Reveal suggestions so that integrations can reuse the data while building content.
closes: HRZ-89824