feat(content): resolve product, category and content links #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tobi-or-not-tobi
suggested changes
Sep 19, 2023
| @@ -21,6 +26,27 @@ export class ContentLinkComponent extends ContentMixin< | |||
| return null; | |||
| }); | |||
|
|
|||
| protected $text = computed(() => { | |||
| const { type, id } = this.$options(); | |||
There was a problem hiding this comment.
we could move this down a bit
There was a problem hiding this comment.
nitpick, but still open afaik
1 flaky test on run #10053 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Authentication suite > should allow to login and logout |
Test Replay
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Passing run #2375 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
tobi-or-not-tobi
changed the title
tobi-or-not-tobi
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the content link component to resolve links to product, category or content pages.
Reveal suggestions so that integrations can reuse the data while building content.
closes: HRZ-89824