Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApiGateway key identification #1545

Merged
merged 1 commit into from Apr 12, 2018

Conversation

@haidaraM
Copy link
Contributor

haidaraM commented Mar 30, 2018

Hello :), here is my firt PR that fixes an issue with API Gateway keys identification

API Gateway keys are identified by their ids and not their values

@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 30, 2018

Coverage Status

Coverage remained the same at 92.53% when pulling dcd290c on haidaraM:fixApiKeyIdentification into 0a4d203 on spulec:master.

@kingbuzzman

This comment has been minimized.

Copy link
Contributor

kingbuzzman commented Apr 1, 2018

Oops. Missed that completely. Makes sense to me.

@haidaraM

This comment has been minimized.

Copy link
Contributor Author

haidaraM commented Apr 12, 2018

Someone to check this PR ?

@kingbuzzman

This comment has been minimized.

Copy link
Contributor

kingbuzzman commented Apr 12, 2018

They're a little slow, give them time. Remember no one gets paid for this ;) My pr sat around for like 2 weeks.. so, you're still doing better.

@haidaraM

This comment has been minimized.

Copy link
Contributor Author

haidaraM commented Apr 12, 2018

Yeah absolutely agree with you :) Not so critical...

@spulec spulec merged commit 5f840aa into spulec:master Apr 12, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.53%
Details
@spulec

This comment has been minimized.

Copy link
Owner

spulec commented Apr 12, 2018

Sorry it took a bit to review.

Thanks for the contribution and welcome to Moto!

@haidaraM

This comment has been minimized.

Copy link
Contributor Author

haidaraM commented Apr 12, 2018

No worries :) and thank you for your great library

postmart pushed a commit to postmart/moto that referenced this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.