New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to store multiple scrects, use uuid, tags support #1898

Merged
merged 2 commits into from Dec 29, 2018

Conversation

Projects
None yet
7 participants
@sepulworld
Copy link
Contributor

sepulworld commented Oct 24, 2018

@sirech thanks for the ideas and help here! See: #1893

  • Refactor for multiple secrets @sirech
  • Use UUID replace hardcoded value
  • Use random string in ARN id value
  • Fix datetime stamp
  • Adding support for Tags #2004
  • Add tests

@sepulworld sepulworld force-pushed the sepulworld:zmw/refactor_multiple_secrets branch from 135ba2a to a485d59 Oct 24, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 24, 2018

Coverage Status

Coverage decreased (-0.3%) to 92.274% when pulling a485d59 on sepulworld:zmw/refactor_multiple_secrets into 71a054a on spulec:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 24, 2018

Coverage Status

Coverage decreased (-0.3%) to 92.274% when pulling a485d59 on sepulworld:zmw/refactor_multiple_secrets into 71a054a on spulec:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 24, 2018

Coverage Status

Coverage decreased (-0.04%) to 92.509% when pulling 08d17a7 on sepulworld:zmw/refactor_multiple_secrets into 71a054a on spulec:master.

@sepulworld sepulworld changed the title refactor to store multiple scrects, use uuid Refactor to store multiple scrects, use uuid Oct 24, 2018

Show resolved Hide resolved moto/secretsmanager/models.py Outdated
Show resolved Hide resolved moto/secretsmanager/models.py Outdated
@sirech

This comment has been minimized.

Copy link

sirech commented Oct 25, 2018

looks good to me!

@sepulworld sepulworld force-pushed the sepulworld:zmw/refactor_multiple_secrets branch from f490b92 to 31fcb72 Oct 25, 2018

@sepulworld sepulworld force-pushed the sepulworld:zmw/refactor_multiple_secrets branch from 3368673 to b485122 Oct 25, 2018

@sepulworld

This comment has been minimized.

Copy link
Contributor Author

sepulworld commented Oct 25, 2018

@spulec this is good to go! Looks like the travis test failed due to an intermittent test failure with x-ray test suite.

@damacus

This comment has been minimized.

Copy link

damacus commented Nov 2, 2018

Confirmed this also fixes the secrets http endpoint not returning the correct datetime.

@sirech

This comment has been minimized.

Copy link

sirech commented Nov 20, 2018

I was wondering, is this one ready to be merged? I would really like to use it :)

@sepulworld

This comment has been minimized.

Copy link
Contributor Author

sepulworld commented Nov 20, 2018

@sirech sorry, I don't have the permissions to merge or create a new Moto release. We will have to wait for one of the maintainers to respond :)

@sepulworld sepulworld changed the title Refactor to store multiple scrects, use uuid Refactor to store multiple scrects, use uuid, tag support Dec 21, 2018

@sepulworld sepulworld changed the title Refactor to store multiple scrects, use uuid, tag support Refactor to store multiple scrects, use uuid, tags support Dec 21, 2018

@spulec spulec merged commit 1244ce5 into spulec:master Dec 29, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.04%) to 92.509%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@spulec

This comment has been minimized.

Copy link
Owner

spulec commented Dec 29, 2018

Thanks for the help!

@TopherGopher

This comment has been minimized.

Copy link

TopherGopher commented Feb 7, 2019

@spulec I saw this was merged in a bit ago (awesome). What is your timeline for releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment