Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock AWS credentials #1952

Merged
merged 1 commit into from Dec 29, 2018

Conversation

@lhufnagel
Copy link

commented Nov 16, 2018

This should allow Moto-users to keep using existing tests without having to export dummy credentials from v1.3.7 onward. See also #1924

Lorenz Hufnagel
@coveralls

This comment has been minimized.

Copy link

commented Nov 16, 2018

Coverage Status

Coverage increased (+0.0008%) to 92.496% when pulling cf5bd76 on lhufnagel:master into ed861ec on spulec:master.

@jakul

This comment has been minimized.

Copy link

commented Dec 6, 2018

@spulec Can this PR be merged?

@kgutwin

This comment has been minimized.

Copy link

commented Dec 13, 2018

While this isn't at all my use case, wouldn't this change affect users who mix-and-match Moto mocks and real AWS calls in the same test run? I know it uses os.environ.setdefault to avoid overwriting environment variables, but this would disrupt any case when valid credentials are present in ~/.aws or instance metadata.

@spulec spulec merged commit ca2950f into spulec:master Dec 29, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0008%) to 92.496%
Details
@spulec

This comment has been minimized.

Copy link
Owner

commented Dec 29, 2018

Thanks!

@rjaduthie

This comment has been minimized.

Copy link

commented Jan 18, 2019

This will help simplify our work with moto and test build configuration.

Now the has been merged, will this be in the next release?.. and when might that be? Anything that I can help with?

@yan12125

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

Theses changes appear to break a test suite written by another developer: #2058

@devenney devenney referenced this pull request Mar 3, 2019
7 of 9 tasks complete
felixonmars-bot pushed a commit to felixonmars/archlinux-community that referenced this pull request May 6, 2019
AWS_* environment variables no longer necessary after spulec/moto#1952


git-svn-id: file:///srv/repos/svn-community/svn@460860 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@s0undt3ch

This comment has been minimized.

Copy link

commented May 8, 2019

Theses changes appear to break a test suite written by another developer: #2058

Same here.
Don't make these changes globally. If its for tests, do it in the tests...

s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 8, 2019
No globally changing the environment on import, please.
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request May 9, 2019
No globally changing the environment on import, please.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.