Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test cert validity to 2049 #2500

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Oct 21, 2019

Extend test cert validity to 2049
to make tests pass in 2027

Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

Note: I tested that i586 builds still pass tests on 2036-12-01
so are not affected by the year 2038 bug yet.

i586 builds in 2037 suffer from a y2038 bug (unrelated to this change):
botocore/utils.py parse_timestamp threw a
ValueError: Invalid timestamp "2174774434": Parser must be a string or character stream, not long

to make tests pass in 2027

Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

Note: I tested that i586 builds still pass tests on 2036-12-01
so are not affected by the year 2038 bug yet.

i586 builds in 2037 suffer from a y2038 bug (unrelated to this change):
 botocore/utils.py parse_timestamp threw a
  ValueError: Invalid timestamp "2174774434": Parser must be a string or character stream, not long
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage increased (+0.03%) to 93.568% when pulling 951a5a6 on bmwiedemann:ssl2049 into b433399 on spulec:master.

@mikegrima

This comment has been minimized.

Copy link
Collaborator

mikegrima commented Oct 22, 2019

Here is the cert in the PR for the curious:

Certificate:
    Data:
        Version: 1 (0x0)
        Serial Number: 16095180950976051872 (0xdf5d91cc8a8fbaa0)
    Signature Algorithm: sha256WithRSAEncryption
        Issuer: C=GB, ST=Berkshire, L=Slough, O=MotoServer, OU=QA, CN=Moto
        Validity
            Not Before: Oct 21 13:27:31 2019 GMT
            Not After : Dec 31 13:27:34 2049 GMT
        Subject: C=GB, ST=Berkshire, L=Slough, O=MotoServer, OU=Operations, CN=*.moto.com
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:cc:2f:e8:06:4c:f0:88:80:44:71:e4:82:fe:d4:
                    83:ee:19:2a:b3:c0:16:9e:20:d7:6c:c8:00:40:4f:
                    68:c5:4c:6d:90:51:12:c6:23:5a:f8:46:c0:30:b0:
                    45:b4:19:0f:46:f7:37:88:a5:e1:fd:c7:cb:a3:bc:
                    8f:f1:57:6a:10:80:e6:24:20:7f:dd:3d:e5:8e:39:
                    ab:08:cc:2a:bb:16:20:65:63:12:86:75:d9:57:46:
                    1f:0b:5f:55:ce:af:e0:16:98:b2:a1:a2:36:48:8e:
                    4d:38:59:5f:c2:1b:39:84:56:9c:4c:69:1f:be:98:
                    c9:bd:fe:87:9e:b3:49:ee:47:90:47:ea:06:24:d7:
                    fb:8d:56:82:80:e5:5d:27:89:6d:ef:ef:7c:60:35:
                    5d:7b:b8:cb:c7:50:cd:f9:06:ef:56:22:50:97:ad:
                    27:2b:76:e6:7e:e2:e2:8b:0f:35:e7:81:32:8b:d0:
                    ce:70:91:3c:00:1f:96:ec:aa:4f:76:b9:9b:3e:2b:
                    11:d4:48:aa:63:48:b4:2f:ad:99:8b:13:74:ac:f8:
                    b9:84:71:7e:a3:3c:14:44:bd:5a:c5:c9:8b:8e:58:
                    48:16:2f:18:84:10:8d:71:8e:93:84:4e:e3:ae:a8:
                    0b:22:ad:67:e9:df:1e:cd:1c:63:0c:a9:aa:7c:7d:
                    6c:a5
                Exponent: 65537 (0x10001)
    Signature Algorithm: sha256WithRSAEncryption
         0e:c2:f2:63:63:57:0b:20:15:46:08:33:e4:93:11:f8:c4:23:
         fa:f9:04:5d:9b:b6:ea:17:b5:f9:0c:d6:7b:d1:87:09:db:b1:
         a5:76:b1:0f:98:a5:fc:0b:54:6f:90:2e:28:0a:c6:b2:b6:5f:
         07:97:0d:d9:71:2d:46:bf:00:71:4d:59:67:60:81:3a:9c:b3:
         cf:8b:58:b1:2e:f6:18:82:8a:be:32:39:3f:d9:73:c2:9d:4f:
         fa:72:a2:61:6f:92:0d:b2:48:3d:b3:4a:35:e6:3b:f6:ed:c5:
         08:81:65:4c:9e:3f:9d:e6:5b:d2:8b:2d:47:85:d6:0c:c2:fb:
         90:cd:71:0b:8e:17:bf:ac:7c:35:fc:11:46:68:15:76:bd:de:
         de:8a:75:10:c2:56:b9:d1:46:4b:72:c8:fa:17:05:92:22:cb:
         fb:10:1e:06:69:8f:c6:d1:7a:82:31:a8:b6:3e:5b:41:80:13:
         c5:aa:c6:68:db:bb:81:79:57:f1:a8:c6:6d:c0:04:25:af:88:
         96:c1:66:66:d6:16:83:cb:a0:f8:18:50:92:47:c1:3f:82:d9:
         72:86:23:78:30:e9:35:72:6a:fd:3d:23:8c:07:70:96:a8:a8:
         e4:c7:b9:4f:30:e4:13:fd:ff:a0:c6:50:a7:ba:93:47:b0:77:
         19:1a:f4:15:e2:60:8f:89:4f:a5:2f:0a:7e:f3:3f:ec:6e:ea:
         50:c1:1b:ee:d5:2c:12:50:3d:ab:22:c5:5e:52:e4:8f:de:16:
         cc:71:f8:62:64:0e:74:95:e9:d0:34:0a:62:9a:0a:d3:85:d3:
         d4:a0:55:e2:d3:b1:54:74:bf:85:d5:00:a4:e9:cb:c0:e3:c2:
         b3:19:1a:3e:6c:f4:9f:65:0b:ac:8f:9d:64:ff:6f:a1:97:8b:
         07:1d:97:56:83:a9:86:00:86:3d:22:73:0a:98:f0:c4:e1:5c:
         cc:f2:1a:e8:7e:bd:9f:24:ba:8a:43:88:7e:c4:a6:c4:62:7b:
         cf:10:fb:6d:51:d2:5b:bd:48:2b:f5:32:8a:57:0f:a6:de:59:
         96:f5:29:2d:cc:4e:4a:b6:f5:af:37:a7:5a:4e:3f:59:a0:70:
         c9:90:ec:a4:a3:7b:b2:4f:39:3e:1f:05:83:0b:fa:50:d9:c0:
         be:88:5d:4c:8c:81:e2:ef:65:3d:89:b3:9b:48:e0:e0:fd:df:
         5c:30:7d:d7:25:39:d9:f5:6d:fe:1d:ef:62:b8:7e:1d:26:92:
         a7:56:39:c9:e4:d2:ad:ec:83:ab:3c:72:03:ef:bd:7a:d2:1a:
         70:17:57:62:9b:6d:99:46:9e:74:f1:e6:1a:a5:1c:e0:6b:03:
         cc:a4:27:1d:6b:a6:22:a5
@mikegrima mikegrima merged commit a7fa132 into spulec:master Oct 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 93.568%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.