Add kinesisvideo #3271
Add kinesisvideo #3271
Conversation
toshitanian
force-pushed
the
add_kinesisvideo
branch
from
d75b0d9
to
97b1b27
Compare
|
@bblommers please check when you have time 🙏 |
moto/kinesisvideo/models.py
Outdated
| self.status = "ACTIVE" | ||
| self.version = self._get_random_string() | ||
| self.creation_time = datetime.utcnow() | ||
| stream_arn = "arn:aws:kinesisvideo:{}:123456789012:stream/{}/1598784211076".format( |
There was a problem hiding this comment.
I'm assuming this is the account ID? Let's import that from moto.core, to avoid magic numbers as much as possible
moto/kinesisvideo/models.py
Outdated
| ): | ||
| streams = [_ for _ in self.streams.values() if _.stream_name == stream_name] | ||
| if len(streams) > 0: | ||
| raise ResourceInUseException("The stream a already exists.") |
There was a problem hiding this comment.
Typo - or should it say The stream {stream_name} already exists?
There was a problem hiding this comment.
Thanks for finding out. updated.
6384f37
|
|
||
|
|
||
| @mock_kinesisvideo | ||
| def test_list(): |
There was a problem hiding this comment.
Can we split this test up? I prefer to have smaller test cases, i.e. test_list, test_create, test_create_with_same_name, etc.
| def test_kinesisvideo_list(): | ||
| backend = server.create_backend_app("kinesisvideo") | ||
| test_client = backend.test_client() | ||
| # do test |
There was a problem hiding this comment.
Is this test necessary, if it's already covered by the boto3 test?
There was a problem hiding this comment.
It's better to have test for moto_server. I added assert of response code to make sure that the server is up.
a7b46c6
|
@bblommers changed for reviews. |
|
This is now part of moto >= 1.3.15.dev1042 |
Added basic operations of
kinesisvideocreate_streamdescribe_streamlist_streamsdelete_streamget_data_endpoint