Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't close autocompletion menu when AltGr is pressed #11321

Merged
merged 3 commits into from Jan 17, 2020
Merged

PR: Don't close autocompletion menu when AltGr is pressed #11321

merged 3 commits into from Jan 17, 2020

Conversation

MaxGyver83
Copy link
Contributor

Description of Changes

When you enter one or more letters and then press tab in the spyder editor, you get an autocompletion popup window. With this pull request the popup window doesn't close on pressing the AltGr key anymore.

I've added a new variable (altgr) that will be true if the pressed key is AltGr. This variable is being checked in order to identify modifier keys.

I made this change because in my keyboard layout (and others like Neo2 and Aus der Neo-Welt) the down arrow can be sent with AltGr+D, so the popup window shouldn't be closed when AltGr is pressed.

Issue(s) Resolved

Fixes #11293

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: MaxGyver83

@pep8speaks
Copy link

pep8speaks commented Jan 15, 2020

Hello @MaxGyver83! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-15 20:09:30 UTC

@dalthviz dalthviz changed the title don't close autocompletion menu when AltGr is pressed PR: Don't close autocompletion menu when AltGr is pressed Jan 15, 2020
@ccordoba12 ccordoba12 added this to the v4.0.2 milestone Jan 16, 2020
@ccordoba12
Copy link
Member

@dalthviz, is this ready to be merged?

@MaxGyver83
Copy link
Contributor Author

From my side it's ready! :-)

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxGyver83 ! LGTM @ccordoba12 👍

@ccordoba12 ccordoba12 merged commit dba57c8 into spyder-ide:4.x Jan 17, 2020
ccordoba12 added a commit that referenced this pull request Jan 17, 2020
@MaxGyver83 MaxGyver83 deleted the dont-close-autocompletion-menu-when-pressing-altgr branch January 17, 2020 20:12
@goanpeca goanpeca modified the milestones: v4.0.2, v4.1.0 Jan 24, 2020
@ccordoba12 ccordoba12 modified the milestones: v4.2.0, v4.1.0 Jan 24, 2020
@goanpeca goanpeca removed this from the v4.1.0 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants