PR: Don't close autocompletion menu when AltGr is pressed#11321
Merged
ccordoba12 merged 3 commits intospyder-ide:4.xfrom Jan 17, 2020
MaxGyver83:dont-close-autocompletion-menu-when-pressing-altgr
Merged
PR: Don't close autocompletion menu when AltGr is pressed#11321ccordoba12 merged 3 commits intospyder-ide:4.xfrom MaxGyver83:dont-close-autocompletion-menu-when-pressing-altgr
ccordoba12 merged 3 commits intospyder-ide:4.xfrom
MaxGyver83:dont-close-autocompletion-menu-when-pressing-altgr
Conversation
|
Hello @MaxGyver83! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-01-15 20:09:30 UTC |
dalthviz
reviewed
Jan 15, 2020
dalthviz
changed the title
dalthviz
added
component:Editor
component:Code Completion and linting
and removed
component:Editor
labels
Member
|
@dalthviz, is this ready to be merged? |
Contributor
Author
|
From my side it's ready! :-) |
dalthviz
approved these changes
Jan 16, 2020
ccordoba12
added a commit
that referenced
this pull request
Jan 17, 2020
MaxGyver83
deleted the
dont-close-autocompletion-menu-when-pressing-altgr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
When you enter one or more letters and then press tab in the spyder editor, you get an autocompletion popup window. With this pull request the popup window doesn't close on pressing the AltGr key anymore.
I've added a new variable (altgr) that will be true if the pressed key is AltGr. This variable is being checked in order to identify modifier keys.
I made this change because in my keyboard layout (and others like Neo2 and Aus der Neo-Welt) the down arrow can be sent with AltGr+D, so the popup window shouldn't be closed when AltGr is pressed.
Issue(s) Resolved
Fixes #11293
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: MaxGyver83