New Spyder 3 icons for run-cell and run-cell inplace #2511
Conversation
|
They're nice! Thanks @SylvainCorlay! But what about using a different color other than yellow for the selected area? Thoughts? @goanpeca, do you have something to say? |
|
Not really :-) |
|
It is the yellow of the Python logo! |
SylvainCorlay
force-pushed
the
runcell-icons
branch
from
b05fdfb
to
56de4dd
Compare
|
Rebased. |
|
@SylvainCorlay, could you add a border around the white rectangle that represents the file? It's kind of hard to see it with no border :-) On a second thought, I think yellow is fine to represent cells (after all, that's the color used in Matlab). But could you make it a little bit lighter? I mean, not so yellow? |
|
Yeah I thought of adding a border or a shadow for the document. For the color, we could use the same as the highlighted cell color in the Spyder syntax coloring theme. |
|
+1 to both :-) |
|
We could actually be super fancy and make certain icon colors depend on syntax coloring theme - for another PR. |
|
Sounds cool! But I agree, for another PR. El 03/07/15 a las 12:43, Sylvain Corlay escribió:
|
|
New version. The yellow from the Spyder coloring scheme was not distinguishable from the white so I added a cell border. |
I can change the document shadow to a border in a different PR. |
|
@SylvainCorlay, could you change the shadow to a border in this PR? After all, the idea is to provide a much version for our cell icons here, right? ;-) |
|
It is already clearly better than the current Spyder 3 icons. Just that I foresee a long discussion on the shape and colors of the run-cell icons. I can open another PR right away. |
|
@ccordoba12 here is the latest screenshot. |
|
For IPython
|
|
Ok, merging this for @SylvainCorlay mental health ;-) |
New Spyder 3 icons for run-cell and run-cell inplace
|
Yes I liked how @ccordoba12 said that we should actually use the first version after 10 iterations. 😄 |
Pixel perfect in 16x16. This addresses the comments on these icons in #2490.