Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add regex to highlight decorators #3654

Merged
merged 1 commit into from
Nov 21, 2016
Merged

PR: Add regex to highlight decorators #3654

merged 1 commit into from
Nov 21, 2016

Conversation

rlaverde
Copy link
Member

@rlaverde rlaverde commented Nov 5, 2016 •
edited by goanpeca
Loading

Fixes #3608

I fixed it in a really simple way, I reused instance decorator, is that ok? or should I add a new color theme color for decorators?

@goanpeca
Copy link
Member

goanpeca commented Nov 5, 2016

What does pygments call decorators? does it give it a different meaning/name?

@ccordoba12 ccordoba12 added this to the v3.1 milestone Nov 6, 2016
@ccordoba12
Copy link
Member

ccordoba12 commented Nov 6, 2016 •
edited
Loading

@rlaverde, could you post a screenshot?

@goanpeca, we don't use Pygments for Python files. We have our highlighter for them :-)

@rlaverde
Copy link
Member Author

rlaverde commented Nov 6, 2016 •
edited
Loading

@ccordoba12
decorators

@goanpeca
Copy link
Member

@ccordoba12 and @Nodd are you ok with this?

@goanpeca goanpeca changed the title Add regex to highlight decorators PR: Add regex to highlight decorators Nov 11, 2016
@ccordoba12
Copy link
Member

Yep, merging. Thanks @rlaverde!

@ccordoba12 ccordoba12 merged commit 551f681 into spyder-ide:3.x Nov 21, 2016
ccordoba12 added a commit that referenced this pull request Nov 21, 2016
@ccordoba12
Merge from 3.x: PR #3654
5ad826d 
Fixes #3608
@rlaverde rlaverde deleted the highlight-decorators branch November 21, 2016 00:46
@rlaverde rlaverde mentioned this pull request Dec 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rlaverde rlaverde

Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rlaverde @goanpeca @ccordoba12