Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Make status bar widgets to have a fixed width #4045

Merged
merged 4 commits into from
Jun 3, 2017

Conversation

mariacamilarg
Copy link
Contributor

Fixes #2238

@mariacamilarg mariacamilarg added this to the v3.2 milestone Jan 25, 2017
@mariacamilarg mariacamilarg self-assigned this Jan 25, 2017
@ccordoba12
Copy link
Member

Could you post screenshots of before and after this change?

@mariacamilarg
Copy link
Contributor Author

mariacamilarg commented Jan 27, 2017

@ccordoba12 Sure:

image

image

I don't know if it is easy to see, but the widths of the labels are fixed no matter the number. It was kinda tricky taking the screenshots but the width in both is the same.

@ccordoba12
Copy link
Member

Looks good to me. @goanpeca, do you agree?

@goanpeca
Copy link
Member

Yes and no, I think what we should aim for is to have widgets aligned to the right as well, so not only setting a fixed width (a bit arbitrarily at the moment), but also using strecthes in the Layout definition.

So for example between the CPU text and the 29% there should be a stretch so that the widget move to the right, so they are right aligned.

@goanpeca
Copy link
Member

goanpeca commented Jan 27, 2017

So that the widget looks like


CPU     15%
CPU      5%

and not

CPU     15%
CPU     5%

I exaggerated the space so that you get the idea :-p

@ccordoba12 ccordoba12 modified the milestones: v3.2, v3.3 Feb 14, 2017
@ccordoba12 ccordoba12 changed the title PR: Status bar widgets with fixed width PR: Make status bar widgets to have a fixed width Jun 3, 2017
@ccordoba12 ccordoba12 merged commit e969374 into spyder-ide:3.x Jun 3, 2017
ccordoba12 added a commit that referenced this pull request Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants