Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Don't show a file in the Editor immediately after it's selected in the switcher. #8836

Merged
merged 4 commits into from Mar 3, 2019

Conversation

juanis2112
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot (if affecting the UI)

I implemented an enter function so that users have to press enter to switch files in the file switcher and it does not displays while charging the file with the arrows.

Issue(s) Resolved

Fixes #
Item 8 of #8580

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
Juanis2112

@juanis2112 juanis2112 added this to the v4.0beta2 milestone Feb 24, 2019
@ccordoba12
Copy link
Member

@juanis2112, does this PR preserve the current behavior for the Symbol switcher? I mean, the idea is that after users select a symbol, we show it immediately in the Editor, but not for files.

@juanis2112
Copy link
Contributor Author

@juanis2112, does this PR preserve the current behavior for the Symbol switcher? I mean, the idea is that after users select a symbol, we show it immediately in the Editor, but not for files.

@ccordoba12 Yes, it preserves the current behavior. It still shows the symbol immediately after selecting it.

@ccordoba12
Copy link
Member

@ccordoba12 Yes, it preserves the current behavior.

Great, thanks a lot @juanis2112!

Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112 for the latest changes, I left some comments and please also check that the Symbol switcher functionality is preserved with the changes to handle the click :)

spyder/widgets/fileswitcher.py Outdated Show resolved Hide resolved
spyder/widgets/fileswitcher.py Outdated Show resolved Hide resolved
spyder/widgets/fileswitcher.py Outdated Show resolved Hide resolved
spyder/widgets/fileswitcher.py Show resolved Hide resolved
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanis2112 ! 👍

@dalthviz dalthviz merged commit 4e87e11 into spyder-ide:master Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants