New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix Help plugin string validation for the console #9166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3104dbb
to
265bac3
Compare
d48f725
to
7a585b2
Compare
I think I parsed this correctly and fixed up the various problems, but just letting you know in case I didn't; it was a tad garbled... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalthviz, last minor comments, then this should be ready. Thanks!
@dalthviz, this is ready, please don't add more commits here. I'll fix the Azure error and then merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here, thanks a lot @dalthviz!
Description of Changes
Fix validation to correctly check if an object is defined in the shell attached to the Help or current Console.
Issue(s) Resolved
Fixes #9143
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz