Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix Help plugin string validation for the console #9166

Merged
merged 7 commits into from Apr 24, 2019

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Apr 17, 2019

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot (if affecting the UI)

Fix validation to correctly check if an object is defined in the shell attached to the Help or current Console.

Issue(s) Resolved

Fixes #9143

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz dalthviz added this to the v3.3.5 milestone Apr 17, 2019
@dalthviz dalthviz self-assigned this Apr 17, 2019
@pep8speaks
Copy link

pep8speaks commented Apr 17, 2019

Hello @dalthviz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-24 12:02:06 UTC

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, I left a minor comment.

Please also add tests to catch the regressions reported on issues #9143 and #8762. Thanks!

spyder/plugins/help.py Show resolved Hide resolved
@CAM-Gerlach
Copy link
Member

Fix validation to correctly check if and object if denifed in the shell attached to the Help or current Console

I think I parsed this correctly and fixed up the various problems, but just letting you know in case I didn't; it was a tad garbled...

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, last minor comments, then this should be ready. Thanks!

spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
spyder/app/tests/test_mainwindow.py Outdated Show resolved Hide resolved
@ccordoba12
Copy link
Member

@dalthviz, this is ready, please don't add more commits here. I'll fix the Azure error and then merge.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, thanks a lot @dalthviz!

@ccordoba12 ccordoba12 merged commit 3b2719e into spyder-ide:3.x Apr 24, 2019
ccordoba12 added a commit that referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants