New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Examples to work with GxEPD 3.0+ #24

Merged
merged 2 commits into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@JPRuskin
Contributor

JPRuskin commented Oct 14, 2018

This commit updates the example code to work with the latest version of GxEPD.

As shown in the commit, the GxGDEH029A1 files were not changed but the method for referencing / including them was.

Sadly, this is a breaking change and the GxEPD 2.x library does not work with these changes in place.

It's possible that there's no value in the update currently, beyond reducing confusion in new users (see: #18). I would argue that this is worth it, though, as it is far simpler to work with.

It also adds the undocumented library requirements on the example readme.md for Weather (Time) and WebSocketDraw (WebSockets), and corrects the spelling of 'sketch'.

I have tested that this fixes the compile errors in all of the provided examples, and that running the "hello" example with the latest version of GxEPD works correctly on my Badgy v2.

If this PR is merged, #23 should be rejected or merged in first (for continuity).

This was referenced Oct 14, 2018

Update Examples to work with GxEPD 3.0+
This commit updates the example code to work with the latest version of GxEPD.

As shown in the [commit](ZinggJM/GxEPD@e286926), the GxGDEH029A1 files were not changed but the method for referencing / including them was.

It also adds the undocumented library requirements on the example readme.md for Weather (Time) and WebSocketDraw (WebSockets).
@JPRuskin

This comment has been minimized.

Contributor

JPRuskin commented Oct 19, 2018

@sqfmi : Any thoughts?

@sqfmi

This comment has been minimized.

Owner

sqfmi commented Oct 19, 2018

Thanks @JPRuskin, looks great! Thank you for your contribution!

@sqfmi sqfmi closed this Oct 19, 2018

@sqfmi sqfmi reopened this Oct 19, 2018

@sqfmi sqfmi merged commit b96ad23 into sqfmi:master Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment