New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Verify command #15

Closed
theory opened this Issue May 21, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@theory
Collaborator

theory commented May 21, 2012

Will run all scripts in the verify directory that correspond to currently-deployed changes. For reworked changes, only the most recent instance of the script should be run.

Also add a --verify option to deploy and rebase that will verify each step after it is deployed, and optionally roll back if the verify fails.

The thing that runs the scripts will vary by engine, but should be a reasonable default that can be replaced by a config variables. A verify script will be considered to have failed it the command does not return success (exitval 0).

theory added a commit that referenced this issue Dec 26, 2012

Add `verify_change()` to Engine.
Called by `deploy_change()` if the new `with_verify` attribute is true. If the
verify fails, the deploy will be considered to have failed and the revert
process will start. If the change has no verify script a message will be sent
to STDERR but the deploy will not be considered a failure (for now). Verify
scripts will still run in log-only mode. Ref #15.

theory added a commit that referenced this issue Dec 26, 2012

theory added a commit that referenced this issue Dec 27, 2012

theory added a commit that referenced this issue Dec 27, 2012

theory added a commit that referenced this issue Dec 27, 2012

First pass at `verify()`.
I have most of the logic I want in there. I think it's pretty good. Will start
on tests next, as there are likely a bazillion bugs. Ref #15.

theory added a commit that referenced this issue Dec 28, 2012

Complete testing and implementation of verify().
Next up, adding the command. Ref #15.
@theory

This comment has been minimized.

Show comment
Hide comment
@theory

theory Dec 29, 2012

Collaborator

Finally added the verify command itself in 2283d09. I think the only thing that still needs doing is to make sure that reworked changes are handled properly: I don't think earlier verify scripts should be run.

Collaborator

theory commented Dec 29, 2012

Finally added the verify command itself in 2283d09. I think the only thing that still needs doing is to make sure that reworked changes are handled properly: I don't think earlier verify scripts should be run.

@theory theory closed this Dec 29, 2012

theory added a commit that referenced this issue Dec 29, 2012

Skip verification for reworked changes.
Last knonw issue in issue #15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment