New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Moose to Mouse, 20-30% speed improvement #73

Merged
merged 3 commits into from Jan 11, 2013

Conversation

Projects
None yet
3 participants
@schwern
Contributor

schwern commented Jan 11, 2013

Pretty trivial change, only two hiccups. Had to leave in some Moose deps because they extend or consume Moose classes or roles.

Test suite dropped from 25s to 20s. t/sqitch foo went from 650ms to 500ms.

schwern added some commits Jan 11, 2013

Switch classes from Moose to Mouse.
This is just getting the classes switched.  Fortunately there's MouseX versions
of everything in use.

There's failures which will be addressed later.

Left a handful of the Moose classes in either because they're consuming Moose
roles or extending Moose classes.
@theory

This comment has been minimized.

Show comment
Hide comment
@theory

theory Jan 11, 2013

Collaborator

Notes:

  • Require Mouse v1.02
  • Require MouseX::Types::Path::Class v0.06.
  • Require Mouse::Meta::Attribute::Native v1.04 or v1.05
Collaborator

theory commented Jan 11, 2013

Notes:

  • Require Mouse v1.02
  • Require MouseX::Types::Path::Class v0.06.
  • Require Mouse::Meta::Attribute::Native v1.04 or v1.05
@theory

This comment has been minimized.

Show comment
Hide comment
@theory

theory Jan 11, 2013

Collaborator

Ref #69.

Collaborator

theory commented Jan 11, 2013

Ref #69.

@theory theory merged commit 3a2971c into sqitchers:master Jan 11, 2013

@gfx

This comment has been minimized.

Show comment
Hide comment
@gfx

gfx Jan 11, 2013

Hi, I fixed those incompatibilities as of Mouse 1.04, i.e. maybe_type() and $attr->default($instance).
So I recommend you to use new APIs for ease.

gfx commented Jan 11, 2013

Hi, I fixed those incompatibilities as of Mouse 1.04, i.e. maybe_type() and $attr->default($instance).
So I recommend you to use new APIs for ease.

@theory

This comment has been minimized.

Show comment
Hide comment
@theory

theory Jan 11, 2013

Collaborator

Cool, thanks @gfx!

Collaborator

theory commented Jan 11, 2013

Cool, thanks @gfx!

theory added a commit that referenced this pull request Jan 11, 2013

@schwern schwern referenced this pull request May 2, 2013

Open

Switch To Moo #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment