Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions to initialize embedding service #1053

Merged
merged 4 commits into from Aug 21, 2019

Conversation

@yhjust1
Copy link
Contributor

yhjust1 commented Aug 20, 2019

Part of #1036 , work for issue #986 .

  • python/common/embedding_service.py create pod, and create a redis cluster.
  • python/test/embedding_service_test.py test embedding_service.
@yhjust1

This comment has been minimized.

Copy link
Contributor Author

yhjust1 commented Aug 20, 2019

I will move embedding_service.py to elasticdl/python/master .

@yhjust1 yhjust1 requested review from skydoorkai, terrytangyuan and ywskycn Aug 20, 2019
else:
return redis_cluster

def _pos_int(arg):

This comment has been minimized.

Copy link
@terrytangyuan

terrytangyuan Aug 21, 2019

Collaborator

Reuse existing function

This comment has been minimized.

Copy link
@yhjust1

yhjust1 Aug 21, 2019

Author Contributor

Oh! I forgot that the function has been moved to common/args.py

"--cluster_node_timeout",
default=2000,
type=self._pos_int,
help="The number of redis instances",

This comment has been minimized.

Copy link
@terrytangyuan

terrytangyuan Aug 21, 2019

Collaborator

wrong comment

return args

def start_redis_service(self):
logger.info("Starting redis server ...")

This comment has been minimized.

Copy link
@terrytangyuan

terrytangyuan Aug 21, 2019

Collaborator

Would be useful to print out the service args as well

@yhjust1 yhjust1 merged commit a0946f9 into develop Aug 21, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@yhjust1 yhjust1 deleted the embedding_service branch Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.