Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for dumping YAML file of the ElasticDL job #1526

Merged
merged 9 commits into from Nov 27, 2019
Merged

Conversation

@ywskycn
Copy link
Collaborator

ywskycn commented Nov 27, 2019

Another option to start the job. Not calling the k8s API, but dumping a YAML file and users can use the YMAL to start the job.

redis-py-cluster

This comment has been minimized.

Copy link
@skydoorkai

skydoorkai Nov 27, 2019

Collaborator

Why redis-py-cluster is still needed?

This comment has been minimized.

Copy link
@ywskycn

ywskycn Nov 27, 2019

Author Collaborator

oh, I think here I just add a new blank line there. redis-py-cluster is there before.. Not sure whether we have removed all redis code.

@ywskycn ywskycn merged commit 18bf078 into develop Nov 27, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ywskycn ywskycn deleted the weiyan-print-yaml branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.