Refine embedding table info #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwpyr
approved these changes
Feb 21, 2020
skydoorkai
reviewed
Feb 21, 2020
| @@ -49,7 +49,7 @@ func (model *Model) SetEmbeddingTableInfo(info *proto.EmbeddingTableInfo) { | |||
|
|
|||
| // InitFromModelPB inits the model from model PB | |||
| func (model *Model) InitFromModelPB(pb *proto.Model) error { | |||
| for _, v := range pb.EmbeddingTableInfo { | |||
| for _, v := range pb.EmbeddingTableInfos { | |||
There was a problem hiding this comment.
Info has no plural form.
There was a problem hiding this comment.
How about change Info to Desc? Desc is short for Description
There was a problem hiding this comment.
descriptions/attributes/properties/information. Hard to choose a better one.
We can keep to use EmbeddingTableInfos, since it can be understood.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
EmbeddingTableInfotoEmbeddingTableDescin Model messge