_get_column_info() missing 1 required positional argument: 'comment' in SQLAlchemy 1.2.0

[jleclanche]

sqlalchemy-redshift/sqlalchemy_redshift/dialect.py

Line 607 in 92852b7

column_info = super(RedshiftDialect, self)._get_column_info(

This breaks, because this was added:

http://docs.sqlalchemy.org/en/latest/changelog/changelog_12.html#change-3f38508932257c303017b1276f285c39

When it's called from get_columns():

sqlalchemy-redshift/sqlalchemy_redshift/dialect.py

Lines 406 to 409 in 92852b7

	column_info = self._get_column_info(
	name=col.name, format_type=col.format_type,
	default=col.default, notnull=col.notnull, domains=domains,
	enums=[], schema=col.schema, encode=col.encode)

Because comment is missing from there.

[jleclanche]

Reference commit: https://bitbucket.org/zzzeek/sqlalchemy/commits/fadb8d61babb

[jleclanche]

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

[jklukas]

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

I don't know that it would particularly help, since tests only get run when we new commits get sent to PRs. Months can go by without any activity here.

[jklukas]

This looks potentially messy if we want to maintain compatibility with SQLA pre-1.2.0 since the new comment parameter is the postgres driver doesn't have a default. We'd need to check the sqlalchemy library version or catch an error to dispatch to a different signature.

@graingert - Do you have thoughts about whether we could make SQAlchemy 1.2.0 the minimum required version for the next release?

[jleclanche]

Months can go by without any activity here.

I think we can cron travis jobs nowadays.

[jklukas]

For review: #139

[jklukas]

Addressed in 0.7.1: https://pypi.python.org/pypi?name=sqlalchemy-redshift&version=0.7.1&:action=display