New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_get_column_info() missing 1 required positional argument: 'comment' in SQLAlchemy 1.2.0 #138

Closed
jleclanche opened this Issue Dec 27, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@jleclanche
Contributor

jleclanche commented Dec 27, 2017

column_info = super(RedshiftDialect, self)._get_column_info(

This breaks, because this was added:

http://docs.sqlalchemy.org/en/latest/changelog/changelog_12.html#change-3f38508932257c303017b1276f285c39

When it's called from get_columns():

column_info = self._get_column_info(
name=col.name, format_type=col.format_type,
default=col.default, notnull=col.notnull, domains=domains,
enums=[], schema=col.schema, encode=col.encode)

Because comment is missing from there.

@jleclanche

This comment has been minimized.

Show comment
Hide comment
@jleclanche
Contributor

jleclanche commented Dec 27, 2017

@jleclanche

This comment has been minimized.

Show comment
Hide comment
@jleclanche

jleclanche Dec 27, 2017

Contributor

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

Contributor

jleclanche commented Dec 27, 2017

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Jan 4, 2018

Collaborator

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

I don't know that it would particularly help, since tests only get run when we new commits get sent to PRs. Months can go by without any activity here.

Collaborator

jklukas commented Jan 4, 2018

Would it be crazy to add tests against sqlalchemy master branch to avoid getting caught up on short notice like this in the future?

I don't know that it would particularly help, since tests only get run when we new commits get sent to PRs. Months can go by without any activity here.

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Jan 4, 2018

Collaborator

This looks potentially messy if we want to maintain compatibility with SQLA pre-1.2.0 since the new comment parameter is the postgres driver doesn't have a default. We'd need to check the sqlalchemy library version or catch an error to dispatch to a different signature.

@graingert - Do you have thoughts about whether we could make SQAlchemy 1.2.0 the minimum required version for the next release?

Collaborator

jklukas commented Jan 4, 2018

This looks potentially messy if we want to maintain compatibility with SQLA pre-1.2.0 since the new comment parameter is the postgres driver doesn't have a default. We'd need to check the sqlalchemy library version or catch an error to dispatch to a different signature.

@graingert - Do you have thoughts about whether we could make SQAlchemy 1.2.0 the minimum required version for the next release?

@jleclanche

This comment has been minimized.

Show comment
Hide comment
@jleclanche

jleclanche Jan 4, 2018

Contributor

Months can go by without any activity here.

I think we can cron travis jobs nowadays.

Contributor

jleclanche commented Jan 4, 2018

Months can go by without any activity here.

I think we can cron travis jobs nowadays.

jklukas added a commit that referenced this issue Jan 16, 2018

@jklukas jklukas referenced this issue Jan 16, 2018

Merged

Fix incompatibility of reflection with SQA 1.2.0 #139

4 of 4 tasks complete
@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Jan 16, 2018

Collaborator

For review: #139

Collaborator

jklukas commented Jan 16, 2018

For review: #139

jklukas added a commit that referenced this issue Jan 17, 2018

Fix incompatibility of reflection with SQA 1.2.0 (#139)
* Fix incompatibility of reflection with SQA 1.2.0

Addresses #138
@jklukas

This comment has been minimized.

Show comment
Hide comment
Collaborator

jklukas commented Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment