New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tests to tolerate new default column encodings in Redshift #114

Merged
merged 1 commit into from Apr 27, 2017

Conversation

Projects
None yet
2 participants
@jklukas
Collaborator

jklukas commented Apr 26, 2017

In order to get a new release out the door, we need to get tests passing.

Looks like Redshift changed the behavior for default encodings. Previously, all columns were RAW by default. Now, encoding is chosen per column type as discussed in http://docs.aws.amazon.com/redshift/latest/dg/c_Compression_encodings.html

I'll be pushing changes to this branch as I work.

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

@jklukas jklukas changed the title from WIP: Fix tests for new encoding defaults to Allow tests to tolerate new default column encodings in Redshift Apr 26, 2017

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Apr 26, 2017

Collaborator

Tests are now passing locally and I'm removing the WIP label. This is ready for review.

Collaborator

jklukas commented Apr 26, 2017

Tests are now passing locally and I'm removing the WIP label. This is ready for review.

@jklukas jklukas requested a review from graingert Apr 26, 2017

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Apr 26, 2017

Collaborator

cc @ericness who was interested in getting recent changes released, which will rely on this.

Collaborator

jklukas commented Apr 26, 2017

cc @ericness who was interested in getting recent changes released, which will rely on this.

@jklukas jklukas merged commit fb4d146 into master Apr 27, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jklukas jklukas deleted the fix-tests branch Apr 27, 2017

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Apr 27, 2017

Collaborator

@jklukas what's your PyPI username?

Collaborator

graingert commented Apr 27, 2017

@jklukas what's your PyPI username?

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Apr 27, 2017

Collaborator

I'm Jeff.Klukas on pypi.

Collaborator

jklukas commented Apr 27, 2017

I'm Jeff.Klukas on pypi.

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas May 4, 2017

Collaborator

@graingert - Have you gotten a chance to add me on PyPI? It would be good for me to have the chance to do a release and make sure I understand the steps. I'd plan to document those as well as I go through.

Collaborator

jklukas commented May 4, 2017

@graingert - Have you gotten a chance to add me on PyPI? It would be good for me to have the chance to do a release and make sure I understand the steps. I'd plan to document those as well as I go through.

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert May 4, 2017

Collaborator

@jklukas I mostly just do

# ~/.pypirc
[zest.releaser]
create-wheels = yes
vim HISTORY.rst
python3.6 -m venv ~/.virtualenvs/dist
workon dist
pip install -U pip setuptools wheel
pip install -U tox zest.releaser
fullrelease  # follow prompts, use semver ish with versions.
Collaborator

graingert commented May 4, 2017

@jklukas I mostly just do

# ~/.pypirc
[zest.releaser]
create-wheels = yes
vim HISTORY.rst
python3.6 -m venv ~/.virtualenvs/dist
workon dist
pip install -U pip setuptools wheel
pip install -U tox zest.releaser
fullrelease  # follow prompts, use semver ish with versions.
@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas May 4, 2017

Collaborator

I just performed a release. Releaser is amazing. Version 0.6.0 is on PyPI.

Collaborator

jklukas commented May 4, 2017

I just performed a release. Releaser is amazing. Version 0.6.0 is on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment