Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add acm cert bundle #130

Closed
wants to merge 3 commits into from
Closed

Conversation

@rhockenbury
Copy link

@rhockenbury rhockenbury commented Sep 20, 2017

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst
@jklukas
Copy link
Collaborator

@jklukas jklukas commented Sep 20, 2017

I'll pull this down and run tests against the cluster.

Copy link
Collaborator

@graingert graingert left a comment

You need to update the manifest etc

@rhockenbury
Copy link
Author

@rhockenbury rhockenbury commented Sep 20, 2017

@graingert

Updated.

@jklukas
Copy link
Collaborator

@jklukas jklukas commented Sep 20, 2017

I'm seeing errors when running the tests against Redshift which look entirely unrelated:

E       assert 'CREATE TABLE...ISTSTYLE EVEN' == 'CREATE TABLE ...ISTSTYLE EVEN'
E         Skipping 89 identical leading characters in diff, use -v to show
E         -  INTEGER, CONSTRAINT reflection_composite_fk_constraint_pkey PRIMARY KEY (id), CONSTRAINT reflection_composite_fk_constraint_col1_fkey FOREIGN KEY(col1, col2) REFERENCES reflection_pk_constraint (col1, col2) ) DISTSTYLE EVEN
E         +  INTEGER, PRIMARY KEY (id), FOREIGN KEY(col1, col2) REFERENCES reflection_pk_constraint (col1, col2) ) DISTSTYLE EVEN

Could this be a regression from a recent change in this repo, or does this look like a change in Redshift's behavior? It looks like constraints are being returned differently.

@jklukas
Copy link
Collaborator

@jklukas jklukas commented Sep 20, 2017

Travis is showing InterpreterNotFound errors, which I've also not seen.

@rhockenbury
Copy link
Author

@rhockenbury rhockenbury commented Sep 20, 2017

Looking at the travis logs, I'm seeing:

E: Failed to fetch http://dl.hhvm.com/ubuntu/dists/trusty/main/binary-i386/Packages 503 Service Unavailable [IP: 140.211.166.134 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.

@jklukas
Copy link
Collaborator

@jklukas jklukas commented Sep 20, 2017

Looks like the travis failures are recovering. I kicked off restarts of the last 2 failing test scenarios.

@jklukas
Copy link
Collaborator

@jklukas jklukas commented Sep 20, 2017

I'm getting the errors discussed in #130 (comment) when running master branch tests against Redshift, so I think something changed with Redshift itself that will need to be fixed separately from this issue.

@mjschultz
Copy link
Contributor

@mjschultz mjschultz commented Sep 20, 2017

It would be nice to verify the new bundle against the new certs AWS will be using prior to them actually forcing everyone to changeover. From the email and page when I read it that doesn't seem possible right now (which scares me).

I can open a support issue inquiring about that ability unless you have that ability?

@jklukas
Copy link
Collaborator

@jklukas jklukas commented Sep 20, 2017

I'd love if you go ahead and open the support case, @mjschultz

Copy link
Collaborator

@jklukas jklukas left a comment

To my knowledge, all test failures actually related to this change are now resolved.

@jleclanche jleclanche mentioned this pull request Sep 23, 2017
4 of 4 tasks complete
@jleclanche
Copy link
Contributor

@jleclanche jleclanche commented Sep 23, 2017

I've filed an alternative pr in #132 which cleans up the issues here and some other things.

@graingert
Copy link
Collaborator

@graingert graingert commented Sep 25, 2017

closing in favor of #132

@graingert graingert closed this Sep 25, 2017
graingert added a commit that referenced this pull request Sep 25, 2017
* Move redshift-ssl-ca-cert.pem -> redshift-ca-bundle.crt

* Use certificate directly from the package in test_default_ssl

* Update redshift certificate to transitional bundle

Closes #129
Closes #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.