Conversation
jklukas
commented
Jan 17, 2018
| encodings_removed = re.sub(r'\s+ENCODE\s+\w+', '', query) | ||
| return re.sub(r'\s+', ' ', encodings_removed).strip() | ||
| query = re.sub(r'\s+ENCODE\s+\w+', '', query) | ||
| query = re.sub(r'\s+CONSTRAINT\s+[a-zA-Z0-9_".]+', '', query) |
Member
Author
There was a problem hiding this comment.
This scrubs out all CONSTRAINT constraintname strings out of DDL when we're comparing, and we're able to avoid changing the expected DDL we code in the tests.
jklukas
commented
Jan 17, 2018
| deps = | ||
| requests==2.7.0 | ||
| psycopg2==2.6.0 | ||
| psycopg2==2.7.3.2 |
Member
Author
There was a problem hiding this comment.
This fixes a problem with the postgres version available on travis. See psycopg/psycopg2#594
of sync with changes in Redshift and SQLAlchemy. Fixes #131
Member
Author
|
Travis run is clean! |
Member
|
I can't believe bigcrunch is still working after all this time |
graingert
approved these changes
Jan 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a variety of bugs in the tests where we've drifted out of sync with changes in Redshift and SQLAlchemy.
Fixes #131
Todos