Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support 3.7, run Tox with same version #153

Merged
merged 6 commits into from Nov 30, 2018

Conversation

@dargueta
Copy link
Contributor

@dargueta dargueta commented Oct 8, 2018

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst
  • Add official Python 3.7 support.
  • Add a python_requires restriction in setup.py so pip will refuse to install the package on unsupported versions.
  • Run tox on the same Python version as the environment it's testing. This helps reduce the number of variables to consider when something really weird happens like this bug in setuptools.
Copy link
Collaborator

@jklukas jklukas left a comment

Sorry that we haven't been monitoring PRs closely. Requested a few changes, but overall this looks good to go. I'll merge as soon as the comments are addressed.

.travis.yml Outdated Show resolved Hide resolved
CHANGES.rst Show resolved Hide resolved
dargueta added 3 commits Nov 30, 2018
@dargueta dargueta force-pushed the dargueta:tox-py3 branch from 70b0486 to 404a276 Nov 30, 2018
@jklukas jklukas merged commit f14a5b1 into sqlalchemy-redshift:master Nov 30, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dargueta dargueta deleted the dargueta:tox-py3 branch Nov 30, 2018
@jklukas
Copy link
Collaborator

@jklukas jklukas commented Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants