Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
dargueta
added some commits
Sep 4, 2018
jklukas
requested changes
Nov 29, 2018
Sorry that we haven't been monitoring PRs closely. Requested a few changes, but overall this looks good to go. I'll merge as soon as the comments are addressed.
.travis.yml Outdated
dargueta
added some commits
Nov 30, 2018
dargueta
force-pushed the
dargueta:tox-py3
branch
from
70b0486
to
404a276
Nov 30, 2018
jklukas
merged commit f14a5b1
into
sqlalchemy-redshift:master
Nov 30, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
dargueta
deleted the
dargueta:tox-py3
branch
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dargueta commentedOct 8, 2018
•
edited
Todos
python_requiresrestriction insetup.pysopipwill refuse to install the package on unsupported versions.toxon the same Python version as the environment it's testing. This helps reduce the number of variables to consider when something really weird happens like this bug insetuptools.