Officially support 3.7, run Tox with same version #153
Conversation
|
Sorry that we haven't been monitoring PRs closely. Requested a few changes, but overall this looks good to go. I'll merge as soon as the comments are addressed. |
jklukas
merged commit f14a5b1
into
sqlalchemy-redshift:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Todos
python_requiresrestriction insetup.pysopipwill refuse to install the package on unsupported versions.toxon the same Python version as the environment it's testing. This helps reduce the number of variables to consider when something really weird happens like this bug insetuptools.