-
Notifications
You must be signed in to change notification settings - Fork 158
Feature/header #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/header #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure here looks good. Left a few comments on things to fix up.
If you address those fixes and add an entry to the CHANGES file, this looks good to me.
cc @graingert
…rst; remove IDEs from .gitignore
@jklukas thanks for the quick review 👍 Updated the PR based on your comments. Let me know if you would like any other changes. |
If you accept the CHANGES change, I'll go ahead and merge this. |
Co-Authored-By: ameier38 <ameier38@gmail.com>
Change Summary
header
optionunload_location
parameterTodos