Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/header #156

Merged
merged 6 commits into from Dec 10, 2018
Merged

Feature/header #156

merged 6 commits into from Dec 10, 2018

Conversation

@ameier38
Copy link
Contributor

@ameier38 ameier38 commented Nov 13, 2018

Change Summary

  • add header option
UNLOAD ('select-statement')
TO 's3://object-path/name-prefix'
authorization
[ option [ ... ] ]

where option is

{ MANIFEST [ VERBOSE ] 
| HEADER                                                      <<<<<
| DELIMITER [ AS ] 'delimiter-char' 
| FIXEDWIDTH [ AS ] 'fixedwidth-spec' }  
| ENCRYPTED
| BZIP2  
| GZIP     
| ADDQUOTES 
| NULL [ AS ] 'null-string'
| ESCAPE
| ALLOWOVERWRITE
| PARALLEL [ { ON | TRUE } | { OFF | FALSE } ]
| MAXFILESIZE [AS] max-size [ MB | GB ] ]
| REGION [AS] 'aws-region'
  • fix unload_location parameter

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst
Copy link
Collaborator

@jklukas jklukas left a comment

The structure here looks good. Left a few comments on things to fix up.

If you address those fixes and add an entry to the CHANGES file, this looks good to me.

cc @graingert

sqlalchemy_redshift/commands.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
sqlalchemy_redshift/commands.py Outdated Show resolved Hide resolved
ameier38 added 2 commits Nov 13, 2018
…rst; remove IDEs from .gitignore
@ameier38
Copy link
Contributor Author

@ameier38 ameier38 commented Nov 13, 2018

@jklukas thanks for the quick review 👍

Updated the PR based on your comments. Let me know if you would like any other changes.

CHANGES.rst Show resolved Hide resolved
@jklukas
Copy link
Collaborator

@jklukas jklukas commented Nov 29, 2018

If you accept the CHANGES change, I'll go ahead and merge this.

jklukas and others added 2 commits Dec 8, 2018
Co-Authored-By: ameier38 <ameier38@gmail.com>
@jklukas jklukas merged commit 2b7ca95 into sqlalchemy-redshift:master Dec 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jklukas
Copy link
Collaborator

@jklukas jklukas commented Dec 11, 2018

@ameier38 ameier38 deleted the MoneyLion:feature/header branch Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants