Reflect column comments#186
Merged
Merged
Conversation
eeshugerman
commented
Dec 14, 2019
|
|
||
| - Expose supported types for import from the dialect | ||
| (`Issue #181 <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/issues/181>`_) | ||
| - Reflect column comments |
Contributor
Author
There was a problem hiding this comment.
There's no GitHub issue... should I create one?
jklukas
reviewed
Dec 17, 2019
| kw.pop('comment', None) | ||
| if sa.__version__ < '1.2.0': | ||
| # SQLAlchemy 1.2.0 introduced the 'comment' param | ||
| del kw['comment'] |
Member
There was a problem hiding this comment.
Can you explain why we need to invert this condition here? Is there ever a possibility that 'comment' will not exist in kwargs, and this could raise an exception?
Contributor
Author
There was a problem hiding this comment.
Nope, the only place this method is called is on line ~480 (above), and I've added the comment kwarg there, so this will never raise a KeyError.
It makes sense to invert the condition because otherwise it would be something like
if sa.__version__ >= '1.2.0':
pass
else:
del kw['comment']
Co-Authored-By: Jeff Klukas <jeff@klukas.net>
jklukas
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todos