Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing CASCADE option to DropMaterializedView #204

Merged
merged 1 commit into from Jun 1, 2020
Merged

Add Missing CASCADE option to DropMaterializedView #204

merged 1 commit into from Jun 1, 2020

Conversation

ewengillies
Copy link
Contributor

I followed the aws docs to the letter in terms of options for DROP MATERIALIZED VIEW. Unfortunately, they omitted the common CASCADE argument from this documentation.

I've added a boolean flag to support this option.

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

@ewengillies
Copy link
Contributor Author

I've play around with a few more DROP MATERIALIZED VIEW arguments, this the only missing one i can find.

jklukas
jklukas approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased and squashed to a single commit. Waiting for integration tests to run before merging.

@jklukas jklukas merged commit e2a0c06 into sqlalchemy-redshift:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklukas jklukas jklukas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewengillies @jklukas