Add Missing CASCADE option to DropMaterializedView#204
Merged
Conversation
Contributor
Author
|
I've play around with a few more |
jklukas
force-pushed
the
materialized_view
branch
from
a3353ab to
f0d73cb
Compare
jklukas
approved these changes
Jun 1, 2020
jklukas
left a comment
jklukas
left a comment
Member
There was a problem hiding this comment.
LGTM. I rebased and squashed to a single commit. Waiting for integration tests to run before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the
awsdocs to the letter in terms of options for DROP MATERIALIZED VIEW. Unfortunately, they omitted the commonCASCADEargument from this documentation.I've added a boolean flag to support this option.
Todos