Fix invalid SQLAlchemy version comparison

[GrayAn]

This fix resolves a bug with invalid SQLAlchemy version comparison in the _get_column_info method (see discussion in the Issue 195). It includes packaging library as a dependency.

One question bothers me: packaging is released under the BSD-2 license, so I should mention it in this repository somehow. Should I add its licence to the LICENSE file?

Todos

• MIT compatible
• Tests
• Documentation
• Updated CHANGES.rst

[jklukas]

packaging is released under the BSD-2 license, so I should mention it in this repository somehow

I don't have a great sense of the requirements in the BSD-2 and Apache licenses, but I would expect that nothing is strictly required here since we're only mentioning packaging as a dependency rather than redistributing its code. We publish wheels, etc. that contain only the sqlalchemy-redshift code and it is up to pip or other dependency management software to fetch dependencies like packaging.

It's entirely possible that I am wrong or that I'm missing perspective about common practice.

[jklukas]

This change looks good and I'm happy to go ahead and merge it. Let me know if you'd like me to hold off, though, if you want to do some more investigation about altering our LICENSE.

[GrayAn]

Great! I think I'm overreacting to this license issue. I checked several popular python packages and it seems it works just like you described. So the PR is ready to be merged I think.

[jklukas]

0.8.0 is now published, including this change.

[GrayAn]

Great, many thanks!