Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GEOMETRY, SUPER Redshift datatypes #235

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

Brooke-white
Copy link
Contributor

@Brooke-white Brooke-white commented Oct 19, 2021

Closes #209, #224. Adds support for Redshift SUPER and GEOMETRY datatypes.

credit to @rectalogic for their approach for SUPER datatype support, which I've duplicated in this PR.

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst

Copy link
Member

@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just kicked off integration tests. If those look good, we can go ahead and merge.

@Brooke-white
Copy link
Contributor Author

@jklukas -- did your test run for this change look ok?

@jklukas
Copy link
Member

jklukas commented Nov 3, 2021

@jklukas -- did your test run for this change look ok?

Thanks for the reminder. That run was flaky and errored out. I'm running a new one now. Note that since you now have commit access, you can make future PRs via a branch on this repo, which will automatically kick off the integration tests.

You can also kick off integation tests for forks by verifying that the content isn't malicious, and then pushing the changeset to a branch on this repo. I use https://github.com/jklukas/git-push-fork-to-upstream-branch to manage that workflow.

@jklukas jklukas merged commit af22877 into sqlalchemy-redshift:main Nov 3, 2021
@jklukas
Copy link
Member

jklukas commented Nov 3, 2021

This change is now released in 0.8.8

@jklukas jklukas mentioned this pull request Nov 3, 2021
@Brooke-white Brooke-white mentioned this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Redshift GEOMETRY types
2 participants