New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all options to UnloadFromSelect, with SQLi protection #27

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Projects
None yet
4 participants
@graingert
Collaborator

graingert commented Aug 29, 2015

No description provided.

return str(q.compile(dialect=RedshiftDialect(),
compile_kwargs={'literal_binds': True}))
return str(q.compile(

This comment has been minimized.

@graingert

graingert Aug 29, 2015

Collaborator

I updated this to match the same helper functions in test_unload_from_select

@graingert

graingert Aug 29, 2015

Collaborator

I updated this to match the same helper functions in test_unload_from_select

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert
Collaborator

graingert commented Aug 31, 2015

@jklukas

View changes

Show outdated Hide outdated redshift_sqlalchemy/dialect.py Outdated
@jklukas

View changes

Show outdated Hide outdated redshift_sqlalchemy/dialect.py Outdated
@jklukas

View changes

Show outdated Hide outdated redshift_sqlalchemy/dialect.py Outdated
@@ -16,7 +16,7 @@ deps =
commands=flake8 redshift_sqlalchemy tests
[flake8]
max-line-length = 128
max-line-length = 89

This comment has been minimized.

@jklukas

jklukas Aug 31, 2015

Collaborator

Any reason not to set this to 80?

@jklukas

jklukas Aug 31, 2015

Collaborator

Any reason not to set this to 80?

This comment has been minimized.

@graingert

graingert Aug 31, 2015

Collaborator

I'm working on removing this line altogether. This PR is part of that work.

@graingert

graingert Aug 31, 2015

Collaborator

I'm working on removing this line altogether. This PR is part of that work.

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Aug 31, 2015

Collaborator

This is looking much nicer for the refactor. I like this PR.

Collaborator

jklukas commented Aug 31, 2015

This is looking much nicer for the refactor. I like this PR.

Add all options to UnloadFromSelect, with SQLi protection
validate credentials before format

Better exception text

prevent an empty FIXEDWITH string as that's an error.

graingert added a commit that referenced this pull request Aug 31, 2015

Merge pull request #27 from graingert/add-all-options-to-UnloadFromSe…
…lect-with-SQLi-protection

Add all options to UnloadFromSelect, with SQLi protection

@graingert graingert merged commit b48dbe7 into master Aug 31, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@graingert graingert deleted the add-all-options-to-UnloadFromSelect-with-SQLi-protection branch Aug 31, 2015

haleemur pushed a commit to haleemur/redshift_sqlalchemy that referenced this pull request Sep 2, 2015

Merge pull request sqlalchemy-redshift#27 from graingert/add-all-opti…
…ons-to-UnloadFromSelect-with-SQLi-protection

Add all options to UnloadFromSelect, with SQLi protection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment