New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode issue with SORTKEY on python 2 #34

Merged
merged 1 commit into from Sep 1, 2015

Conversation

Projects
None yet
3 participants
@bouk
Contributor

bouk commented Sep 1, 2015

This is to make sure unicode is supported in python2

@graingert

@graingert

View changes

Show outdated Hide outdated tests/test_ddl_compiler.py Outdated
@jklukas

View changes

Show outdated Hide outdated tests/test_ddl_compiler.py Outdated
@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Sep 1, 2015

Collaborator

+1

Collaborator

jklukas commented Sep 1, 2015

+1

@graingert

View changes

Show outdated Hide outdated redshift_sqlalchemy/dialect.py Outdated
@bouk

This comment has been minimized.

Show comment
Hide comment
@bouk

bouk Sep 1, 2015

Contributor

@graingert how's this look?

Contributor

bouk commented Sep 1, 2015

@graingert how's this look?

@graingert

View changes

Show outdated Hide outdated redshift_sqlalchemy/compat.py Outdated
@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Sep 1, 2015

Collaborator

Looks good to me, have a look at the fixes then update the issue name, changelog, squash etc

Collaborator

graingert commented Sep 1, 2015

Looks good to me, have a look at the fixes then update the issue name, changelog, squash etc

@bouk bouk changed the title from Use sqlalchemy.util.string_types to check if it's a string to Use a compatibility layer to check string types Sep 1, 2015

@bouk bouk changed the title from Use a compatibility layer to check string types to Fix unicode with SORTKEY on python 2 Sep 1, 2015

@bouk bouk changed the title from Fix unicode with SORTKEY on python 2 to Fix unicode issue with SORTKEY on python 2 Sep 1, 2015

@bouk

This comment has been minimized.

Show comment
Hide comment
@bouk

bouk Sep 1, 2015

Contributor

done

Contributor

bouk commented Sep 1, 2015

done

graingert added a commit that referenced this pull request Sep 1, 2015

Merge pull request #34 from bouk/check-unicode
Fix unicode issue with SORTKEY on python 2

@graingert graingert merged commit be53c70 into sqlalchemy-redshift:master Sep 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bouk bouk deleted the bouk:check-unicode branch Sep 1, 2015

haleemur pushed a commit to haleemur/redshift_sqlalchemy that referenced this pull request Sep 2, 2015

Merge pull request sqlalchemy-redshift#34 from bouk/check-unicode
Fix unicode issue with SORTKEY on python 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment