Fix unicode issue with SORTKEY on python 2 by bouk · Pull Request #34 · sqlalchemy-redshift/sqlalchemy-redshift

bouk · 2015-09-01T20:24:43Z

This is to make sure unicode is supported in python2

@graingert

graingert · 2015-09-01T20:27:59Z

You can use u'id' and this will work on both

The lint test runs on python 3 and throws an error for this unicode.

jklukas · 2015-09-01T20:31:00Z

+1

graingert · 2015-09-01T20:32:38Z

When was this added to sqlalchemy? Is it considered public?

hmm looking at it it's definitely not public. What would be the best way to go about this? If I were to copy over the code, the linter would complain about unicode or basestring

What about a compat.py with a # noqa line?

bouk · 2015-09-01T20:50:29Z

@graingert how's this look?

graingert · 2015-09-01T20:52:22Z

I prefer parenthesis with my tuples

can you move the noqa to this line?

Me too, I just copied the sa style. fixed

graingert · 2015-09-01T20:54:20Z

Looks good to me, have a look at the fixes then update the issue name, changelog, squash etc

bouk · 2015-09-01T20:57:36Z

done

Fix unicode issue with SORTKEY on python 2

graingert reviewed Sep 1, 2015
View reviewed changes

bouk force-pushed the check-unicode branch from 0d87242 to 617f13d Compare September 1, 2015 20:29

graingert reviewed Sep 1, 2015
View reviewed changes

bouk force-pushed the check-unicode branch 3 times, most recently from c30d2f6 to f705281 Compare September 1, 2015 20:50

graingert reviewed Sep 1, 2015
View reviewed changes

bouk force-pushed the check-unicode branch from f705281 to 2fb192a Compare September 1, 2015 20:53

bouk force-pushed the check-unicode branch from 2fb192a to 872c733 Compare September 1, 2015 20:54

bouk changed the title ~~Use sqlalchemy.util.string_types to check if it's a string~~ Use a compatibility layer to check string types Sep 1, 2015

bouk changed the title ~~Use a compatibility layer to check string types~~ Fix unicode with SORTKEY on python 2 Sep 1, 2015

bouk changed the title ~~Fix unicode with SORTKEY on python 2~~ Fix unicode issue with SORTKEY on python 2 Sep 1, 2015

Fix unicode issue with SORTKEY on python 2

55b0998

bouk force-pushed the check-unicode branch from 872c733 to 55b0998 Compare September 1, 2015 20:57

graingert added a commit that referenced this pull request Sep 1, 2015

Merge pull request #34 from bouk/check-unicode

be53c70

Fix unicode issue with SORTKEY on python 2

graingert merged commit be53c70 into sqlalchemy-redshift:master Sep 1, 2015

bouk deleted the check-unicode branch September 1, 2015 21:08

haleemur pushed a commit to haleemur/redshift_sqlalchemy that referenced this pull request Sep 2, 2015

Merge pull request sqlalchemy-redshift#34 from bouk/check-unicode

7202539

Fix unicode issue with SORTKEY on python 2

Conversation

bouk commented Sep 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklukas commented Sep 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bouk commented Sep 1, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

graingert commented Sep 1, 2015

Uh oh!

bouk commented Sep 1, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants