-
Notifications
You must be signed in to change notification settings - Fork 158
Make TRUNCATECOLUMNS optional, also add all other parameters #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e12a380
to
d906bef
Compare
1d48989
to
cda4d57
Compare
this breaks backwards comparability by removing some defaults eg: truncate_columns=True,
delimiter=',',
ignore_header=0,
empty_as_null=True,
blanks_as_null=True, |
cda4d57
to
bd95ed9
Compare
@jklukas I was wondering if I could have a set of AWS credentials that can only upload to an S3 bucket? (To be able to test this code properly) |
This needs a changelog update, and the docs updating. |
8fe388a
to
b040db5
Compare
b040db5
to
bd9b13f
Compare
47fc319
to
225f8a0
Compare
# found. After looking at a few session tokens they appear to be the same as | ||
# the aws_secret_access_key pattern, but much longer. An example token can be | ||
# found here: | ||
# http://docs.aws.amazon.com/STS/latest/APIReference/API_GetSessionToken.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thats pretty bad tom. http is deprecated
Looks good to me 👍 |
ACCEPTANYDATE | ||
TIMEFORMAT AS 'auto' | ||
""" % creds | ||
copy = dialect.CopyCommand( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
analogous code appears in the YPlan test suite but hits S3 and Redshift
Make TRUNCATECOLUMNS optional, also add all other parameters
No description provided.