Make TRUNCATECOLUMNS optional, also add all other parameters #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
add-missing-copy-command-args
branch
8 times, most recently
from
e12a380 to
d906bef
Compare
graingert
changed the title
graingert
force-pushed
the
add-missing-copy-command-args
branch
3 times, most recently
from
1d48989 to
cda4d57
Compare
|
this breaks backwards comparability by removing some defaults eg: truncate_columns=True,
delimiter=',',
ignore_header=0,
empty_as_null=True,
blanks_as_null=True, |
graingert
changed the title
graingert
force-pushed
the
add-missing-copy-command-args
branch
from
cda4d57 to
bd95ed9
Compare
graingert
changed the title
|
@jklukas I was wondering if I could have a set of AWS credentials that can only upload to an S3 bucket? (To be able to test this code properly) |
|
This needs a changelog update, and the docs updating. |
graingert
force-pushed
the
add-missing-copy-command-args
branch
4 times, most recently
from
8fe388a to
b040db5
Compare
graingert
force-pushed
the
add-missing-copy-command-args
branch
from
b040db5 to
bd9b13f
Compare
graingert
force-pushed
the
add-missing-copy-command-args
branch
from
47fc319 to
225f8a0
Compare
| # found. After looking at a few session tokens they appear to be the same as | ||
| # the aws_secret_access_key pattern, but much longer. An example token can be | ||
| # found here: | ||
| # http://docs.aws.amazon.com/STS/latest/APIReference/API_GetSessionToken.html |
There was a problem hiding this comment.
thats pretty bad tom. http is deprecated
|
Looks good to me 👍 |
| ACCEPTANYDATE | ||
| TIMEFORMAT AS 'auto' | ||
| """ % creds | ||
| copy = dialect.CopyCommand( |
There was a problem hiding this comment.
analogous code appears in the YPlan test suite but hits S3 and Redshift
graingert
added a commit
that referenced
this pull request
Sep 29, 2015
Make TRUNCATECOLUMNS optional, also add all other parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.