Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMake TRUNCATECOLUMNS optional, also add all other parameters #52
Conversation
graingert
changed the title from
add missing copy command args
to
WIP: add missing copy command args
Sep 24, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
graingert
Sep 26, 2015
Collaborator
this breaks backwards comparability by removing some defaults eg:
truncate_columns=True,
delimiter=',',
ignore_header=0,
empty_as_null=True,
blanks_as_null=True,|
this breaks backwards comparability by removing some defaults eg: truncate_columns=True,
delimiter=',',
ignore_header=0,
empty_as_null=True,
blanks_as_null=True, |
graingert
changed the title from
WIP: add missing copy command args
to
Add missing copy commands, allow disabling TRUNCATECOLUMNS
Sep 26, 2015
graingert
changed the title from
Add missing copy commands, allow disabling TRUNCATECOLUMNS
to
Make TRUNCATECOLUMNS optional, also add all other parameters
Sep 26, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
graingert
Sep 26, 2015
Collaborator
@jklukas I was wondering if I could have a set of AWS credentials that can only upload to an S3 bucket?
(To be able to test this code properly)
|
@jklukas I was wondering if I could have a set of AWS credentials that can only upload to an S3 bucket? (To be able to test this code properly) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This needs a changelog update, and the docs updating. |
graingert
added some commits
Sep 24, 2015
MichaelAquilina
reviewed
Sep 28, 2015
redshift_sqlalchemy/commands.py Outdated
MichaelAquilina
reviewed
Sep 28, 2015
redshift_sqlalchemy/commands.py Outdated
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
MichaelAquilina
commented
Sep 28, 2015
|
Looks good to me |
graingert
reviewed
Sep 28, 2015
| ACCEPTANYDATE | ||
| TIMEFORMAT AS 'auto' | ||
| """ % creds | ||
| copy = dialect.CopyCommand( |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
graingert
Sep 28, 2015
Collaborator
analogous code appears in the YPlan test suite but hits S3 and Redshift
graingert
Sep 28, 2015
Collaborator
analogous code appears in the YPlan test suite but hits S3 and Redshift
graingert commentedSep 24, 2015
No description provided.