New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TRUNCATECOLUMNS optional, also add all other parameters #52

Merged
merged 3 commits into from Sep 29, 2015

Conversation

Projects
None yet
2 participants
@graingert
Collaborator

graingert commented Sep 24, 2015

No description provided.

@graingert graingert changed the title from add missing copy command args to WIP: add missing copy command args Sep 24, 2015

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Sep 26, 2015

Collaborator

this breaks backwards comparability by removing some defaults eg:

        truncate_columns=True,
        delimiter=',',
        ignore_header=0,
        empty_as_null=True,
        blanks_as_null=True,
Collaborator

graingert commented Sep 26, 2015

this breaks backwards comparability by removing some defaults eg:

        truncate_columns=True,
        delimiter=',',
        ignore_header=0,
        empty_as_null=True,
        blanks_as_null=True,

@graingert graingert changed the title from WIP: add missing copy command args to Add missing copy commands, allow disabling TRUNCATECOLUMNS Sep 26, 2015

@graingert graingert changed the title from Add missing copy commands, allow disabling TRUNCATECOLUMNS to Make TRUNCATECOLUMNS optional, also add all other parameters Sep 26, 2015

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Sep 26, 2015

Collaborator

@jklukas I was wondering if I could have a set of AWS credentials that can only upload to an S3 bucket?

(To be able to test this code properly)

Collaborator

graingert commented Sep 26, 2015

@jklukas I was wondering if I could have a set of AWS credentials that can only upload to an S3 bucket?

(To be able to test this code properly)

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Sep 26, 2015

Collaborator

This needs a changelog update, and the docs updating.

Collaborator

graingert commented Sep 26, 2015

This needs a changelog update, and the docs updating.

@MichaelAquilina

This comment has been minimized.

Show comment
Hide comment
@MichaelAquilina

MichaelAquilina Sep 28, 2015

Looks good to me 👍

MichaelAquilina commented Sep 28, 2015

Looks good to me 👍

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert
Collaborator

graingert commented Sep 28, 2015

ACCEPTANYDATE
TIMEFORMAT AS 'auto'
""" % creds
copy = dialect.CopyCommand(

This comment has been minimized.

@graingert

graingert Sep 28, 2015

Collaborator

analogous code appears in the YPlan test suite but hits S3 and Redshift

@graingert

graingert Sep 28, 2015

Collaborator

analogous code appears in the YPlan test suite but hits S3 and Redshift

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Sep 29, 2015

Collaborator

@jklukas @thisfred @bouk @cpcloud I'm going to go ahead and merge this and make a release because I need it in production pretty sharpish

Collaborator

graingert commented Sep 29, 2015

@jklukas @thisfred @bouk @cpcloud I'm going to go ahead and merge this and make a release because I need it in production pretty sharpish

graingert added a commit that referenced this pull request Sep 29, 2015

Merge pull request #52 from graingert/add-missing-copy-command-args
 Make TRUNCATECOLUMNS optional, also add all other parameters

@graingert graingert merged commit d341cff into master Sep 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@graingert graingert deleted the add-missing-copy-command-args branch Sep 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment