Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy should have default format=None and fix statupdate #53

Merged
merged 1 commit into from Oct 7, 2015
Merged

copy should have default format=None and fix statupdate #53

merged 1 commit into from Oct 7, 2015

Conversation

solackerman
Copy link
Contributor

2 things are being done in this PR:

  1. Wen the format is omitted, no FORMAT AS ... is appended to the query. This makes the default the same as a normal redshift query
  2. STATUPDATE was being appended to the wrong variable

@graingert
Copy link
Member

Nice spot. Can you update the changelog?

@solackerman
Copy link
Contributor Author

Done :)

@graingert
Copy link
Member

@solackerman can you match the style of the rest of the changelog?

@graingert
Copy link
Member

Eg:

0.3.1 (unreleased)
------------------

- Fix breakages to CopyCommand introduced in 0.3.0:
  Thanks `solackerman <https://github.com/solackerman>`_.
  (`Issue #53 <https://github.com/graingert/redshift_sqlalchemy/pull/53>`_)

  - When `format` is omitted, no `FORMAT AS ...` is appended to the query. This
    makes the default the same as a normal redshift query.
  - fix STATUPDATE as a COPY parameter

@solackerman
Copy link
Contributor Author

done

@graingert
Copy link
Member

@solackerman can you squash all your commits into one please?

@solackerman
Copy link
Contributor Author

done

graingert added a commit that referenced this pull request Oct 7, 2015
copy should have default format=None and fix statupdate
@graingert graingert merged commit 18ca84e into sqlalchemy-redshift:master Oct 7, 2015
@graingert
Copy link
Member

@solackerman Awesome, thank-you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants