New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy should have default format=None and fix statupdate #53

Merged
merged 1 commit into from Oct 7, 2015

Conversation

Projects
None yet
2 participants
@solackerman
Contributor

solackerman commented Oct 7, 2015

2 things are being done in this PR:

  1. Wen the format is omitted, no FORMAT AS ... is appended to the query. This makes the default the same as a normal redshift query
  2. STATUPDATE was being appended to the wrong variable
@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 7, 2015

Collaborator

Nice spot. Can you update the changelog?

Collaborator

graingert commented Oct 7, 2015

Nice spot. Can you update the changelog?

@solackerman

This comment has been minimized.

Show comment
Hide comment
@solackerman

solackerman Oct 7, 2015

Contributor

Done :)

Contributor

solackerman commented Oct 7, 2015

Done :)

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 7, 2015

Collaborator

@solackerman can you match the style of the rest of the changelog?

Collaborator

graingert commented Oct 7, 2015

@solackerman can you match the style of the rest of the changelog?

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 7, 2015

Collaborator

Eg:

0.3.1 (unreleased)
------------------

- Fix breakages to CopyCommand introduced in 0.3.0:
  Thanks `solackerman <https://github.com/solackerman>`_.
  (`Issue #53 <https://github.com/graingert/redshift_sqlalchemy/pull/53>`_)

  - When `format` is omitted, no `FORMAT AS ...` is appended to the query. This
    makes the default the same as a normal redshift query.
  - fix STATUPDATE as a COPY parameter
Collaborator

graingert commented Oct 7, 2015

Eg:

0.3.1 (unreleased)
------------------

- Fix breakages to CopyCommand introduced in 0.3.0:
  Thanks `solackerman <https://github.com/solackerman>`_.
  (`Issue #53 <https://github.com/graingert/redshift_sqlalchemy/pull/53>`_)

  - When `format` is omitted, no `FORMAT AS ...` is appended to the query. This
    makes the default the same as a normal redshift query.
  - fix STATUPDATE as a COPY parameter
@solackerman

This comment has been minimized.

Show comment
Hide comment
@solackerman

solackerman Oct 7, 2015

Contributor

done

Contributor

solackerman commented Oct 7, 2015

done

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 7, 2015

Collaborator

@solackerman can you squash all your commits into one please?

Collaborator

graingert commented Oct 7, 2015

@solackerman can you squash all your commits into one please?

@solackerman

This comment has been minimized.

Show comment
Hide comment
@solackerman

solackerman Oct 7, 2015

Contributor

done

Contributor

solackerman commented Oct 7, 2015

done

graingert added a commit that referenced this pull request Oct 7, 2015

Merge pull request #53 from solackerman/master
copy should have default format=None and fix statupdate

@graingert graingert merged commit 18ca84e into sqlalchemy-redshift:master Oct 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 7, 2015

Collaborator

@solackerman Awesome, thank-you very much!

Collaborator

graingert commented Oct 7, 2015

@solackerman Awesome, thank-you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment