Rename package to sqlalchemy_redshift #58
Conversation
jklukas
force-pushed
the
rename-package
branch
from
ae87d75 to
c712dd3
Compare
| ) | ||
|
|
||
| # All references to module redshift_sqlalchemy will map to sqlalchemy_redshift | ||
| sys.modules['redshift_sqlalchemy'] = sqlalchemy_redshift |
There was a problem hiding this comment.
I just discovered sys.modules. This appears to do the magic that we want. It's possible to do imports like from redshift_sqlalchemy.dialect import RedshiftDDLCompiler.
There was a problem hiding this comment.
this is correct but according to the six.py source code this method breaks:
from redshift_sqlalchemy import dialect
reload(dialect)but I don't mind.
Can you add a deprecation warning to this module?
|
It would be quite nice if you could you split this into two commits and submit them one at a time so travis sees each one:
This way we can prove the compatability module works But I'm not fussed if you don't want to, I'm still happy to merge this as is |
jklukas
force-pushed
the
rename-package
branch
3 times, most recently
from
dd9d4f0 to
b99f027
Compare
| a future release, so it is recommended to update all package references. | ||
| """ | ||
|
|
||
| warnings.warn(DEPRECATION_MESSAGE, DeprecationWarning) |
There was a problem hiding this comment.
DeprecationWarning is ignored by default, but would seem to be the semantically correct choice here.
|
I understand the philosophy of why you'd want to split this up, but I'm not inclined to put in the extra work to make it happen. |
jklukas
force-pushed
the
rename-package
branch
from
b99f027 to
e39ff7e
Compare
|
Rebased to edit the commit with broken README.rst. |
| @@ -1,7 +1,10 @@ | |||
| 0.3.2 (unreleased) | |||
| ------------------ | |||
|
|
|||
| - Nothing changed yet. | |||
| - Change the name of the package to `sqlalchemy_redshift` to match the naming | |||
| convention for other dialects; the `redshift_sqlalchemy` now references | |||
There was a problem hiding this comment.
missed a word? Should this be "the deprecated redshift_sqlalchemy now references..."?
jklukas
force-pushed
the
rename-package
branch
from
e39ff7e to
a1f6994
Compare
|
Updated the CHANGELOG message. |
|
Perfect! Merge when ready |
Rename package to sqlalchemy_redshift
Fixes #40.