New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to sqlalchemy_redshift #58

Merged
merged 2 commits into from Oct 24, 2015

Conversation

Projects
None yet
2 participants
@jklukas
Collaborator

jklukas commented Oct 23, 2015

Fixes #40.

@jklukas jklukas referenced this pull request Oct 23, 2015

Closed

Migration plan for moving to the sqlalchemy-redshift org #40

5 of 5 tasks complete
Show outdated Hide outdated redshift_sqlalchemy/__init__.py Outdated
@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 23, 2015

Collaborator

It would be quite nice if you could you split this into two commits and submit them one at a time so travis sees each one:

  1. where you
    • rename the module redshift_sqlalchemy
    • create the compat module
    • update the changelog
  2. where you update the tests + docs to point at sqlalchemy_redshift

This way we can prove the compatability module works

But I'm not fussed if you don't want to, I'm still happy to merge this as is

Collaborator

graingert commented Oct 23, 2015

It would be quite nice if you could you split this into two commits and submit them one at a time so travis sees each one:

  1. where you
    • rename the module redshift_sqlalchemy
    • create the compat module
    • update the changelog
  2. where you update the tests + docs to point at sqlalchemy_redshift

This way we can prove the compatability module works

But I'm not fussed if you don't want to, I'm still happy to merge this as is

a future release, so it is recommended to update all package references.
"""
warnings.warn(DEPRECATION_MESSAGE, DeprecationWarning)

This comment has been minimized.

@jklukas

jklukas Oct 23, 2015

Collaborator

DeprecationWarning is ignored by default, but would seem to be the semantically correct choice here.

@jklukas

jklukas Oct 23, 2015

Collaborator

DeprecationWarning is ignored by default, but would seem to be the semantically correct choice here.

This comment has been minimized.

@graingert

graingert Oct 23, 2015

Collaborator

nice

@graingert

graingert Oct 23, 2015

Collaborator

nice

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Oct 23, 2015

Collaborator

I understand the philosophy of why you'd want to split this up, but I'm not inclined to put in the extra work to make it happen.

Collaborator

jklukas commented Oct 23, 2015

I understand the philosophy of why you'd want to split this up, but I'm not inclined to put in the extra work to make it happen.

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Oct 23, 2015

Collaborator

Rebased to edit the commit with broken README.rst.

Collaborator

jklukas commented Oct 23, 2015

Rebased to edit the commit with broken README.rst.

Show outdated Hide outdated CHANGES.rst Outdated
@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Oct 23, 2015

Collaborator

Updated the CHANGELOG message.

Collaborator

jklukas commented Oct 23, 2015

Updated the CHANGELOG message.

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Oct 23, 2015

Collaborator

Perfect! Merge when ready

Collaborator

graingert commented Oct 23, 2015

Perfect! Merge when ready

jklukas added a commit that referenced this pull request Oct 24, 2015

@jklukas jklukas merged commit a85c4c1 into master Oct 24, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jklukas jklukas deleted the rename-package branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment