Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to sqlalchemy_redshift #58

Merged
merged 2 commits into from Oct 24, 2015
Merged

Rename package to sqlalchemy_redshift #58

merged 2 commits into from Oct 24, 2015

Conversation

@jklukas
Copy link
Collaborator

@jklukas jklukas commented Oct 23, 2015

Fixes #40.

@jklukas jklukas mentioned this pull request Oct 23, 2015
5 of 5 tasks complete
@jklukas jklukas force-pushed the rename-package branch from ae87d75 to c712dd3 Oct 23, 2015
)

# All references to module redshift_sqlalchemy will map to sqlalchemy_redshift
sys.modules['redshift_sqlalchemy'] = sqlalchemy_redshift

This comment has been minimized.

@jklukas

jklukas Oct 23, 2015
Author Collaborator

I just discovered sys.modules. This appears to do the magic that we want. It's possible to do imports like from redshift_sqlalchemy.dialect import RedshiftDDLCompiler.

This comment has been minimized.

@graingert

graingert Oct 23, 2015
Collaborator

this is correct but according to the six.py source code this method breaks:

from redshift_sqlalchemy import dialect
reload(dialect)

but I don't mind.

Can you add a deprecation warning to this module?

@graingert
Copy link
Collaborator

@graingert graingert commented Oct 23, 2015

It would be quite nice if you could you split this into two commits and submit them one at a time so travis sees each one:

  1. where you
    • rename the module redshift_sqlalchemy
    • create the compat module
    • update the changelog
  2. where you update the tests + docs to point at sqlalchemy_redshift

This way we can prove the compatability module works

But I'm not fussed if you don't want to, I'm still happy to merge this as is

@jklukas jklukas force-pushed the rename-package branch 3 times, most recently from dd9d4f0 to b99f027 Oct 23, 2015
a future release, so it is recommended to update all package references.
"""

warnings.warn(DEPRECATION_MESSAGE, DeprecationWarning)

This comment has been minimized.

@jklukas

jklukas Oct 23, 2015
Author Collaborator

DeprecationWarning is ignored by default, but would seem to be the semantically correct choice here.

This comment has been minimized.

@graingert

graingert Oct 23, 2015
Collaborator

nice

@jklukas
Copy link
Collaborator Author

@jklukas jklukas commented Oct 23, 2015

I understand the philosophy of why you'd want to split this up, but I'm not inclined to put in the extra work to make it happen.

@jklukas jklukas force-pushed the rename-package branch from b99f027 to e39ff7e Oct 23, 2015
@jklukas
Copy link
Collaborator Author

@jklukas jklukas commented Oct 23, 2015

Rebased to edit the commit with broken README.rst.

CHANGES.rst Outdated
@@ -1,7 +1,10 @@
0.3.2 (unreleased)
------------------

- Nothing changed yet.
- Change the name of the package to `sqlalchemy_redshift` to match the naming
convention for other dialects; the `redshift_sqlalchemy` now references

This comment has been minimized.

@graingert

graingert Oct 23, 2015
Collaborator

missed a word? Should this be "the deprecated redshift_sqlalchemy now references..."?

@jklukas jklukas force-pushed the rename-package branch from e39ff7e to a1f6994 Oct 23, 2015
@jklukas
Copy link
Collaborator Author

@jklukas jklukas commented Oct 23, 2015

Updated the CHANGELOG message.

@graingert
Copy link
Collaborator

@graingert graingert commented Oct 23, 2015

Perfect! Merge when ready

jklukas added a commit that referenced this pull request Oct 24, 2015
Rename package to sqlalchemy_redshift
@jklukas jklukas merged commit a85c4c1 into master Oct 24, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jklukas jklukas deleted the rename-package branch May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.