Order columns by attnum to ensure proper ordering in reflected table #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
force-pushed
the
reflection-fix
branch
2 times, most recently
from
d461db2 to
931d062
Compare
jklukas
force-pushed
the
reflection-fix
branch
from
931d062 to
559d3f8
Compare
jklukas
changed the title
| @@ -88,6 +88,7 @@ class ReflectionIdentity(Base): | |||
| __tablename__ = 'reflection_identity' | |||
| col1 = sa.Column(sa.Integer(), primary_key=True) | |||
| col2 = sa.Column(sa.Integer(), info={'identity': (1, 3)}) | |||
| col3 = sa.Column(sa.Integer()) | |||
There was a problem hiding this comment.
This test was only passing before because the IDENTITY column already happened to be the last one. This test now fails under the old code and passes under the new code (where we add attnum to the ORDER BY clause).
|
nice, merge this when you're ready |
jklukas
force-pushed
the
reflection-fix
branch
from
559d3f8 to
77ea92a
Compare
jklukas
added a commit
that referenced
this pull request
Nov 2, 2015
Order columns by attnum to ensure proper ordering in reflected table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDENTITYcolumns were being put at the end of reflectedCREATE TABLEstatements, regardless of their actual order in the original table definition.