New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.5 to tox config #61

Merged
merged 3 commits into from Nov 2, 2015

Conversation

Projects
None yet
2 participants
@jklukas
Collaborator

jklukas commented Oct 24, 2015

No description provided.

@jklukas jklukas changed the title from WIP: Add python 3.5 to tox config and pypi attributes to Add python 3.5 to tox config Oct 24, 2015

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Nov 2, 2015

Collaborator

nice, can you update travis as well?

Collaborator

graingert commented Nov 2, 2015

nice, can you update travis as well?

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Nov 2, 2015

Collaborator

Updated the travis config.

Collaborator

jklukas commented Nov 2, 2015

Updated the travis config.

@@ -1,11 +1,12 @@
language: python
python: 3.4
python: 3.5

This comment has been minimized.

@jklukas

jklukas Nov 2, 2015

Collaborator

Keeping the python version to the latest seems like a reasonable default here.

@jklukas

jklukas Nov 2, 2015

Collaborator

Keeping the python version to the latest seems like a reasonable default here.

This comment has been minimized.

@graingert

graingert Nov 2, 2015

Collaborator

I agree

@graingert

graingert Nov 2, 2015

Collaborator

I agree

@@ -10,6 +10,8 @@
- Fix a bug where reflecting a table could raise a ``NoSuchTableError``
in cases where its schema is not on the current ``search_path``
(`Issue #64 <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/pull/64>`_)
- Add python 3.5 to the list of versions for integration tests.
(`Issue #61 <https://github.com/sqlalchemy-redshift/sqlalchemy-redshift/pull/61>`_)

This comment has been minimized.

@graingert

graingert Nov 2, 2015

Collaborator

probably not worth the CHANGES.rst unless you update the trove classifiers:

setup(
    ...
    classifiers=[
        ...
        'Programming Language :: Python',
        'Programming Language :: Python :: 2.6',
        'Programming Language :: Python :: 2.7',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.3',
        'Programming Language :: Python :: 3.4'
        'Programming Language :: Python :: 3.5',
        ...
    ],
...
)
@graingert

graingert Nov 2, 2015

Collaborator

probably not worth the CHANGES.rst unless you update the trove classifiers:

setup(
    ...
    classifiers=[
        ...
        'Programming Language :: Python',
        'Programming Language :: Python :: 2.6',
        'Programming Language :: Python :: 2.7',
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.3',
        'Programming Language :: Python :: 3.4'
        'Programming Language :: Python :: 3.5',
        ...
    ],
...
)

This comment has been minimized.

@jklukas

jklukas Nov 2, 2015

Collaborator

It's never been clear to me whether explicitly listing supported versions is actually useful to anybody.

I guess we might as well?

@jklukas

jklukas Nov 2, 2015

Collaborator

It's never been clear to me whether explicitly listing supported versions is actually useful to anybody.

I guess we might as well?

This comment has been minimized.

@graingert

graingert Nov 2, 2015

Collaborator

all the cool kids are doing it 👍

@graingert

graingert Nov 2, 2015

Collaborator

all the cool kids are doing it 👍

@jklukas

This comment has been minimized.

Show comment
Hide comment
@jklukas

jklukas Nov 2, 2015

Collaborator

Added trove classifiers.

Collaborator

jklukas commented Nov 2, 2015

Added trove classifiers.

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert Nov 2, 2015

Collaborator

nice one, feel free to merge when this goes green

Collaborator

graingert commented Nov 2, 2015

nice one, feel free to merge when this goes green

jklukas added some commits Oct 24, 2015

Update pytest version
pytest 2.7.0 has compatibility issues with py 3.5 for assertion rewriting.

jklukas added a commit that referenced this pull request Nov 2, 2015

@jklukas jklukas merged commit cb8631d into master Nov 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jklukas jklukas deleted the py35 branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment