New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add role-based credentials to COPY and UNLOAD command #88

Merged
merged 1 commit into from May 18, 2016

Conversation

Projects
None yet
3 participants
@mtrbean
Contributor

mtrbean commented May 8, 2016

Closes #87

Todos

  • MIT compatible
  • Tests
  • Documentation
  • Updated CHANGES.rst
@@ -51,6 +52,22 @@ def test_basic_copy_case():
assert clean(expected_result) == clean(compile_query(copy))
def test_iam_role():
"""Tests the use of iam role instead of access keys."""

This comment has been minimized.

@graingert

graingert May 8, 2016

Collaborator

I'd probably put iam_role as a variable here.

@graingert

graingert May 8, 2016

Collaborator

I'd probably put iam_role as a variable here.

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert May 8, 2016

Collaborator

@mtrbean can you clean up your commits, and tick all the boxes as appropriate

Collaborator

graingert commented May 8, 2016

@mtrbean can you clean up your commits, and tick all the boxes as appropriate

@mtrbean

This comment has been minimized.

Show comment
Hide comment
@mtrbean

mtrbean May 9, 2016

Contributor

I have moved iam_role to the test functions and squashed the commits.

Contributor

mtrbean commented May 9, 2016

I have moved iam_role to the test functions and squashed the commits.

@mtrbean

This comment has been minimized.

Show comment
Hide comment
@mtrbean

mtrbean May 12, 2016

Contributor

Changes made, let me know if anything further changes needed

Contributor

mtrbean commented May 12, 2016

Changes made, let me know if anything further changes needed

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert May 15, 2016

Collaborator

looks good, squash your commits though

Collaborator

graingert commented May 15, 2016

looks good, squash your commits though

@mtrbean

This comment has been minimized.

Show comment
Hide comment
@mtrbean

mtrbean May 16, 2016

Contributor

Squashed. I think you can also make Github squash the commits for you when you merge.

Contributor

mtrbean commented May 16, 2016

Squashed. I think you can also make Github squash the commits for you when you merge.

@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert May 16, 2016

Collaborator

I can it's nicer not to though as it looses the merge commit
On 16 May 2016 7:29 pm, "Eric Wong" notifications@github.com wrote:

Squashed. I think you can also make Github squash the commits for you when
you merge.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#88 (comment)

Collaborator

graingert commented May 16, 2016

I can it's nicer not to though as it looses the merge commit
On 16 May 2016 7:29 pm, "Eric Wong" notifications@github.com wrote:

Squashed. I think you can also make Github squash the commits for you when
you merge.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#88 (comment)

@mtrbean

This comment has been minimized.

Show comment
Hide comment
@mtrbean

mtrbean May 18, 2016

Contributor

@graingert can this be merged?

Contributor

mtrbean commented May 18, 2016

@graingert can this be merged?

@graingert graingert merged commit cb93725 into sqlalchemy-redshift:master May 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@graingert

This comment has been minimized.

Show comment
Hide comment
@graingert

graingert May 18, 2016

Collaborator

@mtrbean merged! thanks :)

Collaborator

graingert commented May 18, 2016

@mtrbean merged! thanks :)

@mtrbean mtrbean deleted the mtrbean:rolebased-credentials branch Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment