Table identifier #97
Merged
Table identifier #97
+80
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's something up with your rebase |
Use a schema name explicitly
jklukas
force-pushed
the
table-identifier
branch
from
88813d6 to
9aa9546
Compare
|
I don't know what was up with the rebase. I did some surgery and I think this is correct now. |
|
Looks like there's an error in the tests here. Will investigate. |
jklukas
force-pushed
the
table-identifier
branch
from
9aa9546 to
33c380c
Compare
|
Merged in a change that takes out the now-unnecessary test about splitting schema and table name. |
|
I recommened removing it and re-applying your rebase |
jklukas
force-pushed
the
table-identifier
branch
2 times, most recently
from
f16dfba to
5929d27
Compare
|
Pulled in that change and rebased again. Tests are passing this time, so ready for review. |
|
@graingert - This is a bug fix, so I don't see the need for any documentation changes. Does this warrant something in the changelog? |
|
Definitely change the changelog |
jklukas
force-pushed
the
table-identifier
branch
from
5929d27 to
115de57
Compare
|
Added in a line in CHANGES.rst and squashed. |
|
@jklukas is this ready to go? |
|
Yes, this should be good to merge. Are you +1, @graingert ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
This builds on #78 and avoids the trouble of parsing qualified table names by instead introducing a
RelationKeynamedtuple that tracks those values separately.Does this look like a good approach?