New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent parameter naming #104

Closed
sqlalchemy-bot opened this Issue Feb 11, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@sqlalchemy-bot

sqlalchemy-bot commented Feb 11, 2013

Migrated issue, originally created by Robert Buchholz (@rbuchholz)

Keyword arguments for several of op's functions are inconsistent:

  • create_index, drop_index, drop_constraint has tablename whereas add_column and others have table_name
  • alter_column receives a 'name' parameter that should really be 'new_column_name'
@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Feb 11, 2013

Michael Bayer (@zzzeek) wrote:

this is all fine and it would be helpful if you could carefully review the changes I've made in 8cdd16e in this regard. Where an argument was an optional keyword, we still accept the old name, with a warning. Where an argument was positional, we no longer can accept the old name, but also I would assume users are generally passing in required positional arguments positionally (that you noticed this naming inconsistency suggests perhaps you weren't...).

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Feb 11, 2013

Michael Bayer (@zzzeek) wrote:

reopen if further adjustments needed

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Feb 11, 2013

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment