Inconsistent parameter naming

[sqlalchemy-bot]

Migrated issue, originally created by Robert Buchholz (@rbuchholz)

Keyword arguments for several of op's functions are inconsistent:

• create_index, drop_index, drop_constraint has tablename whereas add_column and others have table_name
• alter_column receives a 'name' parameter that should really be 'new_column_name'

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

this is all fine and it would be helpful if you could carefully review the changes I've made in 8cdd16e in this regard. Where an argument was an optional keyword, we still accept the old name, with a warning. Where an argument was positional, we no longer can accept the old name, but also I would assume users are generally passing in required positional arguments positionally (that you noticed this naming inconsistency suggests perhaps you weren't...).

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

reopen if further adjustments needed

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed