Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we really, really need at least rudimental autogen for indexes #107

Closed
sqlalchemy-bot opened this issue Feb 19, 2013 · 5 comments
Closed

we really, really need at least rudimental autogen for indexes #107

sqlalchemy-bot opened this issue Feb 19, 2013 · 5 comments

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented Feb 19, 2013

Migrated issue, originally created by Michael Bayer (@zzzeek)

this is critical because, Column('x', unique=True) generates a constraint whereas Column('x', unique=True, index=True) does not, because it's unique index. this has already bit us here.

we support reflection for indexes so this should be good to go, really.


Attachments: alembic_107_partial.diff

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented May 16, 2013

Michael Bayer (@zzzeek) wrote:

partial patch courtesy of limodou. needs tests and such.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented May 16, 2013

Changes by Michael Bayer (@zzzeek):

  • attached file alembic_107_partial.diff
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Jun 7, 2013

Changes by Michael Bayer (@zzzeek):

  • added labels: autogenerate - detection
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Sep 8, 2013

Michael Bayer (@zzzeek) wrote:

0eaddaf has the merge and 17e671b has a refactoring of autogenerate, which is growing quite large.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Sep 8, 2013

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.