Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub generator for proxy classes does not generate overload stubs #1147

Closed
vfazio opened this issue Dec 29, 2022 · 1 comment
Closed

Stub generator for proxy classes does not generate overload stubs #1147

vfazio opened this issue Dec 29, 2022 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists pep 484 typing related issues

Comments

@vfazio
Copy link
Contributor

vfazio commented Dec 29, 2022

Describe the bug

The stub generator for proxy classes (tools/write_pyi.py) does not generate overload stubs

Expected behavior

To accurately reflect the typing of the proxied classes, the overloads should be stubbed out.
@vfazio vfazio added the requires triage New issue that requires categorization label Dec 29, 2022
vfazio added a commit to vfazio/alembic that referenced this issue Dec 29, 2022
@vfazio
generate overload type stubs
8291245 
Add support for generating @overload type stubs for proxied classes.

This should fix typing issues with overloaded functions such as
`context.get_x_argument` that narrow return types based on parameters.

Fixes: sqlalchemy#1147

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
@vfazio vfazio mentioned this issue Dec 29, 2022
Closed
3 tasks
@CaselIT CaselIT added bug Something isn't working pep 484 typing related issues and removed requires triage New issue that requires categorization labels Dec 30, 2022
@CaselIT
Copy link
Member

CaselIT commented Dec 30, 2022

Hi,

this seems a duplicate of #1146. We can continue to the other one

@CaselIT CaselIT closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2022
@CaselIT CaselIT added the duplicate This issue or pull request already exists label Dec 30, 2022
vfazio added a commit to vfazio/alembic that referenced this issue Dec 30, 2022
@vfazio
generate overload type stubs
bad884b 
Add support for generating @overload type stubs for proxied classes.

This should fix typing issues with overloaded functions such as
`context.get_x_argument` that narrow return types based on parameters.

Fixes: sqlalchemy#1147

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
vfazio added a commit to vfazio/alembic that referenced this issue Dec 30, 2022
@vfazio
generate overload type stubs
586cd94 
Add support for generating @overload type stubs for proxied classes.

This should fix typing issues with overloaded functions such as
`context.get_x_argument` that narrow return types based on parameters.

Fixes: sqlalchemy#1147

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
vfazio added a commit to vfazio/alembic that referenced this issue Dec 30, 2022
@vfazio
generate overload type stubs
1cd92bd 
Add support for generating @overload type stubs for proxied classes.

This should fix typing issues with overloaded functions such as
`context.get_x_argument` that narrow return types based on parameters.

Fixes: sqlalchemy#1147

Signed-off-by: Vincent Fazio <vfazio@gmail.com>
sqlalchemy-bot pushed a commit that referenced this issue Jan 3, 2023
@vfazio
add overload stubs for proxied classes
40df5ec 
<!-- Provide a general summary of your proposed changes in the Title field above -->

### Description
Closes #1146
Closes #1147

<!-- Describe your changes in detail -->

Overloaded functions would not have type stubs generated by the stub generator for proxied classes. Now they will.

### Checklist
<!-- go over following points. check them with an `x` if they do apply, (they turn into clickable checkboxes once the PR is submitted, so no need to do everything at once)

-->

This pull request is:

- [ ] A documentation / typographical error fix
	- Good to go, no issue or tests are needed
- [x] A short code fix
	- please include the issue number, and create an issue if none exists, which
	  must include a complete example of the issue.  one line code fixes without an
	  issue and demonstration will not be accepted.
	- Please include: `Fixes: #<issue number>` in the commit message
	- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
	- please include the issue number, and create an issue if none exists, which must
	  include a complete example of how the feature would look.
	- Please include: `Fixes: #<issue number>` in the commit message
	- please include tests.

Closes: #1148
Pull-request: #1148
Pull-request-sha: ed3c28c

Change-Id: I7c0ee9d333015174ee6ab754909748f745af2ff9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists pep 484 typing related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add overload stubs for proxied classes vfazio/alembic
2 participants
@vfazio @CaselIT