Skip to content

Don't use type(None) as fallback for Computed or Identity #1237

@CaselIT

Description

@CaselIT

In old version of sqlalchemy, that don't have Computed or Identity a fallback in alembic is used.
The current fallback is to set these values to type(None)

This causes issues since checks like isinstance(something, Computed) will pass when something is None, leading to attribute errors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions