Repository navigation
alembic merge ignores revision_environment and cannot find the hooks defined in env.py #1299
Description
Describe the bug
As title says, alembic merge ignores revision_environment and cannot find the hooks defined in env.py.
Expected behavior
Custom hooks work the way they do when generating revisions
To Reproduce
# alembic.ini
revision_environment = true
hooks = ruff
ruff.type = ruff
ruff.options = --select I --select F401 --fix# env.py
from alembic.script import write_hooks
@write_hooks.register("ruff")
def run_ruff(filename, options):
ruff = os.path.join(sysconfig.get_path("scripts"), "ruff")
os.system(f"{ruff} {options['options']} {filename}") # noqa: S605Error
Running post write hook 'ruff' ...
FAILED
FAILED: No formatter with name 'ruff' registered.
Versions.
- Python: 3.11.1
- Alembic: 1.11.3
Additional context
For the ruff example, this may become useless after #1276, but it is still needed for the rest of the custom hooks .
Have a nice day!
Thanks, you too!
Activity
sqla-tester commentedon Aug 22, 2023
Mike Bayer has proposed a fix for this issue in the main branch:
implement revision_environment for merge https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4817
zzzeek commentedon Aug 22, 2023
thanks for reporting
implement revision_environment for merge