Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create special rendering for Variant #131

Closed
sqlalchemy-bot opened this issue Jun 21, 2013 · 3 comments

Comments

@sqlalchemy-bot
Copy link

commented Jun 21, 2013

Migrated issue, originally created by Michael Bayer (@zzzeek)

a Variant() type would ideally be rendered like this:

op.add_column(Column("mycol", Variant(Enum, {"mysql": mysql.ENUM(...), "postgresql": postgresql.ENUM(...)})

the special thing here is that Variant() will typically have lots of dialect-specific types in it, which means we need to get dialect prefixes into the render. So this kind of takes it outside the realm of straight repr() and I think alembic should have a special renderer for it.

@sqlalchemy-bot

This comment has been minimized.

Copy link
Author

commented Aug 22, 2017

Michael Bayer (@zzzeek) wrote:

comment support would be a different issue. not sure if one already exists.

@sqlalchemy-bot

This comment has been minimized.

Copy link
Author

commented Aug 22, 2017

@sqla-tester

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2019

Mike Bayer has proposed a fix for this issue in the master branch:

Render Variant types https://gerrit.sqlalchemy.org/1472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.