Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alembic.config.main() does not pass argv through to argparse #22

Closed
sqlalchemy-bot opened this issue Jan 20, 2012 · 3 comments
Closed

alembic.config.main() does not pass argv through to argparse #22

sqlalchemy-bot opened this issue Jan 20, 2012 · 3 comments
Labels
bug

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented Jan 20, 2012

Migrated issue, originally created by Daniel Miller (@millerdev)

Patch attached. Really not much to it.

options = parser.parse_args()

becomes

options = parser.parse_args(argv)


Attachments: argv.patch

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Jan 20, 2012

Michael Bayer (@zzzeek) wrote:

mmm except that seems to break the runner. I think we need to pass argv only if it's present.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Jan 20, 2012

Michael Bayer (@zzzeek) wrote:

correction, the no-longer-used scripts/alembic misuses it. so took that out. [[https://bitbucket.org/zzzeek/alembic/changeset/97392926fe5b7a9e95da846014fb3a4d9b1d239a|97392926fe5b7a9e95da846014fb3a4d9b1d239a]]

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Jan 20, 2012

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant