Should "stamp heads" work?

[sqlalchemy-bot]

Migrated issue, originally created by MichaelE (@miracle2k)

I want to stamp all heads. It currently tells me:

INFO  [alembic.migration] Context impl MySQLImpl.
INFO  [alembic.migration] Will assume non-transactional DDL.
ERROR [alembic.util] Multiple head revisions are present for given argument 'heads'; please specify a specific target revision, '<branchname>@heads' to narrow to a specific head, or 'heads' for all heads
  FAILED: Multiple head revisions are present for given argument 'heads'; please specify a specific target revision, '<branchname>@heads'
  to narrow to a specific head, or 'heads' for all heads

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

• Added support for "alembic stamp" to work when given "heads" as an
  argument, when multiple heads are present.
  fixes #267

→ 56d56f5

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

so I sort of left this off at first because stamp was so difficult to get it working in the first place, I didn't feel like pushing it. But as you can see this was a simple change.

[sqlalchemy-bot]

MichaelE (@miracle2k) wrote:

Just amazing, thanks.

[sqlalchemy-bot]

MichaelE (@miracle2k) wrote:

I have run into a problem trying to use this, which is that

"stamp foo@heads"

is idempotent, but

stamp heads

fails when there a branch doesn't need to be stamped:

  File "<string>", line 7, in run_migrations
  File "/Users/michael/.virtualenvs/cms26/lib/python2.6/site-packages/alembic/environment.py", line 742, in run_migrations
    self.get_context().run_migrations(**kw)
  File "/Users/michael/.virtualenvs/cms26/lib/python2.6/site-packages/alembic/migration.py", line 316, in run_migrations
    head_maintainer.update_to_step(step)
  File "/Users/michael/.virtualenvs/cms26/lib/python2.6/site-packages/alembic/migration.py", line 475, in update_to_step
    self._insert_version(vers)
  File "/Users/michael/.virtualenvs/cms26/lib/python2.6/site-packages/alembic/migration.py", line 424, in _insert_version
    assert version not in self.heads
AssertionError

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

stamp was really hard to write.... :) ok

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

fix one remaining aspect

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to reopened

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

• additional fix which impacts #267. fix filtered_heads() to accommodate
  being given "heads" as the target so that it will in fact match when all heads
  are given. fixes #267

→ e8a0c74

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed