New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS SQL server implementation produce DROP COLUMN queries without schema #284

Closed
sqlalchemy-bot opened this Issue Mar 11, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@sqlalchemy-bot

sqlalchemy-bot commented Mar 11, 2015

Migrated issue, originally created by dmazhar

Hi. I have such lines in my autogenerated migration script:

op.drop_column(u'asset_ID', 'asset_type', schema=u'HARDWARE')

It's in downgrade section, and when I'm running downgrade it produces next SQL query:

ALTER TABLE [asset_ID] DROP COLUMN asset_type;

So the schema was omitted in this query and migration fails.

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Mar 11, 2015

Michael Bayer (@zzzeek) wrote:

  • Fixed bug where the mssql DROP COLUMN directive failed to include
    modifiers such as "schema" when emitting the DDL.
    fixes #284

6235698

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Mar 11, 2015

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Mar 11, 2015

Michael Bayer (@zzzeek) wrote:

thank you

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Mar 11, 2015

dmazhar wrote:

Thanks Mike. You're super fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment