autogen primary key renderer uses column.key instead of column.name when assembling list of columns

[sqlalchemy-bot]

Migrated issue, originally created by Jesse Dhillon (@jessedhillon)

Possibly related to #259

When rendering PrimaryKeyConstraint, I've noticed that I have to manually fix the output because the list of columns references each column's key property instead of name. Reading the SQLAlchemy docs, particularly:

The name of this column as represented in the database.

~ sqlalchemy.schema.Column.params.name

and

the name field is used only when rendering SQL.

~ sqlalchemy.schema.Column.params.key

it seems that name is the correct choice when building a PrimaryKeyConstraint.

[sqlalchemy-bot]

Jesse Dhillon (@jessedhillon) wrote:

PR https://bitbucket.org/zzzeek/alembic/pull-requests/49/fixes-335/diff

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

all of these things are true! thanks for the PR, on my list.

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• set milestone to "fasttrack"

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

• PrimaryKeyConstraint should be rendered referencing the name
  property of the columns it comprises, instead of the key. See autogen primary key renderer uses column.key instead of column.name when assembling list of columns #335

→ 5b630c1

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

• changelog for pr49, fixes autogen primary key renderer uses column.key instead of column.name when assembling list of columns #335

→ dd882e3

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed